Commit Graph

5754 Commits

Author SHA1 Message Date
Alban Crequy
f1e2b5d93a probe: conntrack: fix output parsing
With net.netfilter.nf_conntrack_acct = 1, conntrack adds the following
fields in the output: packets=3 bytes=164

And with SELinux (e.g. Fedora), conntrack adds: secctx=...

The parsing with fmt.Sscanf introduced in #2095 was unfortunately
rejecting lines with those fields. This patch fixes that by adding more
complicated parsing in decodeFlowKeyValues() with FieldsFunc and SplitN.

Fixes #2117
Regression from #2095
2017-01-17 19:30:56 +01:00
Alfonso Acosta
75ed573425 Remove whitespace 2017-01-17 12:32:22 +00:00
Alfonso Acosta
8fe95c6519 Fix typo 2017-01-17 12:31:36 +00:00
Alfonso Acosta
13ef7f39c6 Merge pull request #2134 from weaveworks/ci-push-to-quay
Deploy to quay when merging to master
2017-01-17 13:04:44 +01:00
Alfonso Acosta
a8a2911bda Deploy to quay when merging to master
To workaround the 500s obtained from Docker Hub
2017-01-17 11:20:25 +00:00
Mike Lang
2b7662a3c6 Make reporter tests a seperate package to appease linter
This requires making All The Things public. Yuck.
2017-01-17 03:02:47 -08:00
Alfonso Acosta
496e3f2072 Merge pull request #2114 from weaveworks/1972-non-established-proc-conns
Report persistent connections in states other than ESTABLISHED
2017-01-17 10:45:53 +01:00
Alfonso Acosta
c6f7bdc78e Obtain local pods from kubelet 2017-01-16 18:50:03 +00:00
Filip Barl
fa56c030e2 Merge pull request #2109 from weaveworks/node-details-multicolumn-table
Add support for generic multicolumn tables
2017-01-16 17:27:56 +01:00
Filip Barl
d3466b5454 Refactored the table component/model and wrote the tests
Backward-compatibility fix
2017-01-16 17:05:36 +01:00
Filip Barl
6888108b83 Made the searching of generic tables work on the UI
Extracted table headers common code on the frontend

Fixed the search matching and extracted further common code in the UI
2017-01-16 12:22:10 +01:00
Filip Barl
e475a09ee6 Rendering sortable generic tables in the UI
Rendering generic table columns

Made Type a required attribute for TableTemplate

Made generic table sortable on the UI
2017-01-16 12:22:10 +01:00
Filip Barl
31be525bd2 Created generic table model on backend
Replaced MetadataRow with generic Row in Table model

Sending through multicolumn tables from the backend
2017-01-16 12:22:10 +01:00
Alfonso Acosta
92b3cbe952 Merge pull request #2131 from josephglanville/docs-running-tests
Document how to run tests on website
2017-01-16 11:35:58 +01:00
Joseph Glanville
535aa5629e Document how to run tests on website 2017-01-15 18:52:34 +11:00
Mike Lang
5c19dc792e ecs probe: add tests for reporter 2017-01-13 17:31:29 -08:00
Jordan Pellizzari
bd32580a4b Merge pull request #2124 from weaveworks/2123-search-errors
Removed leading slash from getAllNodes() api request
2017-01-13 08:26:50 -08:00
Mike Lang
685af493bf ecs probe: Allow cache settings to be tweaked 2017-01-12 11:37:23 -08:00
Mike Lang
513977081d aws ecs probe: Use a size and time bound LRU gcache for caching
instead of our own hand-rolled size-unbound cache
2017-01-12 10:34:41 -08:00
Mike Lang
e220ae822f wip: 2017-01-12 07:11:12 -08:00
jpellizzari
71485db4df Removed leading slash from getAllNodes() api request 2017-01-11 14:20:18 -08:00
Alfonso Acosta
2be26e2be4 Limit connections to established and half-closed 2017-01-10 15:35:32 +00:00
Jordan Pellizzari
4d50c6950c Merge pull request #2080 from weaveworks/1872-clear-ui-state
Add control to reset local view state
2017-01-09 18:14:31 -08:00
Iago López Galeiras
ec0b6dd8d0 backend: add shfmt command to the docker image 2017-01-09 16:40:16 +01:00
Iago López Galeiras
643827d9a7 Re-add generate_latest_map script
It was removed from the build-tools repository. Add it to extra/ and fix
a couple of linter errors.
2017-01-09 16:40:16 +01:00
Iago López Galeiras
5d06a23fe1 tools: remove generate_latest_map
It seems it was added directly to the scope repo instead of adding it to
the build-tools repo so we need to delete it manually.
2017-01-09 16:40:16 +01:00
Iago López Galeiras
d9ce1d58e9 Squashed 'tools/' changes from b990f488..4b7d5c61
4b7d5c61 Merge pull request #59 from weaveworks/57-fix-lint-properly
b7f0e692 Merge pull request #58 from weaveworks/fix-lint
794702c7 Pin version of shfmt
ab1b11de Fix lint
81d80f35 Merge pull request #55 from weaveworks/lint-tf
05ad5f27 Review feedback
4c0d0469 Use hclfmt to lint terraform.
fd875e27 Fix test wrt shellcheck
54ec2d92 Don't capitalise error messages
19d3b6e2 Merge pull request #49 from weaveworks/pin-shfmt
fea98f66 Go get from the vendor dir
1d867b06 Try and vendor a specific version of shfmt
76619c2d Merge pull request #48 from weaveworks/revert-41-user-tokens
4f96c519 Revert "Add experimental support for user tokens"
d00033fd Merge pull request #41 from weaveworks/user-tokens
245ed267 Merge pull request #47 from weaveworks/46-shfmt
c1d7815a Fix shfmt error
cb397466 Don't overright lint_result with 0 when shellcheck succeeds
8ab80e87 Merge pull request #45 from weaveworks/lint
83d5bd1f getting integration/config and test shellcheck-compliant
cff9ec36 Fix some shellcheck errors
7a843d6d run shellcheck as part of lint if it is installed
31552a0e removing spurious space from test
6ca7c5f0 Merge pull request #44 from weaveworks/shfmt
952356d8 Allow lint to lint itself
b7ac59c3 Run shfmt on all shell files in this repo
5570b0e9 Add shfmt formatting of shell files in lint
0a675941 fix circle build by splatting gopath permissions
354e0838 Fixing lint
586060b2 Add experimental support for user tokens

git-subtree-dir: tools
git-subtree-split: 4b7d5c617e662acb8b1bee4203d7671fb0aa1cba
2017-01-09 14:40:34 +01:00
Iago López Galeiras
3522a3f556 Merge commit 'd9ce1d58e9cbcd67823ee0abe8dd346a9aa6d120' into iaguis/fix-lint 2017-01-09 14:40:34 +01:00
jpellizzari
62448ee7cb Added debugging/troubleshooting menu; Moved troubleshooting icons 2017-01-05 13:46:51 -08:00
jpellizzari
edf94a4da8 Added control to reset local view state 2017-01-05 13:36:55 -08:00
Alfonso Acosta
89a0ab6799 Fix test data and improve /proc/net/tcp header parsing
The header checking code was unsafe because:

1. It was accessing the byteslice at [2] without ensuring a length >= 3
2. It was assuming that the indentation of the 'sl' header is always 2 (which seems to be the case in recent kernels 8f18e4d03e/net/ipv4/tcp_ipv4.c (L2304) and 8f18e4d03e/net/ipv6/tcp_ipv6.c (L1831) ) but it's more robust to simply trim the byteslice.
2017-01-04 00:27:16 +00:00
Alfonso Acosta
99a7dc3b9a Fix tests 2017-01-03 23:34:32 +00:00
Alfonso Acosta
a8b4e65b5c Make linter happy 2017-01-03 22:55:28 +00:00
Alfonso Acosta
7716d96810 Report persistent connections in states other than ESTABLISHED
This aligns the `/proc` connection tracking (persistent connections) with
conntrack (short-lived connections).
2017-01-03 18:38:02 +00:00
Alfonso Acosta
b4e1fc7074 Merge pull request #2112 from weaveworks/2032-ensure-conntrack-events
Check that conntrack events are enabled in the kernel
2017-01-02 23:11:52 +01:00
Alfonso Acosta
5c3ea83846 Fix minor typo 2017-01-02 14:28:22 +00:00
Alfonso Acosta
dfb52f0d93 Clarify even further that proc/PID/net/tcp varies by namespace 2017-01-02 14:27:37 +00:00
Alfonso Acosta
64f1a5d0f5 Check that conntrack events are enabled in the kernel 2017-01-02 09:22:26 +00:00
Alfonso Acosta
ab28a0bfac Fix linter errors in ignored file 2016-12-22 11:12:16 +00:00
Simon
bf2432ddb1 Merge pull request #2105 from weaveworks/2042-prio-ecs-view
Prioritize ecs topologies on initial load if available
2016-12-22 11:48:35 +01:00
Alfonso Acosta
0126f07a80 Merge pull request #2108 from kinvolk/schu/dialer-fixup
extras/dialer: move dialer.go to sub directory
2016-12-22 11:46:36 +01:00
Alfonso Acosta
a2d09b4c23 Run gofmt (file was ignored by linter) 2016-12-22 10:04:35 +00:00
Alfonso Acosta
2cd76130a1 Merge pull request #2095 from weaveworks/1991-conntrack-parsing
Disable XML in conntrack parsing
2016-12-22 11:00:51 +01:00
Alfonso Acosta
9d352e96f5 Review feedback 2016-12-22 09:33:52 +00:00
Michael Schubert
e8f9bc11e7 extras/dialer: move dialer.go to sub directory
`extras/dialer` contains both a dialer script and dialer.go, the go
sources for the dialer server and client, to allow users to build the
dialer container themselves. Move dialer.go to a sub directory `src`
since `make clean` (running `go clean ./...`) deletes the dialer script
otherwise.

Fixup for 4d20a91a97

Signed-off-by: Michael Schubert <michael@kinvolk.io>
2016-12-22 10:32:07 +01:00
Simon Howe
9f9148ac24 Prioritize ecs topologies on initial load if available
Global topo order priority:
 - Check url for topoid
 - Check localStorage for topoid
 - Check topo-utils.js for what to show first!
2016-12-22 10:08:06 +01:00
Alfonso Acosta
d22d64c710 Cleanup
* Remove XML traces
* Improve performance
* Fix tests
2016-12-21 19:35:37 +00:00
Alfonso Acosta
bae1533b12 Add comment regarding loopback address hardcoding 2016-12-21 10:10:00 +00:00
Alfonso Acosta
00c4a7cf86 Merge pull request #2103 from weaveworks/2102-hardcode-loopback-ip
Hardcode 127.0.0.1 as loopback IP for default target
2016-12-21 09:36:01 +01:00
jpellizzari
b7002610ea Fixed linting error 2016-12-20 08:12:06 -08:00