Commit Graph

3219 Commits

Author SHA1 Message Date
Alfonso Acosta
bdd09d8aa9 Restore copying nodes when obtaining connection summaries 2016-08-02 13:29:34 +00:00
Matthias Radestock
1091225bf6 get rid of Node.Copy()
A shallow copy is sufficient. Which we get for free in most cases
since Node is passed around by value.
2016-08-02 12:42:39 +00:00
Alfonso Acosta
e42444c2e5 Merge pull request #1732 from weaveworks/metric-to-slice
Use slices instead of linked lists for Metric
2016-08-02 13:08:26 +01:00
Alfonso Acosta
4ed6afdb3a Review feedback 2016-08-01 20:06:05 +00:00
Alfonso Acosta
eaa3baec9d Preallocate metrics when copying 2016-08-01 19:35:43 +00:00
Alfonso Acosta
af08ba3245 Optimize Merge() for Metric 2016-08-01 19:34:32 +00:00
Alfonso Acosta
31f938cdad Remove Metric WithFirst() method
It was only used in tests and wasn't really necessary
2016-08-01 16:58:21 +00:00
Alfonso Acosta
8a950a59d6 Remove Metric Add() method
* Helps reduce garbage (MakeMetric() now takes a slice and there's a shorter version MakeSingletonMetric())
* Fixes bug computing Max (Min) in samples since using MakeMetric()
  was causing a default Max/Min of zero.
* Simplifies code a bit
2016-08-01 16:58:11 +00:00
David
546e3ba972 Merge pull request #1734 from weaveworks/no-logo-on-cloud
Dont show weavescope logo when running in a frame
2016-08-01 16:55:17 +02:00
David Kaltschmidt
50fe1f8af2 Hide logo when in frame 2016-08-01 15:19:09 +02:00
David Kaltschmidt
1df544dbda Dont show weavescope logo when running in a frame
The logo wont show when running in a service
2016-08-01 15:09:20 +02:00
Alfonso Acosta
3e000662f4 Restore custom encoders/decoders for backwards compatibility 2016-08-01 11:07:03 +00:00
Alfonso Acosta
b8bf60c6f1 Use slices instead of linked lists for Metric
Also:

* Remove Gob encoder/decoder
* Stop using custom encoders/decoders for Timestamps (both ugorji and the Golang JSON codecs use nanosecond precision).
* Use idiomatic way to check for existence in metric.LastSample()
2016-08-01 10:21:57 +00:00
Matthias Radestock
15cf1e16b2 micro optimisation: avoid some unnecessary copying 2016-07-29 18:56:06 +01:00
Matthias Radestock
0525a2a95e Merge pull request #1728 from weaveworks/no-copy-merge
don't Copy() self on Merge()
2016-07-29 11:27:14 +01:00
Matthias Radestock
17fe25d8c3 shallow-copy instead of (deep) Copy() in Merge()
Merge() must not modify self or other; shallow-copying is sufficient
to achieve that.
2016-07-29 10:00:01 +01:00
Matthias Radestock
c4fa72110c don't Copy() self on Merge()
Merge() is always returning a copy, so there is no need to Copy()
struct fields first before calling Merge() on them.

This reduces GC pressure (#1010) and helps overall app performance
(#1457).
2016-07-28 22:21:06 +01:00
Simon Howe
6e3bec8c70 Pulls loading out into new cmp, adds delayed show for loading 2016-07-28 17:59:48 +02:00
Simon Howe
fba40de231 Typo and removing some more mutatey sounding verbs 2016-07-28 16:28:55 +02:00
Simon Howe
50a1c11eaa New and improved loading messages.
Are these getting better or worse...
2016-07-28 16:28:55 +02:00
Simon Howe
9a77b0d619 Less apologetic ui messages 2016-07-28 16:28:55 +02:00
Simon Howe
74e0540a00 More personal loading messages 2016-07-28 16:28:55 +02:00
Simon Howe
b92a990b2e Restore log error message 2016-07-28 16:28:55 +02:00
Simon Howe
335cc1154a Smooth fade-out of node-loading message 2016-07-28 16:28:54 +02:00
Simon Howe
04f4071fd3 Handle loading message for empty topos correctly.
It was showing infinite loading...
2016-07-28 16:28:54 +02:00
Simon Howe
5df5e402f3 Avoid blurry text in topo loading message 2016-07-28 16:28:13 +02:00
Simon Howe
7dfae47c85 No title case on the loading messages 2016-07-28 16:28:12 +02:00
Simon Howe
7d14a787be Adds a loading indicator for the initial node-load
- Sometimes can take a second to get the initial nodes
- Not doing the transition between topos atm as its a bit distracting
  popping up and down.
2016-07-28 16:28:12 +02:00
Simon Howe
9a0feb3eb0 Adds basic "loading topologies" indicator for initial load.
Which can take a while sometimes.
2016-07-28 16:28:11 +02:00
Matthias Radestock
1ffdafdf8c cosmetic: remove trailing whitespace 2016-07-27 08:27:18 +01:00
Paul Bellamy
683727eaa2 Merge pull request #1723 from weaveworks/name-routes
Name our routes, so /metrics gives more sensible aggregations
2016-07-26 13:45:24 +01:00
Alfonso Acosta
2132528823 Merge pull request #1720 from weaveworks/reduce-gc
Improve performance of immutable maps
2016-07-26 13:28:03 +01:00
Paul Bellamy
0a77d60261 Merge pull request #1722 from weaveworks/summary-execution
Delete unused instrumentation code
2016-07-26 12:55:21 +01:00
Paul Bellamy
274158493d Name our routes, so /metrics gives more sensible aggregations 2016-07-26 12:49:04 +01:00
Jonathan Lange
cd716d3510 Delete unused instrumentation code 2016-07-26 12:27:50 +01:00
Alfonso Acosta
b5c488faec Fix tests 2016-07-26 10:55:22 +00:00
Alfonso Acosta
a80429ded2 LatestMap codec performance improvements and cleanups
* Allocate all map entries of the intermadiate representation at once
* Use UnsafeMutableMap to improve performance of LatestMap construction
* Remove gob encoder/decoder
2016-07-26 10:35:56 +00:00
Alfonso Acosta
ecc8a3138f Replace github.com/mndrix/ps by github.com/weaveworks/ps 2016-07-26 10:35:55 +00:00
Tom Wilkie
7e850f87df Fix logs path 2016-07-21 17:10:01 +01:00
Tom Wilkie
78199aa25f Custom encoder for latest maps (#1709)
* Customer encoder for latest maps

- Cuts out intermediate type
- Should be backwards compatible with existing reports.

* Make it build cleanly

* Review feedback
2016-07-21 16:19:57 +01:00
Alban Crequy
d761f18e5b circle.yml: another fix for deploy master with non-upstream hub accounts
After https://github.com/weaveworks/scope/commit/e2441623 "wcloud
deploy" is run in the main deploy unit guarded by the environment
variable. But the test makes it fail when it is not run under
"weaveworks".
2016-07-21 15:25:34 +02:00
Tom Wilkie
e24416236f Circle will only run a single deploy step it seems 2016-07-21 13:47:15 +01:00
Matthias Radestock
d0e5a14a83 Merge pull request #1708 from weaveworks/1691-show-stopped-container-name
show names of stopped containers

Fixes #1691
2016-07-21 11:24:08 +01:00
Matthias Radestock
b3874e6e6f show names of stopped containers
This got broken in b78c503

Fixes #1691
2016-07-21 11:01:53 +01:00
Alban Crequy
652913084a circle.yml: deploy master with non-upstream hub accounts (#1655)
* circle.yml: deploy master with non-upstream hub accounts

Since b4abe582f4, images are tagged on
Docker Hub. But this was not working for non-upstream Docker Hub
accounts. This patch should fix that.

Symptoms: https://circleci.com/gh/kinvolk/scope/23

> The push refers to a repository [docker.io/kinvolk/scope] (len: 1)
> error getting tags for kinvolk/scope: Tag does not exist for
> master-b89e9ec

Also, ensure that the Docker tag name does not include any '/'.

Symptoms: https://circleci.com/gh/kinvolk/scope/24

> docker tag weaveworks/scope weaveworks/scope:alban/hub1-ef739d9
> repository name component must match "[a-z0-9]+(?:[._-][a-z0-9]+)*"

* extras/in_parallel.sh: ensure unique schedule name

Use CircleCI environment variables as documented on:
https://circleci.com/docs/environment-variables/

Symptoms:
> $ cd $SRCDIR/extras; ./build_on_circle.sh
> Doing graphviz/graphviz
> make: *** No rule to make target `graphviz/graphviz'.  Stop.

See: https://github.com/weaveworks/scope/pull/1655#issuecomment-232696357

* circle.yml: separate wcloud deployment

Do not run wcloud for non-weaveworks builds, as suggested by
https://github.com/weaveworks/scope/pull/1655#discussion_r71179373
2016-07-21 10:26:23 +01:00
Tom Wilkie
dda9785758 Update deploy api 2016-07-20 17:40:55 +01:00
Simon
ca43cb158c Merge pull request #1647 from weaveworks/1403-terminal-us-intl-kb-support
Support single/double quote key on us-intl keyboards in terminal
2016-07-20 13:34:30 +02:00
Simon Howe
b8ed8aebf8 Support all us-intl dead keys 2016-07-20 13:17:11 +02:00
Matthias Radestock
d19c0bfbfc Merge pull request #1693 from weaveworks/1688-reduce-horizontal-gaps
reduce horizontal gap between nodes in topology views

Fixes #1688
2016-07-20 10:21:17 +01:00
Tom Wilkie
f2f4e5bff7 Fix the wcloud client 2016-07-18 15:44:19 +01:00