From ef2f32dc9943df2433d89b8dc7f42d11b136ecd4 Mon Sep 17 00:00:00 2001 From: Filip Barl Date: Tue, 17 Oct 2017 17:54:50 +0200 Subject: [PATCH] Declared Sparkline PropTypes. --- client/.eslintrc | 1 - client/app/scripts/components/sparkline.js | 12 +++++++++--- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/client/.eslintrc b/client/.eslintrc index 32c031ec7..4d6729d8f 100644 --- a/client/.eslintrc +++ b/client/.eslintrc @@ -40,7 +40,6 @@ "jsx-a11y/click-events-have-key-events": 0, "jsx-a11y/mouse-events-have-key-events": 0, - "react/default-props-match-prop-types": 0, "react/jsx-closing-tag-location": 0, "react/jsx-max-props-per-line": 0, "react/jsx-wrap-multilines": 0, diff --git a/client/app/scripts/components/sparkline.js b/client/app/scripts/components/sparkline.js index a7c59bf84..d75a2d316 100644 --- a/client/app/scripts/components/sparkline.js +++ b/client/app/scripts/components/sparkline.js @@ -33,7 +33,7 @@ export default class Sparkline extends React.Component { this.x.range([MARGIN, this.props.width - circleSpace]); this.y.range([this.props.height - circleSpace, circleSpace]); - this.line.curve(this.props.curve); + this.line.curve(curveLinear); } getGraphData() { @@ -130,7 +130,14 @@ export default class Sparkline extends React.Component { } Sparkline.propTypes = { - data: PropTypes.arrayOf(PropTypes.object) + width: PropTypes.number, + height: PropTypes.number, + strokeColor: PropTypes.string, + strokeWidth: PropTypes.number, + hoverColor: PropTypes.string, + circleRadius: PropTypes.number, + hovered: PropTypes.bool, + data: PropTypes.arrayOf(PropTypes.object), }; Sparkline.defaultProps = { @@ -139,7 +146,6 @@ Sparkline.defaultProps = { strokeColor: '#7d7da8', strokeWidth: 0.5, hoverColor: '#7d7da8', - curve: curveLinear, circleRadius: 1.75, hovered: false, data: [],