github/weave-scope
1
0
Fork 0
mirror of https://github.com/weaveworks/scope.git synced 2026-07-28 17:51:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2964 from weaveworks/do-not-reportallocs

Browse Source 
do not report allocations in benchmarks
This commit is contained in:
Matthias Radestock
2017-12-08 14:11:18 +00:00
committed by GitHub
parent 3251705a09 d3e23e18fc
commit ea20de58be
6 changed files with 12 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/benchmark_internal_test.go
View File

@@ -40,11 +40,8 @@ func readReportFiles(path string) ([]report.Report, error) {
}
func BenchmarkReportUnmarshal(b *testing.B) {
b.ReportAllocs()
b.ResetTimer()
for i := 0; i < b.N; i++ {
b.StopTimer()
b.StartTimer()
if _, err := readReportFiles(*benchReportPath); err != nil {
b.Fatal(err)
}
@@ -58,11 +55,9 @@ func BenchmarkReportMerge(b *testing.B) {
}
merger := NewSmartMerger()
b.ReportAllocs()
b.ResetTimer()
for i := 0; i < b.N; i++ {
b.StopTimer()
b.StartTimer()
merger.Merge(reports)
}
}
@@ -100,7 +95,6 @@ func benchmarkRender(b *testing.B, f func(report.Report)) {
r = NewSmartMerger().Merge(reports)
}
b.ReportAllocs()
b.ResetTimer()
for i := 0; i < b.N; i++ {

1
app/merger_test.go
View File

@@ -69,7 +69,6 @@ func benchmarkMerger(b *testing.B, merger app.Merger) {
reports = append(reports, makeReport())
}
b.ReportAllocs()
b.ResetTimer()
for i := 0; i < b.N; i++ {