From d7e90303a63155dcc595f7a6e8fbfd404400e4e8 Mon Sep 17 00:00:00 2001 From: Matthias Radestock Date: Thu, 28 Dec 2017 02:24:54 +0000 Subject: [PATCH] don't propagate PID in endpoints2Processes The 'create' function passed to addChild is only ever invoked when we cannot find a matching process in the process topology. In these cases the host and pid will be _all_ the info we are ever going to have, both of which are incorporated in the id. Node summarisation renders that as best it can; adding the PID as metadata does not make a difference but for a line with that info in the detail panel, which adds nothing since the PID is already included in the label. --- render/process.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/render/process.go b/render/process.go index 092ba00d2..ed52641cc 100644 --- a/render/process.go +++ b/render/process.go @@ -92,7 +92,7 @@ func (e endpoints2Processes) Render(rpt report.Report) Nodes { ret.addChild(n, id, newPseudoNode) } } else { - pid, timestamp, ok := n.Latest.LookupEntry(process.PID) + pid, ok := n.Latest.Lookup(process.PID) if !ok { continue } @@ -105,8 +105,7 @@ func (e endpoints2Processes) Render(rpt report.Report) Nodes { ret.addChild(n, id, func(id string) report.Node { // we have a pid, but no matching process node; // create a new one rather than dropping the data - return report.MakeNode(id).WithTopology(report.Process). - WithLatest(process.PID, timestamp, pid) + return report.MakeNode(id).WithTopology(report.Process) }) } }