github/weave-scope
1
0
Fork 0
mirror of https://github.com/weaveworks/scope.git synced 2026-07-28 17:51:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

optimization: store just IDs of child nodes

Browse Source 
IDs are a lot smaller, hence quicker to manage.
Any time we want to refer back to the full node we look it up in its topology.

(This relies on nobody trying to store a rendered node as a child).
This commit is contained in:
Bryan Boreham
2020-06-08 16:39:50 +00:00
parent b4a73b7f87
commit d76da767d8
13 changed files with 233 additions and 280 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
report/node.go
View File

@@ -19,7 +19,7 @@ type Node struct {
Latest StringLatestMap `json:"latest,omitempty"`
Metrics Metrics `json:"metrics,omitempty" deepequal:"nil==empty"`
Parents Sets `json:"parents,omitempty"`
Children NodeSet `json:"children,omitempty"`
ChildIDs IDList `json:"cs,omitempty"`
}
// MakeNode creates a new Node with no initial metadata.
@@ -162,14 +162,16 @@ func (n Node) PruneParents() Node {
}
// WithChildren returns a fresh copy of n, with children merged in.
func (n Node) WithChildren(children NodeSet) Node {
n.Children = n.Children.Merge(children)
func (n Node) WithChildren(children IDList) Node {
for _, childID := range children {
n.ChildIDs = n.ChildIDs.Add(childID)
}
return n
}
// WithChild returns a fresh copy of n, with one child merged in.
func (n Node) WithChild(child Node) Node {
n.Children = n.Children.Merge(MakeNodeSet(child))
// WithChildID returns a fresh copy of n, with one child merged in.
func (n Node) WithChildID(childID string) Node {
n.ChildIDs = n.ChildIDs.Add(childID)
return n
}
@@ -194,7 +196,7 @@ func (n Node) Merge(other Node) Node {
Latest: n.Latest.Merge(other.Latest),
Metrics: n.Metrics.Merge(other.Metrics),
Parents: n.Parents.Merge(other.Parents),
Children: n.Children.Merge(other.Children),
ChildIDs: n.ChildIDs.Merge(other.ChildIDs),
}
}