Grid-mode tuning!

- Change scrolling behaviour to lock headers in place
- Enable filtering (hitting enter in the search bar) in grid-mode
- Little more top-margin for k8s (can have 3 topos) + taller rows.
- Trying out rank-color + node.relatives in the grid-mode
- First pass at selecting rows.
  - Needs a bit more a fiddle, colors + click areas
- Store grid sort direction (asc/desc) in url state
- Simplify node selection to one method. (over-ride existing card)
  - Remove clicking on name directly (links) to overlay new cards for now.
- Playing w/ grid-mode-toggle icons and labels
- Improves rendering in ff, change of shortcut keys for grid-mode-toggle
- Playing w/ clearer selection colors for grid-mode
- Slight change to selection-ui
- Fixes showNodeInTopology button visibility on the details-panel
  - Was using an old heuristic. Table-mode allows you to open child cards
    before the parent.
- Make it clear what the default sort is in tables
  - E.g. always show a sorting caret
- Sort grid-mode columns, first meta then metrics
- dancing-nodes rememdy #1: pause updates onRowHover
- Splits relatives out into their own columns
- Take into account scrollbar width for grid-mode col header position
- Tooltips on table column headers
- grid-mode: fixes first column headers (proc/container/c-by-image)
- Disable pause-on-hover, too aggresive
- reduce label column width a bit (33pc -> 25pc) for big tables
- Filter grid-mode onSearchChange
  - Rather than previous behaviour of waiting for an <enter>
- Show label_minor on pseudo nodes, that might not have much other info
- grid-mode: further reduce width of id column.
- Fixes go tests, properly moves parents into node-summary
- Fixes sorting of string columns w/ missing fields.
  - E.g. uptime. Where -1e-10 > '3days' doesn't work.

render/detailed/node.go

@@ -18,7 +18,6 @@ type Node struct {
 	NodeSummary
 	Controls    []ControlInstance    `json:"controls"`
 	Children    []NodeSummaryGroup   `json:"children,omitempty"`
-	Parents     []Parent             `json:"parents,omitempty"`
 	Connections []ConnectionsSummary `json:"connections,omitempty"`
 }
 
@@ -86,7 +85,6 @@ func MakeNode(topologyID string, r report.Report, ns report.Nodes, n report.Node
 		NodeSummary: summary,
 		Controls:    controls(r, n),
 		Children:    children(r, n),
-		Parents:     Parents(r, n),
 		Connections: []ConnectionsSummary{
 			incomingConnectionsSummary(topologyID, r, n, ns),
 			outgoingConnectionsSummary(topologyID, r, n, ns),

render/detailed/node_test.go

@@ -218,6 +218,23 @@ func TestMakeDetailedContainerNode(t *testing.T) {
 					Metric:   &fixture.ServerContainerMemoryMetric,
 				},
 			},
+			Parents: []detailed.Parent{
+				{
+					ID:         expected.ServerContainerImageNodeID,
+					Label:      fixture.ServerContainerImageName,
+					TopologyID: "containers-by-image",
+				},
+				{
+					ID:         fixture.ServerHostNodeID,
+					Label:      fixture.ServerHostName,
+					TopologyID: "hosts",
+				},
+				{
+					ID:         fixture.ServerPodNodeID,
+					Label:      "pong-b",
+					TopologyID: "pods",
+				},
+			},
 		},
 		Controls: []detailed.ControlInstance{},
 		Children: []detailed.NodeSummaryGroup{
@@ -232,23 +249,6 @@ func TestMakeDetailedContainerNode(t *testing.T) {
 				Nodes: []detailed.NodeSummary{serverProcessNodeSummary},
 			},
 		},
-		Parents: []detailed.Parent{
-			{
-				ID:         expected.ServerContainerImageNodeID,
-				Label:      fixture.ServerContainerImageName,
-				TopologyID: "containers-by-image",
-			},
-			{
-				ID:         fixture.ServerHostNodeID,
-				Label:      fixture.ServerHostName,
-				TopologyID: "hosts",
-			},
-			{
-				ID:         fixture.ServerPodNodeID,
-				Label:      "pong-b",
-				TopologyID: "pods",
-			},
-		},
 		Connections: []detailed.ConnectionsSummary{
 			{
 				ID:         "incoming-connections",
@@ -335,6 +335,18 @@ func TestMakeDetailedPodNode(t *testing.T) {
 				{ID: "container", Label: "# Containers", Value: "1", Priority: 4, Datatype: "number"},
 				{ID: "kubernetes_namespace", Label: "Namespace", Value: "ping", Priority: 5},
 			},
+			Parents: []detailed.Parent{
+				{
+					ID:         fixture.ServerHostNodeID,
+					Label:      fixture.ServerHostName,
+					TopologyID: "hosts",
+				},
+				{
+					ID:         fixture.ServiceNodeID,
+					Label:      fixture.ServiceName,
+					TopologyID: "services",
+				},
+			},
 		},
 		Controls: []detailed.ControlInstance{},
 		Children: []detailed.NodeSummaryGroup{
@@ -358,18 +370,6 @@ func TestMakeDetailedPodNode(t *testing.T) {
 				Nodes: []detailed.NodeSummary{serverProcessNodeSummary},
 			},
 		},
-		Parents: []detailed.Parent{
-			{
-				ID:         fixture.ServerHostNodeID,
-				Label:      fixture.ServerHostName,
-				TopologyID: "hosts",
-			},
-			{
-				ID:         fixture.ServiceNodeID,
-				Label:      fixture.ServiceName,
-				TopologyID: "services",
-			},
-		},
 		Connections: []detailed.ConnectionsSummary{
 			{
 				ID:         "incoming-connections",

render/detailed/summary.go

@@ -64,6 +64,7 @@ type NodeSummary struct {
 	Linkable   bool                 `json:"linkable,omitempty"` // Whether this node can be linked-to
 	Pseudo     bool                 `json:"pseudo,omitempty"`
 	Metadata   []report.MetadataRow `json:"metadata,omitempty"`
+	Parents    []Parent             `json:"parents,omitempty"`
 	Metrics    []report.MetricRow   `json:"metrics,omitempty"`
 	Tables     []report.Table       `json:"tables,omitempty"`
 	Adjacency  report.IDList        `json:"adjacency,omitempty"`
@@ -133,6 +134,7 @@ func baseNodeSummary(r report.Report, n report.Node) NodeSummary {
 		Linkable:  true,
 		Metadata:  NodeMetadata(r, n),
 		Metrics:   NodeMetrics(r, n),
+		Parents:   Parents(r, n),
 		Tables:    NodeTables(r, n),
 		Adjacency: n.Adjacency.Copy(),
 	}