From bf14b3dafd5d23b774f8b161146fbd73e75f5119 Mon Sep 17 00:00:00 2001
From: Matthias Radestock <matthias.radestock@gmail.com>
Date: Sun, 24 Dec 2017 08:50:08 +0000
Subject: [PATCH] upgrade reports we merge / render

This better reflects what the app is doing.
---
 app/benchmark_internal_test.go | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/app/benchmark_internal_test.go b/app/benchmark_internal_test.go
index abfb3a915..337610c49 100644
--- a/app/benchmark_internal_test.go
+++ b/app/benchmark_internal_test.go
@@ -46,18 +46,24 @@ func BenchmarkReportUnmarshal(b *testing.B) {
 	}
 }
 
+func upgradeReports(reports []report.Report) []report.Report {
+	upgraded := make([]report.Report, len(reports))
+	for i, r := range reports {
+		upgraded[i] = r.Upgrade()
+	}
+	return upgraded
+}
+
 func BenchmarkReportUpgrade(b *testing.B) {
 	reports := readReportFiles(b, *benchReportPath)
 	b.ResetTimer()
 	for i := 0; i < b.N; i++ {
-		for _, r := range reports {
-			r.Upgrade()
-		}
+		upgradeReports(reports)
 	}
 }
 
 func BenchmarkReportMerge(b *testing.B) {
-	reports := readReportFiles(b, *benchReportPath)
+	reports := upgradeReports(readReportFiles(b, *benchReportPath))
 	merger := NewSmartMerger()
 	b.ResetTimer()
 	for i := 0; i < b.N; i++ {
@@ -68,7 +74,7 @@ func BenchmarkReportMerge(b *testing.B) {
 func benchmarkRender(b *testing.B, f func(report.Report)) {
 	r := fixture.Report
 	if *benchReportPath != "" {
-		r = NewSmartMerger().Merge(readReportFiles(b, *benchReportPath))
+		r = NewSmartMerger().Merge(upgradeReports(readReportFiles(b, *benchReportPath)))
 	}
 
 	b.ResetTimer()