From 554bc7ecd2de0cb340d83ed1b24841b8f519aef6 Mon Sep 17 00:00:00 2001 From: Alfonso Acosta Date: Mon, 15 Aug 2016 14:12:29 +0000 Subject: [PATCH 1/4] Release 0.17.0 --- CHANGELOG.md | 92 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 92 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3dcaed307..c61c34088 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,95 @@ +## Release 0.17.0 + +Highlights: +- New Grid view as an alternative to Scopes classic graph view. It provides + higher information density, proving particularly useful when there's a high + node count in the graph view. +- Considerable Performance enhancements: the CPU efficiency of the Scope App has + increased in more than 50% and the Scope probes over 25%. + + +New features and enhancements: +- Grid view. + [#1673](https://github.com/weaveworks/scope/pull/1673) + [#1747](https://github.com/weaveworks/scope/pull/1747) + [#1753](https://github.com/weaveworks/scope/pull/1753) + [#1774](https://github.com/weaveworks/scope/pull/1774) + [#1775](https://github.com/weaveworks/scope/pull/1775) + [#1784](https://github.com/weaveworks/scope/pull/1784) +- Loading indicator + [#1485](https://github.com/weaveworks/scope/pull/1485) +- Dont show weavescope logo when running in a frame + [#1734](https://github.com/weaveworks/scope/pull/1734) +- Reduce horizontal gap between nodes in topology views + [#1693](https://github.com/weaveworks/scope/pull/1693) +- Elide service-token when logging commandline arguments + [#1782](https://github.com/weaveworks/scope/pull/1782) +- Don't complain when stopping Scope if it wasn't running + [#1783](https://github.com/weaveworks/scope/pull/1783) +- Silence abnormal websocket close + [#1768](https://github.com/weaveworks/scope/pull/1768) +- Eliminate stats log noise from stopped containers + [#1687](https://github.com/weaveworks/scope/pull/1687) +- Hide uncontained/unmanaged by default + [#1694](https://github.com/weaveworks/scope/pull/1694) + +Performance improvements: +- Remove and optimize more Copy()s + [#1739](https://github.com/weaveworks/scope/pull/1739) +- Use slices instead of linked lists for Metric + [#1732](https://github.com/weaveworks/scope/pull/1732) +- Don't Copy() self on Merge() + [#1728](https://github.com/weaveworks/scope/pull/1728) +- Improve performance of immutable maps + [#1720](https://github.com/weaveworks/scope/pull/1720) +- Custom encoder for latest maps + [#1709](https://github.com/weaveworks/scope/pull/1709) + +Bug fixes: +- Connections inside a container shown as going between containers + [#1733](https://github.com/weaveworks/scope/issues/1733) +- Probes leak two goroutines when closing attach/exec window + [#1767](https://github.com/weaveworks/scope/issues/1767) +- Scale node labels with the node's size. + [#1773](https://github.com/weaveworks/scope/pull/1773) +- Kubernetes infra containers seem to resurface in latest on 1.3 + [#1750](https://github.com/weaveworks/scope/issues/1750) +- Search icon is above text + [#1715](https://github.com/weaveworks/scope/issues/1715) +- Highlighting is unpredictable + [#1756](https://github.com/weaveworks/scope/pull/1520) +- Details panel truncates port to four digits + [#1711](https://github.com/weaveworks/scope/issues/1711) +- Stopped containers not shown with their names + [#1691](https://github.com/weaveworks/scope/issues/1691) +- Terminals don't support quote characters from intl keyboard layouts + [#1403](https://github.com/weaveworks/scope/issues/1403) + +Internal improvements and cleanup: +- Launcher script: Fix inconsistent whitespace + [#1776](https://github.com/weaveworks/scope/pull/1776) +- Lint fixes + [#1751](https://github.com/weaveworks/scope/pull/1751) +- Add browser console logging for websocket to render times + [#1742](https://github.com/weaveworks/scope/pull/1742) +- circle.yml: deploy master with non-upstream hub accounts + [#1655](https://github.com/weaveworks/scope/pull/1655) + [#1710](https://github.com/weaveworks/scope/pull/1710) +- Delete unused instrumentation code + [#1722](https://github.com/weaveworks/scope/pull/1722) +- Update version of build tools + [#1685](https://github.com/weaveworks/scope/pull/1685) +- Add flag for block profiling + [#1681](https://github.com/weaveworks/scope/pull/1681) + +Weave Cloud related changes: +- Also serve UI under /ui + [#1752](https://github.com/weaveworks/scope/pull/1752) +- Name our routes, so /metrics gives more sensible aggregations + [#1723](https://github.com/weaveworks/scope/pull/1723) +- Add options for storing memcached reports with different compression levels + [#1684](https://github.com/weaveworks/scope/pull/1684) + ## Release 0.16.2 Bug fixes: From 8c0c7d3fe9f72ca63fd9fece4bcfc024c0dee632 Mon Sep 17 00:00:00 2001 From: Alfonso Acosta Date: Mon, 15 Aug 2016 14:42:59 +0000 Subject: [PATCH 2/4] Fix spelling mistake --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c61c34088..ea7aa1638 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,7 +18,7 @@ New features and enhancements: [#1784](https://github.com/weaveworks/scope/pull/1784) - Loading indicator [#1485](https://github.com/weaveworks/scope/pull/1485) -- Dont show weavescope logo when running in a frame +- Don't show weavescope logo when running in a frame [#1734](https://github.com/weaveworks/scope/pull/1734) - Reduce horizontal gap between nodes in topology views [#1693](https://github.com/weaveworks/scope/pull/1693) From a4d5eb3d54a22202734e368998e1f87708ae3167 Mon Sep 17 00:00:00 2001 From: Alfonso Acosta Date: Mon, 15 Aug 2016 15:20:35 +0000 Subject: [PATCH 3/4] Review feedback --- CHANGELOG.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ea7aa1638..4af00c800 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,15 +1,15 @@ ## Release 0.17.0 Highlights: -- New Grid view as an alternative to Scopes classic graph view. It provides - higher information density, proving particularly useful when there's a high - node count in the graph view. -- Considerable Performance enhancements: the CPU efficiency of the Scope App has +- New Table Mode as an alternative to Scope's classic graph view. It provides + higher information density, proving particularly useful when there are many + nodes in the graph view. +- Considerable performance enhancements: the CPU efficiency of the Scope App has increased in more than 50% and the Scope probes over 25%. New features and enhancements: -- Grid view. +- Table mode [#1673](https://github.com/weaveworks/scope/pull/1673) [#1747](https://github.com/weaveworks/scope/pull/1747) [#1753](https://github.com/weaveworks/scope/pull/1753) From 8b97f12ab1ab61d2fd9511dcf4220a8606eef9d9 Mon Sep 17 00:00:00 2001 From: Alfonso Acosta Date: Tue, 16 Aug 2016 12:48:26 +0000 Subject: [PATCH 4/4] Make stats gathering idempotent --- CHANGELOG.md | 1 + probe/docker/container.go | 2 +- probe/docker/registry.go | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4af00c800..94180b884 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -30,6 +30,7 @@ New features and enhancements: [#1768](https://github.com/weaveworks/scope/pull/1768) - Eliminate stats log noise from stopped containers [#1687](https://github.com/weaveworks/scope/pull/1687) + [#1798](https://github.com/weaveworks/scope/pull/1798) - Hide uncontained/unmanaged by default [#1694](https://github.com/weaveworks/scope/pull/1694) diff --git a/probe/docker/container.go b/probe/docker/container.go index c88288d7d..7f956a836 100644 --- a/probe/docker/container.go +++ b/probe/docker/container.go @@ -181,7 +181,7 @@ func (c *container) StartGatheringStats() error { defer c.Unlock() if c.statsConn != nil { - return fmt.Errorf("already gather stats for container %s", c.container.ID) + return nil } go func() { diff --git a/probe/docker/registry.go b/probe/docker/registry.go index a3afc9500..1a8c4c71c 100644 --- a/probe/docker/registry.go +++ b/probe/docker/registry.go @@ -360,7 +360,7 @@ func (r *registry) updateContainerState(containerID string, intendedState *strin if r.collectStats { if dockerContainer.State.Running { if err := c.StartGatheringStats(); err != nil { - log.Errorf("Error gather stats for container: %s", containerID) + log.Errorf("Error gathering stats for container %s: %s", containerID, err) return } } else {