drop addr and port from Endpoint.Latest map

the information is constant and already present in the id, so we can
extract it from there.

That reduces the report size and improves report encoding/decoding
performance. It should reduce memory usage too and improve report
merging performance too.

NB: Probes with this change are incompatible with old apps.

probe/endpoint/connection_tracker.go

@@ -223,9 +223,7 @@ func (t *connectionTracker) addConnection(rpt *report.Report, ft fourTuple, name
 
 func (t *connectionTracker) makeEndpointNode(namespaceID string, addr string, port uint16, extra map[string]string) report.Node {
 	portStr := strconv.Itoa(int(port))
-	node := report.MakeNodeWith(
-		report.MakeEndpointNodeID(t.conf.HostID, namespaceID, addr, portStr),
-		map[string]string{Addr: addr, Port: portStr})
+	node := report.MakeNodeWith(report.MakeEndpointNodeID(t.conf.HostID, namespaceID, addr, portStr), nil)
 	if names := t.conf.DNSSnooper.CachedNamesForIP(addr); len(names) > 0 {
 		node = node.WithSet(SnoopedDNSNames, report.MakeStringSet(names...))
 	}

probe/endpoint/nat.go

@@ -63,8 +63,6 @@ func (n natMapper) applyNAT(rpt report.Report, scope string) {
 		}
 
 		rpt.Endpoint.AddNode(node.WithID(copyEndpointID).WithLatests(map[string]string{
-			Addr:      mapping.rewrittenIP,
-			Port:      copyEndpointPort,
 			"copy_of": realEndpointID,
 		}))
 	})

probe/endpoint/nat_internal_test.go

@@ -70,8 +70,6 @@ func TestNat(t *testing.T) {
 		have := report.MakeReport()
 		originalID := report.MakeEndpointNodeID("host1", "", "10.0.47.1", "80")
 		have.Endpoint.AddNode(report.MakeNodeWith(originalID, map[string]string{
-			Addr:      "10.0.47.1",
-			Port:      "80",
 			"foo":     "bar",
 			Procspied: "true",
 		}))
@@ -79,8 +77,6 @@ func TestNat(t *testing.T) {
 		want := have.Copy()
 		wantID := report.MakeEndpointNodeID("host1", "", "1.2.3.4", "80")
 		want.Endpoint.AddNode(report.MakeNodeWith(wantID, map[string]string{
-			Addr:      "1.2.3.4",
-			Port:      "80",
 			"copy_of": originalID,
 			"foo":     "bar",
 			Procspied: "true",
@@ -129,16 +125,12 @@ func TestNat(t *testing.T) {
 		have := report.MakeReport()
 		originalID := report.MakeEndpointNodeID("host2", "", "10.0.47.2", "22222")
 		have.Endpoint.AddNode(report.MakeNodeWith(originalID, map[string]string{
-			Addr:      "10.0.47.2",
-			Port:      "22222",
 			"foo":     "baz",
 			Procspied: "true",
 		}))
 
 		want := have.Copy()
 		want.Endpoint.AddNode(report.MakeNodeWith(report.MakeEndpointNodeID("host2", "", "2.3.4.5", "22223"), map[string]string{
-			Addr:      "2.3.4.5",
-			Port:      "22223",
 			"copy_of": originalID,
 			"foo":     "baz",
 			Procspied: "true",

probe/endpoint/reporter.go

@@ -11,8 +11,6 @@ import (
 
 // Node metadata keys.
 const (
-	Addr            = "addr" // typically IPv4
-	Port            = "port"
 	Conntracked     = "conntracked"
 	EBPF            = "eBPF"
 	Procspied       = "procspied"