From a06d82ccf836c1b2fa1b98cb3086894d99f6065a Mon Sep 17 00:00:00 2001 From: Bryan Boreham Date: Mon, 9 Jul 2018 21:04:21 +0000 Subject: [PATCH] Shuffle reports before merging, in benchmark So that we have equal chance of merging older into newer or vice-versa --- app/benchmark_internal_test.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/benchmark_internal_test.go b/app/benchmark_internal_test.go index 1c9e06436..9164ffe06 100644 --- a/app/benchmark_internal_test.go +++ b/app/benchmark_internal_test.go @@ -2,6 +2,7 @@ package app import ( "flag" + "math/rand" "net/http" "net/url" "os" @@ -65,6 +66,9 @@ func BenchmarkReportUpgrade(b *testing.B) { func BenchmarkReportMerge(b *testing.B) { reports := upgradeReports(readReportFiles(b, *benchReportPath)) + rand.Shuffle(len(reports), func(i, j int) { + reports[i], reports[j] = reports[j], reports[i] + }) merger := NewFastMerger() b.ResetTimer() for i := 0; i < b.N; i++ {