github/weave-scope
1
0
Fork 0
mirror of https://github.com/weaveworks/scope.git synced 2026-07-28 17:51:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve comments; fix missing links w/o metrics

Browse Source
This commit is contained in:
Roland Schilter
2017-07-04 12:02:44 +02:00
parent c812df88c3
commit 9dcdc65e66
3 changed files with 13 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
client/app/scripts/components/node-details.js
View File

@@ -198,7 +198,7 @@ class NodeDetails extends React.Component {
</div>}
<div className="node-details-content">
{Object.keys(metricLinks).length > 0 && <div className="node-details-content-section">
{((details.metrics || []).length + Object.keys(unattachedLinks).length > 0) && <div className="node-details-content-section">
<div className="node-details-content-section-header">Status</div>
<NodeDetailsHealth
metrics={details.metrics}

5
client/app/scripts/components/node-details/node-details-health.js
View File

@@ -29,7 +29,6 @@ export default class NodeDetailsHealth extends React.Component {
topologyId,
} = this.props;
const hasUnattached = Object.keys(unattachedLinks).length > 0;
const primeCutoff = metrics.length > 3 && !this.state.expanded ? 2 : metrics.length;
const primeMetrics = metrics.slice(0, primeCutoff);
const overflowMetrics = metrics.slice(primeCutoff);
@@ -57,7 +56,7 @@ export default class NodeDetailsHealth extends React.Component {
handleClick={this.handleClickMore} collection={this.props.metrics}
expanded={this.state.expanded} notShown={notShown} hideNumber />
{hasUnattached && <div className="node-details-health-wrapper">
<div className="node-details-health-wrapper">
{Object.keys(unattachedLinks).map(id => <CloudFeature alwaysShow key={id}>
<NodeDetailsHealthLinkItem
withoutGraph
@@ -66,7 +65,7 @@ export default class NodeDetailsHealth extends React.Component {
topologyId={topologyId}
/>
</CloudFeature>)}
</div>}
</div>
</div>
);
}