From 6173e543c8ec7f9a029e51af8e172b46916f49fd Mon Sep 17 00:00:00 2001 From: Mike Lang Date: Thu, 27 Oct 2016 17:05:21 -0700 Subject: [PATCH] middleware/errorhandler: Fix a bug which meant it never works Because methods operated on the value, not the reference, their changes were discarded. --- common/middleware/errorhandler.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/common/middleware/errorhandler.go b/common/middleware/errorhandler.go index 6fd6cfddd..fdb539d37 100644 --- a/common/middleware/errorhandler.go +++ b/common/middleware/errorhandler.go @@ -49,12 +49,12 @@ func newErrorInterceptor(w http.ResponseWriter, code int) *errorInterceptor { } // Header implements http.ResponseWriter -func (i errorInterceptor) Header() http.Header { +func (i *errorInterceptor) Header() http.Header { return i.headers } // WriteHeader implements http.ResponseWriter -func (i errorInterceptor) WriteHeader(code int) { +func (i *errorInterceptor) WriteHeader(code int) { if i.gotCode { panic("errorInterceptor.WriteHeader() called twice") } @@ -69,7 +69,7 @@ func (i errorInterceptor) WriteHeader(code int) { } // Write implements http.ResponseWriter -func (i errorInterceptor) Write(data []byte) (int, error) { +func (i *errorInterceptor) Write(data []byte) (int, error) { if !i.gotCode { i.WriteHeader(http.StatusOK) }