From 8e5b19cbcb59b917824abc3bfb95c29f4019359a Mon Sep 17 00:00:00 2001 From: Bryan Boreham Date: Wed, 4 Jul 2018 14:03:17 +0000 Subject: [PATCH] Use buffer pool in report.MakeFromBytes() to reduce garbage-collection --- report/marshal.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/report/marshal.go b/report/marshal.go index 74969750b..1dc7fe52d 100644 --- a/report/marshal.go +++ b/report/marshal.go @@ -6,7 +6,6 @@ import ( "compress/gzip" "fmt" "io" - "io/ioutil" "os" "path/filepath" "strings" @@ -128,11 +127,13 @@ func MakeFromBytes(buf []byte) (*Report, error) { if err != nil { return nil, err } - buf, err = ioutil.ReadAll(r) + buffer := bufferPool.Get().(*bytes.Buffer) + buffer.Reset() + defer bufferPool.Put(buffer) + uncompressedSize, err := buffer.ReadFrom(r) if err != nil { return nil, err } - uncompressedSize := len(buf) log.Debugf( "Received report sizes: compressed %d bytes, uncompressed %d bytes (%.2f%%)", compressedSize, @@ -140,7 +141,7 @@ func MakeFromBytes(buf []byte) (*Report, error) { float32(compressedSize)/float32(uncompressedSize)*100, ) rep := MakeReport() - if err := rep.ReadBytes(buf, &codec.MsgpackHandle{}); err != nil { + if err := rep.ReadBytes(buffer.Bytes(), &codec.MsgpackHandle{}); err != nil { return nil, err } return &rep, nil