From 8cf65ea8b6fb34c7720572cac5ffa12cd9cf8f17 Mon Sep 17 00:00:00 2001 From: Matthias Radestock Date: Sun, 24 Dec 2017 12:07:09 +0000 Subject: [PATCH] use BasicNodeSummary for rendering links in connection table instead of the full NodeSummary --- render/detailed/connections.go | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/render/detailed/connections.go b/render/detailed/connections.go index 1dd5eb859..cf252e134 100644 --- a/render/detailed/connections.go +++ b/render/detailed/connections.go @@ -125,10 +125,8 @@ func internetAddr(node report.Node, ep report.Node) (string, bool) { func (c *connectionCounters) rows(r report.Report, ns report.Nodes, includeLocal bool) []Connection { output := []Connection{} for row, count := range c.counts { - // Use MakeNodeSummary to render the id and label of this node - // TODO(paulbellamy): Would be cleaner if we hade just a - // MakeNodeID(ns[row.remoteNodeID]). As we don't need the whole summary. - summary, _ := MakeNodeSummary(report.RenderContext{Report: r}, ns[row.remoteNodeID]) + // Use MakeBasicNodeSummary to render the id and label of this node + summary, _ := MakeBasicNodeSummary(r, ns[row.remoteNodeID]) connection := Connection{ ID: fmt.Sprintf("%s-%s-%s-%s", row.remoteNodeID, row.remoteAddr, row.localAddr, row.port), NodeID: summary.ID,