From 175c488d74f98894cffc99e4aea872aa0188c175 Mon Sep 17 00:00:00 2001 From: Tom Wilkie Date: Wed, 24 Jun 2015 10:03:26 +0000 Subject: [PATCH] Increase timeouts to prevent flakiness. --- xfer/collector_test.go | 22 ++++++++++++++++++---- xfer/merge_test.go | 2 +- 2 files changed, 19 insertions(+), 5 deletions(-) diff --git a/xfer/collector_test.go b/xfer/collector_test.go index 5d0d4889c..015dfa2f8 100644 --- a/xfer/collector_test.go +++ b/xfer/collector_test.go @@ -5,11 +5,13 @@ import ( "io/ioutil" "log" "net" + "reflect" "runtime" "testing" "time" "github.com/weaveworks/scope/report" + "github.com/weaveworks/scope/test" ) func TestCollector(t *testing.T) { @@ -42,11 +44,23 @@ func TestCollector(t *testing.T) { runtime.Gosched() // make sure it connects // Push a report through everything - reports <- report.Report{Address: report.Topology{NodeMetadatas: report.NodeMetadatas{report.MakeAddressNodeID("a", "b"): report.NodeMetadata{}}}} - poll(t, 10*time.Millisecond, func() bool { return len(concreteCollector.peek().Address.NodeMetadatas) == 1 }, "missed the report") + r := report.Report{ + Address: report.Topology{ + NodeMetadatas: report.NodeMetadatas{ + report.MakeAddressNodeID("a", "b"): report.NodeMetadata{}, + }, + }, + } + + reports <- r + poll(t, 100*time.Millisecond, func() bool { + return len(concreteCollector.peek().Address.NodeMetadatas) == 1 + }, "missed the report") + go func() { publish <- time.Now() }() - if want, have := 1, len((<-collector.Reports()).Address.NodeMetadatas); want != have { - t.Errorf("want %d, have %d", want, have) + collected := <-collector.Reports() + if reflect.DeepEqual(r, collected) { + t.Errorf(test.Diff(r, collected)) } collector.Remove(addr) diff --git a/xfer/merge_test.go b/xfer/merge_test.go index 53ca89ec7..33969be1a 100644 --- a/xfer/merge_test.go +++ b/xfer/merge_test.go @@ -66,7 +66,7 @@ func TestMerge(t *testing.T) { select { case <-success: - case <-time.After(batchTime): + case <-time.After(2 * batchTime): t.Errorf("collector didn't capture both reports") } }