From 705c6d159dfaddda87f7a0b1fc4b7064cff4e2b4 Mon Sep 17 00:00:00 2001 From: Matthias Radestock Date: Wed, 27 Dec 2017 13:48:46 +0000 Subject: [PATCH] sensible defaults/fallback for label and shape --- render/detailed/summary.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/render/detailed/summary.go b/render/detailed/summary.go index 25bd05a77..36ffbe776 100644 --- a/render/detailed/summary.go +++ b/render/detailed/summary.go @@ -108,8 +108,10 @@ var primaryAPITopology = map[string]string{ // MakeBasicNodeSummary returns a basic summary of a node, if // possible. This summary is sufficient for rendering links to the node. func MakeBasicNodeSummary(r report.Report, n report.Node) (BasicNodeSummary, bool) { - summary := BasicNodeSummary{ + summary := BasicNodeSummary{ // This is unlikely to look very good, but is a reasonable fallback ID: n.ID, + Label: n.ID, + Shape: report.Triangle, Linkable: true, } if t, ok := r.Topology(n.Topology); ok { @@ -121,7 +123,6 @@ func MakeBasicNodeSummary(r report.Report, n report.Node) (BasicNodeSummary, boo return renderer(summary, n), true } } else if _, ok := r.Topology(n.Topology); ok { - summary.Label = n.ID // This is unlikely to look very good, but is a reasonable fallback return summary, true } if strings.HasPrefix(n.Topology, "group:") {