From 67052a65806aa09b53b8cf61bb273c114f7483ca Mon Sep 17 00:00:00 2001 From: Bryan Boreham Date: Fri, 20 Jul 2018 20:29:52 +0000 Subject: [PATCH] Optimise NewDerivedNode() Create the new node's children without making an intermediate NodeSet --- render/id.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/render/id.go b/render/id.go index 72ca6feb9..825c674d7 100644 --- a/render/id.go +++ b/render/id.go @@ -52,7 +52,9 @@ func ParseGroupNodeTopology(topology string) (string, string, bool) { // NewDerivedNode makes a node based on node, but with a new ID func NewDerivedNode(id string, node report.Node) report.Node { - return report.MakeNode(id).WithChildren(node.Children.Add(node)) + result := report.MakeNode(id) + result.Children = node.Children.Add(node) + return result } // NewDerivedPseudoNode makes a new pseudo node with the node as a child