github/weave-scope
1
0
Fork 0
mirror of https://github.com/weaveworks/scope.git synced 2026-05-01 14:58:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: don't return receiver in Topology.AddNode()

Browse Source 
This had little use and was obscuring the mutating nature of
AddNode().
This commit is contained in:
Matthias Radestock
2018-02-19 05:10:04 +00:00
parent c879cc65d3
commit 5b30b668ae
10 changed files with 31 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
app/merger_test.go
View File

@@ -23,10 +23,9 @@ func TestMerger(t *testing.T) {
report1, report2, report3,
}
want := report.MakeReport()
want.Endpoint.
AddNode(report.MakeNode("foo")).
AddNode(report.MakeNode("bar")).
AddNode(report.MakeNode("baz"))
want.Endpoint.AddNode(report.MakeNode("foo"))
want.Endpoint.AddNode(report.MakeNode("bar"))
want.Endpoint.AddNode(report.MakeNode("baz"))
for _, merger := range []app.Merger{app.MakeDumbMerger(), app.NewSmartMerger()} {
// Test the empty list case