From 593952cd6e81ba78bcb4889e884f0a2590eb3015 Mon Sep 17 00:00:00 2001 From: Bryan Boreham Date: Thu, 12 Apr 2018 09:45:16 +0000 Subject: [PATCH] Move report creation outside of timing loop --- app/merger_test.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/app/merger_test.go b/app/merger_test.go index 2626d0c67..5ec36c307 100644 --- a/app/merger_test.go +++ b/app/merger_test.go @@ -67,13 +67,17 @@ func benchmarkMerger(b *testing.B, merger app.Merger) { for i := 0; i < numHosts*5; i++ { reports = append(reports, makeReport()) } + replacements := []report.Report{} + for i := 0; i < numHosts/3; i++ { + replacements = append(replacements, makeReport()) + } b.ResetTimer() for i := 0; i < b.N; i++ { // replace 1/3 of hosts work of reports & merge them all - for i := 0; i < numHosts/3; i++ { - reports[rand.Intn(len(reports))] = makeReport() + for i := 0; i < len(replacements); i++ { + reports[rand.Intn(len(reports))] = replacements[i] } merger.Merge(reports)