From 43fadceb85e06f9584b55244b6eb73ae6ff083c6 Mon Sep 17 00:00:00 2001 From: Matthias Radestock Date: Sun, 24 Dec 2017 08:18:12 +0000 Subject: [PATCH] cosmetic: better function grouping --- app/benchmark_internal_test.go | 38 +++++++++++++++++----------------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/app/benchmark_internal_test.go b/app/benchmark_internal_test.go index 8f90afd4b..26d420e90 100644 --- a/app/benchmark_internal_test.go +++ b/app/benchmark_internal_test.go @@ -76,15 +76,6 @@ func BenchmarkReportUpgrade(b *testing.B) { } } -func BenchmarkRenderList(b *testing.B) { - benchmarkRender(b, func(report report.Report) { - request := &http.Request{ - Form: url.Values{}, - } - topologyRegistry.renderTopologies(report, request) - }) -} - func benchmarkRender(b *testing.B, f func(report.Report)) { r := fixture.Report if *benchReportPath != "" { @@ -105,6 +96,25 @@ func benchmarkRender(b *testing.B, f func(report.Report)) { } } +func benchmarkRenderTopology(b *testing.B, topologyID string) { + benchmarkRender(b, func(report report.Report) { + renderer, filter, err := topologyRegistry.RendererForTopology(topologyID, url.Values{}, report) + if err != nil { + b.Fatal(err) + } + render.Render(report, renderer, filter) + }) +} + +func BenchmarkRenderList(b *testing.B) { + benchmarkRender(b, func(report report.Report) { + request := &http.Request{ + Form: url.Values{}, + } + topologyRegistry.renderTopologies(report, request) + }) +} + func BenchmarkRenderHosts(b *testing.B) { benchmarkRenderTopology(b, "hosts") } @@ -124,13 +134,3 @@ func BenchmarkRenderContainers(b *testing.B) { func BenchmarkRenderProcesses(b *testing.B) { benchmarkRenderTopology(b, "processes") } - -func benchmarkRenderTopology(b *testing.B, topologyID string) { - benchmarkRender(b, func(report report.Report) { - renderer, filter, err := topologyRegistry.RendererForTopology(topologyID, url.Values{}, report) - if err != nil { - b.Fatal(err) - } - render.Render(report, renderer, filter) - }) -}