From 31c88fd62b9f0336950e5fa597dd336556951e50 Mon Sep 17 00:00:00 2001 From: Jonathan Lange Date: Mon, 4 Jul 2016 16:03:50 +0100 Subject: [PATCH] Instrumentation that we might like to keep --- app/multitenant/aws_collector.go | 1 + app/multitenant/memcache_client.go | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/app/multitenant/aws_collector.go b/app/multitenant/aws_collector.go index fb382db2e..b7ed86282 100644 --- a/app/multitenant/aws_collector.go +++ b/app/multitenant/aws_collector.go @@ -326,6 +326,7 @@ func (c *awsCollector) Report(ctx context.Context) (report.Report, error) { } } + log.Debugf("Fetching %d reports from %v to %v", len(reportKeys), start, now) reports, err := c.getReports(reportKeys) if err != nil { return report.MakeReport(), err diff --git a/app/multitenant/memcache_client.go b/app/multitenant/memcache_client.go index f82ec8966..bd3fb054c 100644 --- a/app/multitenant/memcache_client.go +++ b/app/multitenant/memcache_client.go @@ -188,6 +188,11 @@ func (c *MemcacheClient) FetchReports(keys []string) (map[string]report.Report, } } + if len(missing) > 0 { + sort.Strings(missing) + log.Warningf("Missing %d reports from memcache: %v", len(missing), missing) + } + memcacheHits.Add(float64(len(reports))) memcacheRequests.Add(float64(len(keys))) return reports, missing, nil