From 2f16729ef12e0a79f40de87b19450df829a25bd9 Mon Sep 17 00:00:00 2001 From: Peter Bourgon Date: Tue, 26 May 2015 16:54:23 +0200 Subject: [PATCH] Fix errcheck errors in experimental --- experimental/example/goapp/app.go | 7 +++++-- experimental/genreport/main.go | 5 ++++- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/experimental/example/goapp/app.go b/experimental/example/goapp/app.go index fb30a15e0..a184b45b9 100644 --- a/experimental/example/goapp/app.go +++ b/experimental/example/goapp/app.go @@ -82,9 +82,12 @@ func get(target string) { log.Printf("%s: %v", target, err) return } + defer resp.Body.Close() log.Printf("%s: %s", target, resp.Status) - io.Copy(ioutil.Discard, resp.Body) - resp.Body.Close() + if _, err := io.Copy(ioutil.Discard, resp.Body); err != nil { + log.Printf("%s: %v", target, err) + return + } } func interrupt() error { diff --git a/experimental/genreport/main.go b/experimental/genreport/main.go index 22ea22ba9..51875f6cc 100644 --- a/experimental/genreport/main.go +++ b/experimental/genreport/main.go @@ -3,11 +3,14 @@ package main import ( "encoding/json" "flag" + "log" "os" ) func main() { nodes := flag.Int("nodes", 10, "node count") flag.Parse() - json.NewEncoder(os.Stdout).Encode(DemoReport(*nodes)) + if err := json.NewEncoder(os.Stdout).Encode(DemoReport(*nodes)); err != nil { + log.Print(err) + } }