From 29a3070338b6be07771243bfa60f0acdfe959d47 Mon Sep 17 00:00:00 2001 From: Roland Schilter Date: Mon, 24 Jul 2017 15:26:01 +0200 Subject: [PATCH] Pass `layout` when tracking mixpanel event --- .../node-details/node-details-health-link-item.js | 6 +++++- .../node-details/node-details-table-node-metric-link.js | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/client/app/scripts/components/node-details/node-details-health-link-item.js b/client/app/scripts/components/node-details/node-details-health-link-item.js index b2417249c..e146ed92b 100644 --- a/client/app/scripts/components/node-details/node-details-health-link-item.js +++ b/client/app/scripts/components/node-details/node-details-health-link-item.js @@ -4,6 +4,7 @@ import NodeDetailsHealthItem from './node-details-health-item'; import CloudLink from '../cloud-link'; import { getMetricColor } from '../../utils/metric-utils'; import { trackMixpanelEvent } from '../../utils/tracking-utils'; +import { GRAPH_VIEW_MODE } from '../../constants/naming'; export default class NodeDetailsHealthLinkItem extends React.Component { @@ -27,7 +28,10 @@ export default class NodeDetailsHealthLinkItem extends React.Component { } onClick() { - trackMixpanelEvent('scope.node.metric.click', { topologyId: this.props.topologyId }); + trackMixpanelEvent('scope.node.metric.click', { + layout: GRAPH_VIEW_MODE, + topologyId: this.props.topologyId, + }); } render() { diff --git a/client/app/scripts/components/node-details/node-details-table-node-metric-link.js b/client/app/scripts/components/node-details/node-details-table-node-metric-link.js index 5196914a4..51d9ee455 100644 --- a/client/app/scripts/components/node-details/node-details-table-node-metric-link.js +++ b/client/app/scripts/components/node-details/node-details-table-node-metric-link.js @@ -3,6 +3,7 @@ import React from 'react'; import CloudLink from '../cloud-link'; import { formatMetric } from '../../utils/string-utils'; import { trackMixpanelEvent } from '../../utils/tracking-utils'; +import { TABLE_VIEW_MODE } from '../../constants/naming'; class NodeDetailsTableNodeMetricLink extends React.Component { constructor(props) { @@ -12,7 +13,10 @@ class NodeDetailsTableNodeMetricLink extends React.Component { } onClick() { - trackMixpanelEvent('scope.node.metric.click', { topologyId: this.props.topologyId }); + trackMixpanelEvent('scope.node.metric.click', { + layout: TABLE_VIEW_MODE, + topologyId: this.props.topologyId, + }); } static dismissEvent(ev) {