From 289226707d67a7b626039428b1fa82e1ab16caf5 Mon Sep 17 00:00:00 2001 From: Matthias Radestock Date: Thu, 21 Dec 2017 16:24:46 +0000 Subject: [PATCH] render sensible labels for k8s nodes with little/no metadata We fall back to using the object id as the label. --- render/detailed/summary.go | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/render/detailed/summary.go b/render/detailed/summary.go index 4c1e7821f..d6b0bbd39 100644 --- a/render/detailed/summary.go +++ b/render/detailed/summary.go @@ -264,8 +264,15 @@ func containerImageNodeSummary(base NodeSummary, n report.Node) (NodeSummary, bo } func addKubernetesLabelAndRank(base NodeSummary, n report.Node) NodeSummary { - base.Label, _ = n.Latest.Lookup(kubernetes.Name) - namespace, _ := n.Latest.Lookup(kubernetes.Namespace) + var ( + name, _ = n.Latest.Lookup(kubernetes.Name) + namespace, _ = n.Latest.Lookup(kubernetes.Namespace) + ) + if name != "" { + base.Label = name + } else { + base.Label, _, _ = report.ParseNodeID(n.ID) + } base.Rank = namespace + "/" + base.Label return base }