github/weave-scope
1
0
Fork 0
mirror of https://github.com/weaveworks/scope.git synced 2026-05-16 06:07:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't map IPs for containers that are not running

Browse Source 
For instance Kubernetes may have a record of a dead and restarted
container in a pod, so both the dead and the live one will map to the
same IP address and we would remove that address as ambiguous.
This commit is contained in:
Bryan Boreham
2018-02-25 14:03:20 +00:00
parent c39254f63c
commit 1910e5ecc3
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
render/container.go
View File

@@ -208,7 +208,11 @@ func MapContainer2IP(rpt report.Report, m report.Node) []string {
// we cannot use its IP to attribute connections
// (they could come from any other process on the host or DNAT-ed IPs)
_, isInHostNetwork := m.Latest.Lookup(docker.IsInHostNetwork)
if doesntMakeConnections || isInHostNetwork {
// mapping IPs for containers that are not running can confuse the display
state, stateFound := m.Latest.Lookup(docker.ContainerState)
notRunning := stateFound && state != docker.StateRunning
if doesntMakeConnections || isInHostNetwork || notRunning {
return nil
}