From 09e15d7f705d69bb97d8aa8ab1ba0c5758359344 Mon Sep 17 00:00:00 2001 From: Bryan Boreham Date: Tue, 10 Mar 2020 11:12:45 +0000 Subject: [PATCH] Remove benchmark test of a single assignment EndpointRender was so trivial it took a long time to hunt for a number of iterations that took over 1 second. So stop benchmarking it, and indeed get rid of it completely. --- render/benchmark_test.go | 3 +-- render/endpoint.go | 3 --- render/process_test.go | 2 +- 3 files changed, 2 insertions(+), 6 deletions(-) diff --git a/render/benchmark_test.go b/render/benchmark_test.go index 962f83a4a..af6e6a10d 100644 --- a/render/benchmark_test.go +++ b/render/benchmark_test.go @@ -18,8 +18,7 @@ var ( benchmarkRenderResult render.Nodes ) -func BenchmarkEndpointRender(b *testing.B) { benchmarkRender(b, render.EndpointRenderer) } -func BenchmarkProcessRender(b *testing.B) { benchmarkRender(b, render.ProcessRenderer) } +func BenchmarkProcessRender(b *testing.B) { benchmarkRender(b, render.ProcessRenderer) } func BenchmarkConnectedProcessRender(b *testing.B) { benchmarkRender(b, render.ConnectedProcessRenderer) } diff --git a/render/endpoint.go b/render/endpoint.go index c645bb995..61de80fea 100644 --- a/render/endpoint.go +++ b/render/endpoint.go @@ -12,9 +12,6 @@ import ( // and "unmanaged containers". const Pseudo = "pseudo" -// EndpointRenderer is a Renderer which produces a renderable endpoint graph. -var EndpointRenderer = SelectEndpoint - type endpointMapFunc func(report.Node) string type mapEndpoints struct { diff --git a/render/process_test.go b/render/process_test.go index eb515c9f5..ae855176b 100644 --- a/render/process_test.go +++ b/render/process_test.go @@ -13,7 +13,7 @@ import ( ) func TestEndpointRenderer(t *testing.T) { - have := utils.Prune(render.EndpointRenderer.Render(context.Background(), fixture.Report).Nodes) + have := utils.Prune(render.SelectEndpoint.Render(context.Background(), fixture.Report).Nodes) want := utils.Prune(expected.RenderedEndpoints) if !reflect.DeepEqual(want, have) { t.Error(test.Diff(want, have))