From 0116b963e3a9772cba2bf2a3862dd8672025d5b4 Mon Sep 17 00:00:00 2001 From: Krzesimir Nowak Date: Thu, 21 Jul 2016 11:52:01 +0200 Subject: [PATCH] Extend the node control rewriting test Just to make sure that all the node controls are rewritten, even those that don't have a counterpart in topology controls. --- probe/plugins/registry_internal_test.go | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/probe/plugins/registry_internal_test.go b/probe/plugins/registry_internal_test.go index a969adcb7..194cee5fb 100644 --- a/probe/plugins/registry_internal_test.go +++ b/probe/plugins/registry_internal_test.go @@ -762,6 +762,14 @@ func TestRegistryRegistersHandlers(t *testing.T) { "/control": {http.StatusOK, mustMarshal(PluginResponse{})}, }), }.file(), + mockPlugin{ + t: t, + Name: "testPlugin2", + Handler: mapStringHandler(testResponseMap{ + "/report": {http.StatusOK, mustMarshal(testReport(topologyWithControls("pod", "node2", []int{1, 2}, []int{1}), pluginSpec("testPlugin2", "reporter", "controller")))}, + "/control": {http.StatusOK, mustMarshal(PluginResponse{})}, + }), + }.file(), ) defer restore(t) @@ -775,11 +783,14 @@ func TestRegistryRegistersHandlers(t *testing.T) { defer r.Close() r.Report() - if len(testBackend.handlers) != 1 { - t.Fatalf("Expected only one registered handler, got %d", len(testBackend.handlers)) + expectedLen := 3 + if len(testBackend.handlers) != expectedLen { + t.Fatalf("Expected %d registered handler, got %d", expectedLen, len(testBackend.handlers)) } fakeIDs := []string{ fakeControlID("testPlugin", controlID(1)), + fakeControlID("testPlugin2", controlID(1)), + fakeControlID("testPlugin2", controlID(2)), } for _, fakeID := range fakeIDs { if _, found := testBackend.Handler(fakeID); !found {