From fefeb076f2eff7e9ebd8104f7a4b161bb4e159bc Mon Sep 17 00:00:00 2001 From: AJ ONeal Date: Wed, 5 Jun 2024 08:18:50 +0000 Subject: [PATCH] doc(github-like): update types --- _common/gitea.js | 23 ++++++++++------------- _common/github.js | 8 ++++---- 2 files changed, 14 insertions(+), 17 deletions(-) diff --git a/_common/gitea.js b/_common/gitea.js index 104bed6..dcc5f49 100644 --- a/_common/gitea.js +++ b/_common/gitea.js @@ -3,23 +3,20 @@ var ghRelease = require('./github.js'); /** - * Gets the releases for 'ripgrep'. This function could be trimmed down and made - * for use with any github release. + * Lists Gitea Releases (w/ uploaded assets) * - * @param request - * @param {string} owner - * @param {string} repo - * @returns {PromiseLike | Promise} + * @param {any} request + * @param {String} owner + * @param {String} repo + * @param {String} baseurl */ -function getAllReleases(request, owner, repo, baseurl) { +async function getAllReleases(request, owner, repo, baseurl) { if (!baseurl) { - return Promise.reject('missing baseurl'); + throw new Error('missing baseurl'); } - return ghRelease(request, owner, repo, baseurl + '/api/v1').then( - function (all) { - return all; - }, - ); + baseurl = `${baseurl}/api/v1`; + let all = await ghRelease(request, owner, repo, baseurl); + return all; } module.exports = getAllReleases; diff --git a/_common/github.js b/_common/github.js index 992738c..fb69862 100644 --- a/_common/github.js +++ b/_common/github.js @@ -5,10 +5,10 @@ require('dotenv').config(); /** * Lists GitHub Releases (w/ uploaded assets) * - * @param request - * @param {string} owner - * @param {string} repo - * @returns {PromiseLike | Promise} + * @param {any} request + * @param {String} owner + * @param {String} repo + * @param {String} [baseurl] */ async function getAllReleases( request,