From 68ecaf2fbc2e8a1ed50c4ee8eaa7a4043c999c99 Mon Sep 17 00:00:00 2001 From: AJ ONeal Date: Tue, 10 Mar 2026 17:01:47 -0600 Subject: [PATCH] fix(node): tag .pkg as installer variant alongside .msi The macOS .pkg is a pkgutil installer, not a plain archive. Tagged as installer so it's excluded from legacy export but available for Go's native installer support. --- internal/releases/node/variants.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/internal/releases/node/variants.go b/internal/releases/node/variants.go index 66f8a36..2d9f1ed 100644 --- a/internal/releases/node/variants.go +++ b/internal/releases/node/variants.go @@ -4,13 +4,13 @@ import "github.com/webinstall/webi-installers/internal/storage" // TagVariants tags node-specific build variants. // -// .msi is a Windows installer. .exe is the bare node.exe binary — valid -// and installable by Go, but not present in the legacy Node.js cache -// (the nodedist classifier doesn't construct that filename). +// - .msi — Windows installer +// - .pkg — macOS installer (pkgutil --expand-full) +// - .exe — bare node.exe without npm, too minimal to be useful func TagVariants(assets []storage.Asset) { for i := range assets { switch assets[i].Format { - case ".msi": + case ".msi", ".pkg": assets[i].Variants = append(assets[i].Variants, "installer") case ".exe": assets[i].Variants = append(assets[i].Variants, "bare-exe")