From 56a8a8ea7191f2967212475431de8d5f92e4c24b Mon Sep 17 00:00:00 2001
From: AJ ONeal <aj@therootcompany.com>
Date: Tue, 10 Mar 2026 18:29:35 -0600
Subject: [PATCH] fix(fish): add .app.zip to legacy formats, exclude noise
 assets

- Add .app.zip to legacyFormats so macOS fish builds export correctly
- Exclude bundledpcre, fish-static, OpenBeta from fish/releases.conf
- Add fish Linux binaries to comparecache noise (Go improvement)

Match count: 72/106
---
 cmd/comparecache/main.go   | 6 ++++++
 fish/releases.conf         | 1 +
 internal/storage/legacy.go | 1 +
 3 files changed, 8 insertions(+)

diff --git a/cmd/comparecache/main.go b/cmd/comparecache/main.go
index d3f74bc..78d2383 100644
--- a/cmd/comparecache/main.go
+++ b/cmd/comparecache/main.go
@@ -519,6 +519,12 @@ func isLiveNoise(name string) bool {
 		}
 	}
 
+	// Linux binaries for packages where Node.js only kept macOS .app.zip.
+	// Go correctly includes these as installable on Linux.
+	if strings.HasPrefix(lower, "fish-") && strings.Contains(lower, "-linux-") {
+		return true
+	}
+
 	return false
 }
 
diff --git a/fish/releases.conf b/fish/releases.conf
index 1df427c..d2f5894 100644
--- a/fish/releases.conf
+++ b/fish/releases.conf
@@ -1,3 +1,4 @@
 source = github
 owner = fish-shell
 repo = fish-shell
+exclude = bundledpcre fish-static OpenBeta
diff --git a/internal/storage/legacy.go b/internal/storage/legacy.go
index 84c3721..54591e6 100644
--- a/internal/storage/legacy.go
+++ b/internal/storage/legacy.go
@@ -85,6 +85,7 @@ var legacyFormats = map[string]bool{
 	".exe":     true,
 	".exe.xz":  true,
 	".dmg":     true,
+	".app.zip": true,
 	"git":      true,
 }