From 125ffa96dcda5762897d4be63dda46b485235814 Mon Sep 17 00:00:00 2001 From: AJ ONeal Date: Wed, 5 Jun 2024 08:38:48 +0000 Subject: [PATCH] ref(github-like): pass options object for args --- _common/gitea.js | 4 ++-- _common/github.js | 4 ++-- _common/githubish.js | 29 +++++++++++++++-------------- 3 files changed, 19 insertions(+), 18 deletions(-) diff --git a/_common/gitea.js b/_common/gitea.js index 0e3e618..d6233b7 100644 --- a/_common/gitea.js +++ b/_common/gitea.js @@ -21,14 +21,14 @@ async function getAllReleases( token = '', ) { baseurl = `${baseurl}/api/v1`; - let all = await GitHubish.getAllReleases( + let all = await GitHubish.getAllReleases({ request, owner, repo, baseurl, username, token, - ); + }); return all; } diff --git a/_common/github.js b/_common/github.js index 275cd14..5e5d8d8 100644 --- a/_common/github.js +++ b/_common/github.js @@ -22,14 +22,14 @@ async function getAllReleases( username = process.env.GITHUB_USERNAME || '', token = process.env.GITHUB_TOKEN || '', ) { - let all = await GitHubish.getAllReleases( + let all = await GitHubish.getAllReleases({ request, owner, repo, baseurl, username, token, - ); + }); return all; } diff --git a/_common/githubish.js b/_common/githubish.js index 77cc692..6e233fa 100644 --- a/_common/githubish.js +++ b/_common/githubish.js @@ -5,21 +5,22 @@ let GitHubish = module.exports; /** * Lists GitHub-Like Releases (w/ uploaded assets) * - * @param {any} request - * @param {String} owner - * @param {String} repo - * @param {String} baseurl - * @param {String} [username] - * @param {String} [token] + * @param {Object} opts + * @param {any} opts.request + * @param {String} opts.owner + * @param {String} opts.repo + * @param {String} opts.baseurl + * @param {String} [opts.username] + * @param {String} [opts.token] */ -GitHubish.getAllReleases = async function ( +GitHubish.getAllReleases = async function ({ request, owner, repo, baseurl, username = '', token = '', -) { +}) { if (!owner) { throw new Error('missing owner for repo'); } @@ -98,12 +99,12 @@ GitHubish.getAllReleases = async function ( }; if (module === require.main) { - GitHubish.getAllReleases( - require('@root/request'), - 'BurntSushi', - 'ripgrep', - 'https://api.github.com', - ).then(function (all) { + GitHubish.getAllReleases({ + request: require('@root/request'), + owner: 'BurntSushi', + repo: 'ripgrep', + baseurl: 'https://api.github.com', + }).then(function (all) { console.info(JSON.stringify(all, null, 2)); }); }