mirror of
https://github.com/replicatedhq/troubleshoot.git
synced 2026-04-15 07:16:34 +00:00
* created roadmap and yaml claude agent
* Update roadmap.md
* feat: Clean advanced analysis implementation - core agents, engine, artifacts
* Remove unrelated files - keep only advanced analysis implementation
* fix: Fix goroutine leak in hosted agent rate limiter
- Added stop channel and stopped flag to RateLimiter struct
- Modified replenishTokens to listen for stop signal and exit cleanly
- Added Stop() method to gracefully shutdown rate limiter
- Added Stop() method to HostedAgent to cleanup rate limiter on shutdown
Fixes cursor bot issue: Rate Limiter Goroutine Leak
* fix: Fix analyzer config and model validation bugs
Bug 1: Analyzer Config Missing File Path
- Added filePath to DeploymentStatus analyzer config in convertAnalyzerToSpec
- Sets namespace-specific path (cluster-resources/deployments/{namespace}.json)
- Falls back to generic path (cluster-resources/deployments.json) if no namespace
- Fixes LocalAgent.analyzeDeploymentStatus backward compatibility
Bug 2: HealthCheck Fails Model Validation
- Changed Ollama model validation from prefix match to exact match
- Prevents false positives where llama2:13b would match request for llama2:7b
- Ensures agent only reports healthy when exact model is available
Both fixes address cursor bot reported issues and maintain backward compatibility.
* fixing lint errors
* fixing lint errors
* adding CLI flags
* fix: resolve linting errors for CI
- Remove unnecessary nil check in host_kernel_configs.go (len() for nil slices is zero)
- Remove unnecessary fmt.Sprintf() calls in ceph.go for static strings
- Apply go fmt formatting fixes
Fixes failing lint CI check
* fix: resolve CI failures in build-test workflow and Ollama tests
1. Fix GitHub Actions workflow logic error:
- Replace problematic contains() expression with explicit job result checks
- Properly handle failure and cancelled states for each job
- Prevents false positive failures in success summary job
2. Fix Ollama agent parseLLMResponse panics:
- Add proper error handling for malformed JSON in LLM responses
- Return error when JSON is found but invalid (instead of silent fallback)
- Add error when no meaningful content can be parsed from response
- Prevents nil pointer dereference in test assertions
Fixes failing build-test/success and build-test/test CI checks
* fix: resolve all CI failures and cursor bot issues
1. Fix disable-ollama flag logic bug:
- Remove disable-ollama from advanced analysis trigger condition
- Prevents unintended advanced analysis mode when no agents registered
- Allows proper fallback to legacy analysis
2. Fix diff test consistency:
- Update test expectations to match function behavior (lines with newlines)
- Ensures consistency between streaming and non-streaming diff paths
3. Fix Ollama agent error handling:
- Add proper error return for malformed JSON in LLM responses
- Add meaningful content validation for markdown parsing
- Prevents nil pointer panics in test assertions
4. Fix analysis engine mock agent:
- Mock agent now processes and returns results for all provided analyzers
- Fixes test expectation mismatch (expected 8 results, got 1)
Resolves all failing CI checks: lint, test, and success workflow logic
---------
Co-authored-by: Noah Campbell <noah.edward.campbell@gmail.com>
116 lines
3.8 KiB
Go
116 lines
3.8 KiB
Go
package cli
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"strings"
|
|
|
|
"github.com/replicatedhq/troubleshoot/cmd/internal/util"
|
|
"github.com/replicatedhq/troubleshoot/pkg/k8sutil"
|
|
"github.com/replicatedhq/troubleshoot/pkg/logger"
|
|
"github.com/spf13/cobra"
|
|
"github.com/spf13/viper"
|
|
"k8s.io/klog/v2"
|
|
)
|
|
|
|
// validateArgs allows certain flags to run without requiring bundle arguments
|
|
func validateArgs(cmd *cobra.Command, args []string) error {
|
|
// Special flags that don't require bundle arguments
|
|
if cmd.Flags().Changed("check-ollama") || cmd.Flags().Changed("setup-ollama") ||
|
|
cmd.Flags().Changed("list-models") || cmd.Flags().Changed("pull-model") {
|
|
return nil
|
|
}
|
|
|
|
// For all other cases, require at least 1 argument (the bundle path)
|
|
if len(args) < 1 {
|
|
return fmt.Errorf("requires at least 1 arg(s), only received %d. Usage: analyze [bundle-path] or use --check-ollama/--setup-ollama", len(args))
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func RootCmd() *cobra.Command {
|
|
cmd := &cobra.Command{
|
|
Use: "analyze [url]",
|
|
Args: validateArgs,
|
|
Short: "Analyze a support bundle",
|
|
Long: `Run a series of analyzers on a support bundle archive`,
|
|
SilenceUsage: true,
|
|
PreRun: func(cmd *cobra.Command, args []string) {
|
|
v := viper.GetViper()
|
|
v.BindPFlags(cmd.Flags())
|
|
|
|
logger.SetupLogger(v)
|
|
|
|
if err := util.StartProfiling(); err != nil {
|
|
klog.Errorf("Failed to start profiling: %v", err)
|
|
}
|
|
},
|
|
RunE: func(cmd *cobra.Command, args []string) error {
|
|
v := viper.GetViper()
|
|
|
|
// Handle cases where no bundle argument is provided (for utility flags)
|
|
var bundlePath string
|
|
if len(args) > 0 {
|
|
bundlePath = args[0]
|
|
}
|
|
|
|
return runAnalyzers(v, bundlePath)
|
|
},
|
|
PostRun: func(cmd *cobra.Command, args []string) {
|
|
if err := util.StopProfiling(); err != nil {
|
|
klog.Errorf("Failed to stop profiling: %v", err)
|
|
}
|
|
},
|
|
}
|
|
|
|
cobra.OnInitialize(initConfig)
|
|
|
|
cmd.AddCommand(util.VersionCmd())
|
|
|
|
cmd.Flags().String("analyzers", "", "filename or url of the analyzers to use")
|
|
cmd.Flags().Bool("debug", false, "enable debug logging")
|
|
|
|
// Advanced analysis flags
|
|
cmd.Flags().Bool("advanced-analysis", false, "use advanced analysis engine with AI capabilities")
|
|
cmd.Flags().StringSlice("agents", []string{"local"}, "analysis agents to use: local, hosted, ollama")
|
|
cmd.Flags().Bool("enable-ollama", false, "enable Ollama AI-powered analysis")
|
|
cmd.Flags().Bool("disable-ollama", false, "explicitly disable Ollama AI-powered analysis")
|
|
cmd.Flags().String("ollama-endpoint", "http://localhost:11434", "Ollama server endpoint")
|
|
cmd.Flags().String("ollama-model", "llama2:7b", "Ollama model to use for analysis")
|
|
cmd.Flags().Bool("use-codellama", false, "use CodeLlama model for code-focused analysis")
|
|
cmd.Flags().Bool("use-mistral", false, "use Mistral model for fast analysis")
|
|
cmd.Flags().Bool("auto-pull-model", true, "automatically pull model if not available")
|
|
cmd.Flags().Bool("list-models", false, "list all available/installed Ollama models and exit")
|
|
cmd.Flags().Bool("pull-model", false, "pull the specified model and exit")
|
|
cmd.Flags().Bool("setup-ollama", false, "automatically setup and configure Ollama")
|
|
cmd.Flags().Bool("check-ollama", false, "check Ollama installation status and exit")
|
|
cmd.Flags().Bool("include-remediation", true, "include remediation suggestions in analysis results")
|
|
cmd.Flags().String("output-file", "", "save analysis results to file (e.g., --output-file results.json)")
|
|
|
|
viper.BindPFlags(cmd.Flags())
|
|
|
|
viper.SetEnvKeyReplacer(strings.NewReplacer("-", "_"))
|
|
|
|
// Initialize klog flags
|
|
logger.InitKlogFlags(cmd)
|
|
|
|
k8sutil.AddFlags(cmd.Flags())
|
|
|
|
// CPU and memory profiling flags
|
|
util.AddProfilingFlags(cmd)
|
|
|
|
return cmd
|
|
}
|
|
|
|
func InitAndExecute() {
|
|
if err := RootCmd().Execute(); err != nil {
|
|
os.Exit(1)
|
|
}
|
|
}
|
|
|
|
func initConfig() {
|
|
viper.SetEnvPrefix("TROUBLESHOOT")
|
|
viper.AutomaticEnv()
|
|
}
|