Files
troubleshoot/pkg/analyze/host_kernel_modules.go
Simon Croome 977fc438ea Remote host collectors (#392)
* Add collect command and remote host collectors

Adds the ability to run a host collector on a set of remote k8s nodes.
Target nodes can be filtered using the --selector flag, with the same
syntax as kubectl.  Existing flags for --collector-image,
--collector-pullpolicy and --request-timeout are used.  To run on a
specified node, --selector="kubernetes.io/hostname=kind-worker2" could
be used.

The collect command is used by the remote collector to output the
results using a "raw" format, which uses the filename as the key, and
the value the output as a escaped json string.  When run manually it
defaults to fully decoded json. The existing block devices,
ipv4interfaces and services host collectors don't decode properly - the
fix is to convert their slice output to a map (fix not included as
unsure what depends on the existing format).

The collect command is also useful for troubleshooting preflight issues.

Examples are included to show remote collector usage.

```
bin/collect --collector-image=croomes/troubleshoot:latest  examples/collect/remote/memory.yaml --namespace test
{
  "kind-control-plane": {
    "system/memory.json": {
      "total": 1304207360
    }
  },
  "kind-worker": {
    "system/memory.json": {
      "total": 1695780864
    }
  },
  "kind-worker2": {
    "system/memory.json": {
      "total": 1726353408
    }
  }
}
```

The preflight command has been updated to run remote collectors.  To run
a host collector remotely it must be specified in the spec as a
`remoteCollector`:

```
apiVersion: troubleshoot.sh/v1beta2
kind: HostPreflight
metadata:
  name: memory
spec:
  remoteCollectors:
    - memory:
        collectorName: memory
  analyzers:
    - memory:
        outcomes:
          - fail:
              when: "< 8Gi"
              message: At least 8Gi of memory is required
          - warn:
              when: "< 32Gi"
              message: At least 32Gi of memory is recommended
          - pass:
              message: The system has as sufficient memory
```

Results for each node are analyzed separately, with the node name
appended to the title:

```
bin/preflight --interactive=false --collector-image=croomes/troubleshoot:latest examples/preflight/remote/memory.yaml --format=json
{memory running 0 1}
{memory completed 1 1}
{
  "fail": [
    {
      "title": "Amount of Memory (kind-worker2)",
      "message": "At least 8Gi of memory is required"
    },
    {
      "title": "Amount of Memory (kind-worker)",
      "message": "At least 8Gi of memory is required"
    },
    {
      "title": "Amount of Memory (kind-control-plane)",
      "message": "At least 8Gi of memory is required"
    }
  ]
}
```

Also added a host collector to allow preflight checks of required kernel
modules, which is the main driver for this change.
2021-10-06 09:03:53 -05:00

182 lines
5.2 KiB
Go

package analyzer
import (
"encoding/json"
"fmt"
"strings"
"github.com/pkg/errors"
troubleshootv1beta2 "github.com/replicatedhq/troubleshoot/pkg/apis/troubleshoot/v1beta2"
"github.com/replicatedhq/troubleshoot/pkg/collect"
)
type AnalyzeHostKernelModules struct {
hostAnalyzer *troubleshootv1beta2.KernelModulesAnalyze
}
func (a *AnalyzeHostKernelModules) Title() string {
return hostAnalyzerTitleOrDefault(a.hostAnalyzer.AnalyzeMeta, "Kernel Modules")
}
func (a *AnalyzeHostKernelModules) IsExcluded() (bool, error) {
return isExcluded(a.hostAnalyzer.Exclude)
}
// Analyze the kernel module collection results.
//
// When an outcome is specified, the "when" condition must be empty (for default
// conditions), or made up of 3 parts:
//
// - comma-separated list of kernel module names, e,g, "target_core_mod,target_core_file,tcm_loop"
// - comparison operator ("==", "=", "!=", "<>")
// - comma-separated state list ("unknown", "loaded", "loadable", "loading", "unloading")
//
// Multiple outcomes can be provided. Outcomes should not conflict.
//
// Default outcomes (with empty when clauses) can be provided for fail, warn and
// pass. When multiple defaults are provided, evaluation is processed in the
// order that they were specified and the first to match is returned.
//
// - a default fail will only trigger if there are no matching non-default pass outcomes.
// - a default warn will only trigger if there are no matching non-default pass or fail outcomes.
// - a default pass will only trigger if there are no matching non-default fail outcomes.
//
func (a *AnalyzeHostKernelModules) Analyze(getCollectedFileContents func(string) ([]byte, error)) ([]*AnalyzeResult, error) {
hostAnalyzer := a.hostAnalyzer
contents, err := getCollectedFileContents("system/kernel_modules.json")
if err != nil {
return nil, errors.Wrap(err, "failed to get collected file")
}
modules := make(map[string]collect.KernelModuleInfo)
if err := json.Unmarshal(contents, &modules); err != nil {
return nil, errors.Wrap(err, "failed to unmarshal kernel modules")
}
var coll resultCollector
var passed, failed bool
for _, outcome := range hostAnalyzer.Outcomes {
result := &AnalyzeResult{Title: a.Title()}
if outcome.Fail != nil && outcome.Fail.When != "" {
isMatch, err := compareKernelModuleConditionalToActual(outcome.Fail.When, modules)
if err != nil {
return nil, errors.Wrapf(err, "failed to compare %s", outcome.Fail.When)
}
if isMatch {
result.IsFail = true
result.Message = outcome.Fail.Message
result.URI = outcome.Fail.URI
coll.push(result)
failed = true
}
} else if outcome.Warn != nil && outcome.Warn.When != "" {
isMatch, err := compareKernelModuleConditionalToActual(outcome.Warn.When, modules)
if err != nil {
return nil, errors.Wrapf(err, "failed to compare %s", outcome.Warn.When)
}
if isMatch {
result.IsWarn = true
result.Message = outcome.Warn.Message
result.URI = outcome.Warn.URI
coll.push(result)
}
} else if outcome.Pass != nil && outcome.Pass.When != "" {
isMatch, err := compareKernelModuleConditionalToActual(outcome.Pass.When, modules)
if err != nil {
return nil, errors.Wrapf(err, "failed to compare %s", outcome.Pass.When)
}
if isMatch {
result.IsPass = true
result.Message = outcome.Pass.Message
result.URI = outcome.Pass.URI
coll.push(result)
passed = true
}
}
}
for _, outcome := range hostAnalyzer.Outcomes {
result := &AnalyzeResult{Title: a.Title()}
if outcome.Fail != nil && outcome.Fail.When == "" && !passed {
result.IsFail = true
result.Message = outcome.Fail.Message
result.URI = outcome.Fail.URI
coll.push(result)
break
} else if outcome.Warn != nil && outcome.Warn.When == "" && !passed && !failed {
result.IsWarn = true
result.Message = outcome.Warn.Message
result.URI = outcome.Warn.URI
coll.push(result)
break
} else if outcome.Pass != nil && outcome.Pass.When == "" && !failed {
result.IsPass = true
result.Message = outcome.Pass.Message
result.URI = outcome.Pass.URI
coll.push(result)
break
}
}
return coll.get(a.Title()), nil
}
func compareKernelModuleConditionalToActual(conditional string, modules map[string]collect.KernelModuleInfo) (res bool, err error) {
parts := strings.Split(conditional, " ")
if len(parts) != 3 {
return false, fmt.Errorf("Expected exactly 3 parts in conditional, got %d", len(parts))
}
matchModules := strings.Split(parts[0], ",")
matchStatuses := strings.Split(parts[2], ",")
switch parts[1] {
case "=", "==":
for _, name := range matchModules {
module, ok := modules[name]
if !ok {
return false, nil
}
moduleOK := false
// Only one status must be true.
for _, status := range matchStatuses {
if module.Status == collect.KernelModuleStatus(status) {
moduleOK = true
continue
}
}
if !moduleOK {
return false, nil
}
}
return true, nil
case "!=", "<>":
for _, name := range matchModules {
module, ok := modules[name]
if !ok {
return true, nil
}
for _, status := range matchStatuses {
if module.Status == collect.KernelModuleStatus(status) {
return false, nil
}
}
}
return true, nil
}
return false, fmt.Errorf("unexpected operator %q", parts[1])
}