* feat(analyze): warn when nodeResources has no node data, add ignoreIfNoFiles
The nodeResources analyzer previously failed silently when
cluster-resources/nodes.json was not collected (e.g. when the
clusterResources collector was excluded or could not list nodes).
It now emits a warn outcome per nodeResources entry in the spec.
Add an ignoreIfNoFiles top-level field to nodeResources, mirroring
textAnalyze, so users can opt out of the new warning when the
analyzer is intentionally optional.
- Add IgnoreIfNoFiles to v1beta2.NodeResources
- Update CRDs and JSON schemas
- Unit test the warn / ignore paths
- Add an e2e fixture and test that excludes clusterResources and
asserts the analyze output
Signed-off-by: Evans Mungai <evans@replicated.com>
* Fix review comment
Signed-off-by: Evans Mungai <evans@replicated.com>
---------
Signed-off-by: Evans Mungai <evans@replicated.com>
* fix: record skipped collectors in bundle and improve CLI warnings
- Write `skipped-collectors.json` to the support bundle and preflight bundle recording which collectors were skipped (RBAC permissions or spec exclusion), with reason, errors, and timestamp
- Surface RBAC errors and skipped-collector messages as `klog.Warningf` in non-interactive mode so they're visible without `-v` flags
- Exec collector file naming now falls back to the resolved container name (from the pod spec) when `collectorName` is not set, instead of only checking `containerName` from the spec
Signed-off-by: Evans Mungai <evans@replicated.com>
* Address comment
Signed-off-by: Evans Mungai <evans@replicated.com>
* fix bugbot comment
Signed-off-by: Evans Mungai <evans@replicated.com>
* Remove unused var
Signed-off-by: Evans Mungai <evans@replicated.com>
* Address comment
Signed-off-by: Evans Mungai <evans@replicated.com>
* Use results.SaveResult and add automated tests
Signed-off-by: Evans Mungai <evans@replicated.com>
* Improvements
Signed-off-by: Evans Mungai <evans@replicated.com>
* Fix bugbot
Signed-off-by: Evans Mungai <evans@replicated.com>
* Handle bugbot
Signed-off-by: Evans Mungai <evans@replicated.com>
---------
Signed-off-by: Evans Mungai <evans@replicated.com>
Evans Mungai
Andrew Lavery
João Antunes
Dexter Yan
Diamon WigginsandDexter Yan
Ethan Mosbaugh
Akash Shrivastava