github/troubleshoot
1
0
Fork 0
mirror of https://github.com/replicatedhq/troubleshoot.git synced 2026-02-14 10:19:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix ollama windows installer (#1894)

Browse Source 
* Fix Windows filename issue in scheduled support bundles

* Fix: Close temp file before executing Ollama installer on Windows

Windows requires files to be closed before they can be executed. This fix
ensures the temporary installer file is properly closed before attempting
to run it, preventing file access errors on Windows systems.
This commit is contained in:
Benjamin Yang
2025-10-14 08:51:52 -07:00
committed by GitHub
parent 5aa088b3b6
commit 21dc4e9b09
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
pkg/analyze/ollama_helper.go
View File

@@ -146,7 +146,7 @@ func (h *OllamaHelper) downloadAndInstallWindows() error {
return errors.Wrap(err, "failed to create temporary file") return errors.Wrap(err, "failed to create temporary file")
} }
defer os.Remove(tmpFile.Name()) defer os.Remove(tmpFile.Name())
defer tmpFile.Close() defer tmpFile.Close() // Ensures file is closed in error paths
// Download installer // Download installer
resp, err := http.Get(h.downloadURL) resp, err := http.Get(h.downloadURL)
@@ -165,6 +165,13 @@ func (h *OllamaHelper) downloadAndInstallWindows() error {
return errors.Wrap(err, "failed to write installer") return errors.Wrap(err, "failed to write installer")
} }
// Close the file before executing it (required on Windows)
// Note: This will be called twice (here and via defer), but that's safe
// The defer ensures cleanup on error paths, this ensures closure before execution
if err := tmpFile.Close(); err != nil {
return errors.Wrap(err, "failed to close installer file")
}
// Run installer // Run installer
klog.Info("Running Ollama installer...") klog.Info("Running Ollama installer...")
cmd := exec.Command(tmpFile.Name()) cmd := exec.Command(tmpFile.Name())