From 295020463fbf202133b4cc66c0271955ea941102 Mon Sep 17 00:00:00 2001 From: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com> Date: Mon, 23 Jun 2025 13:46:07 -0400 Subject: [PATCH] feat: Bazel not experimental (#850) Followup to #840 Resolves #849 Removes the experimental flag for verifying bazel attestations. TODO: - [ ] add example invocation for bazel https://github.com/slsa-framework/slsa-verifier/pull/858#pullrequestreview-2947145690 - [ ] create a new release --------- Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com> --- cli/slsa-verifier/verify.go | 2 +- cli/slsa-verifier/verify/verify_github_attestation.go | 7 ------- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/cli/slsa-verifier/verify.go b/cli/slsa-verifier/verify.go index 816f83c..9542e2c 100644 --- a/cli/slsa-verifier/verify.go +++ b/cli/slsa-verifier/verify.go @@ -196,7 +196,7 @@ func verifyGithubAttestation() *cobra.Command { } return nil }, - Short: "Verifies SLSA provenance for a github attestation [experimental]", + Short: "Verifies SLSA provenance for a GitHub artifact attestation", Run: func(cmd *cobra.Command, args []string) { v := verify.VerifyGithubAttestationCommand{ AttestationPath: o.AttestationPath, diff --git a/cli/slsa-verifier/verify/verify_github_attestation.go b/cli/slsa-verifier/verify/verify_github_attestation.go index d15f4e7..16eda3b 100644 --- a/cli/slsa-verifier/verify/verify_github_attestation.go +++ b/cli/slsa-verifier/verify/verify_github_attestation.go @@ -17,7 +17,6 @@ package verify import ( "context" "crypto/sha256" - "errors" "fmt" "os" @@ -35,12 +34,6 @@ type VerifyGithubAttestationCommand struct { } func (c *VerifyGithubAttestationCommand) Exec(ctx context.Context, artifact string) (*utils.TrustedBuilderID, error) { - if !options.ExperimentalEnabled() { - err := errors.New("feature support is only provided in SLSA_VERIFIER_EXPERIMENTAL mode") - fmt.Fprintf(os.Stderr, "Verifying github attestation: FAILED: %v\n\n", err) - return nil, err - } - artifactHash, err := computeFileHash(artifact, sha256.New()) if err != nil { fmt.Fprintf(os.Stderr, "Verifying artifact %s: FAILED: %v\n\n", artifact, err)