From 6ff292e576ab37f056d346ae0eaaa6319a065a9c Mon Sep 17 00:00:00 2001 From: Yuqiu Wang Date: Wed, 13 Sep 2023 11:38:47 -0500 Subject: [PATCH 1/3] run the pipeline using node 20 --- .github/workflows/main.yml | 8 ++++---- .github/workflows/release-package.yml | 12 ++++++------ 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 83b9420..3ba7676 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -9,10 +9,10 @@ jobs: working-directory: "./client" steps: - uses: actions/checkout@v2 - - name: Setup node 12 + - name: Setup node 20 uses: actions/setup-node@v1 with: - node-version: 12.x + node-version: 20.x - run: npm ci working-directory: ${{env.working-directory}} - run: npm run build @@ -29,10 +29,10 @@ jobs: # working-directory: "./server" # steps: # - uses: actions/checkout@v2 - # - name: Setup node 12 + # - name: Setup node 20 # uses: actions/setup-node@v1 # with: - # node-version: 12.x + # node-version: 20.x # - run: npm ci # working-directory: ${{env.working-directory}} # - run: npm run build diff --git a/.github/workflows/release-package.yml b/.github/workflows/release-package.yml index 9a45e89..5ba4f82 100644 --- a/.github/workflows/release-package.yml +++ b/.github/workflows/release-package.yml @@ -11,10 +11,10 @@ jobs: working-directory: "./client" steps: - uses: actions/checkout@v2 - - name: Setup node 12 + - name: Setup node 20 uses: actions/setup-node@v1 with: - node-version: 12.x + node-version: 20.x - run: npm ci working-directory: ${{env.working-directory}} - run: npm run build @@ -32,10 +32,10 @@ jobs: contents: read steps: - uses: actions/checkout@v2 - - name: Setup node 12 + - name: Setup node 20 uses: actions/setup-node@v1 with: - node-version: 12.x + node-version: 20.x registry-url: https://npm.pkg.github.com/ - run: npm ci working-directory: ${{env.working-directory}} @@ -54,10 +54,10 @@ jobs: contents: read steps: - uses: actions/checkout@v2 - - name: Setup node 12 + - name: Setup node 20 uses: actions/setup-node@v1 with: - node-version: 12.x + node-version: 20.x registry-url: https://npm.pkg.github.com/ - run: npm ci working-directory: ${{env.working-directory}} From 7946fd3497242fe5e2d8937305010801bef2b895 Mon Sep 17 00:00:00 2001 From: Yuqiu Wang Date: Wed, 13 Sep 2023 11:43:59 -0500 Subject: [PATCH 2/3] run the pipeline using node 20 --- Dockerfile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Dockerfile b/Dockerfile index c0cdd8f..99ffdfa 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,5 +1,5 @@ # Stage 1 - the build react app -FROM node:12.22.10-alpine as build-deps +FROM node:20.1.1 as build-deps WORKDIR /usr/src/app COPY client/package.json client/package-lock.json ./ RUN npm i @@ -8,7 +8,7 @@ COPY client/ ./ RUN npm run build # Stage 2 - the production environment -FROM node:12.22.10-alpine +FROM node:20.1.1 RUN apk add --no-cache tini ENV NODE_ENV production From 699209957c7e2a08e36b35faec0690f6d21be73b Mon Sep 17 00:00:00 2001 From: Yuqiu Wang Date: Wed, 13 Sep 2023 12:42:56 -0500 Subject: [PATCH 3/3] try using node 16 --- .github/workflows/main.yml | 8 ++++---- .github/workflows/release-package.yml | 12 ++++++------ Dockerfile | 4 ++-- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 3ba7676..7a933d9 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -9,10 +9,10 @@ jobs: working-directory: "./client" steps: - uses: actions/checkout@v2 - - name: Setup node 20 + - name: Setup node 16 uses: actions/setup-node@v1 with: - node-version: 20.x + node-version: 16.x - run: npm ci working-directory: ${{env.working-directory}} - run: npm run build @@ -29,10 +29,10 @@ jobs: # working-directory: "./server" # steps: # - uses: actions/checkout@v2 - # - name: Setup node 20 + # - name: Setup node 16 # uses: actions/setup-node@v1 # with: - # node-version: 20.x + # node-version: 16.x # - run: npm ci # working-directory: ${{env.working-directory}} # - run: npm run build diff --git a/.github/workflows/release-package.yml b/.github/workflows/release-package.yml index 5ba4f82..247e3c2 100644 --- a/.github/workflows/release-package.yml +++ b/.github/workflows/release-package.yml @@ -11,10 +11,10 @@ jobs: working-directory: "./client" steps: - uses: actions/checkout@v2 - - name: Setup node 20 + - name: Setup node 16 uses: actions/setup-node@v1 with: - node-version: 20.x + node-version: 16.x - run: npm ci working-directory: ${{env.working-directory}} - run: npm run build @@ -32,10 +32,10 @@ jobs: contents: read steps: - uses: actions/checkout@v2 - - name: Setup node 20 + - name: Setup node 16 uses: actions/setup-node@v1 with: - node-version: 20.x + node-version: 16.x registry-url: https://npm.pkg.github.com/ - run: npm ci working-directory: ${{env.working-directory}} @@ -54,10 +54,10 @@ jobs: contents: read steps: - uses: actions/checkout@v2 - - name: Setup node 20 + - name: Setup node 16 uses: actions/setup-node@v1 with: - node-version: 20.x + node-version: 16.x registry-url: https://npm.pkg.github.com/ - run: npm ci working-directory: ${{env.working-directory}} diff --git a/Dockerfile b/Dockerfile index 99ffdfa..9db22b1 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,5 +1,5 @@ # Stage 1 - the build react app -FROM node:20.1.1 as build-deps +FROM node:16.11.7 as build-deps WORKDIR /usr/src/app COPY client/package.json client/package-lock.json ./ RUN npm i @@ -8,7 +8,7 @@ COPY client/ ./ RUN npm run build # Stage 2 - the production environment -FROM node:20.1.1 +FROM node:16.11.7 RUN apk add --no-cache tini ENV NODE_ENV production