From 9e3f708d36f82193d56dd649061ded4e6156cc23 Mon Sep 17 00:00:00 2001 From: Romain Fafet Date: Sun, 7 Feb 2021 16:37:43 +0100 Subject: [PATCH 1/2] fix Value Error for position/ --- web/callback.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/web/callback.py b/web/callback.py index 5158688..613fc8a 100644 --- a/web/callback.py +++ b/web/callback.py @@ -77,9 +77,9 @@ def preconditioning(vin, activate): @app.route('/position/') def get_position(vin): res = myp.get_vehicle_info(vin) - longitude, latitude = res.last_position.geometry.coordinates + longitude, latitude, altitude = res.last_position.geometry.coordinates return jsonify( - {"longitude": longitude, "latitude": latitude, "url": f"http://maps.google.com/maps?q={latitude},{longitude}"}) + {"longitude": longitude, "latitude": latitude, "altitude": altitude, "url": f"http://maps.google.com/maps?q={latitude},{longitude}"}) # Set a battery threshold and schedule an hour to stop the charge From 4458df212e25f40473c286c4361d017ddd22f804 Mon Sep 17 00:00:00 2001 From: Romain Fafet Date: Tue, 9 Feb 2021 00:34:03 +0100 Subject: [PATCH 2/2] fix case when there is no altitude --- web/callback.py | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/web/callback.py b/web/callback.py index 613fc8a..74ae744 100644 --- a/web/callback.py +++ b/web/callback.py @@ -77,9 +77,16 @@ def preconditioning(vin, activate): @app.route('/position/') def get_position(vin): res = myp.get_vehicle_info(vin) - longitude, latitude, altitude = res.last_position.geometry.coordinates - return jsonify( - {"longitude": longitude, "latitude": latitude, "altitude": altitude, "url": f"http://maps.google.com/maps?q={latitude},{longitude}"}) + coordinates=res.last_position.geometry.coordinates + if len(coordinates)==3: # altitude is not always availlable + longitude, latitude, altitude = coordinates + return jsonify( + {"longitude": longitude, "latitude": latitude, "altitude": altitude, "url": f"http://maps.google.com/maps?q={latitude},{longitude}"}) + else: + longitude, latitude = coordinates + return jsonify( + {"longitude": longitude, "latitude": latitude, "url": f"http://maps.google.com/maps?q={latitude},{longitude}"}) + # Set a battery threshold and schedule an hour to stop the charge