From 17d19cacffdbfa60ca2fc828b968d62e3779e037 Mon Sep 17 00:00:00 2001
From: Robert Brennan <accounts@rbren.io>
Date: Mon, 4 Jan 2021 13:25:05 -0500
Subject: [PATCH] Fix up zero-score issues (#468)

* return score of 100 when no checks specified

* fix up zero states in frontend

* rename variables
---
 pkg/dashboard/assets/js/charts.js        | 15 ++++++++++-----
 pkg/dashboard/helpers.go                 |  4 ++--
 pkg/dashboard/templates/dashboard.gohtml | 18 +++++++++++++++---
 pkg/validator/summary.go                 |  4 ++--
 4 files changed, 29 insertions(+), 12 deletions(-)

diff --git a/pkg/dashboard/assets/js/charts.js b/pkg/dashboard/assets/js/charts.js
index 49532fd4..34333426 100644
--- a/pkg/dashboard/assets/js/charts.js
+++ b/pkg/dashboard/assets/js/charts.js
@@ -1,14 +1,19 @@
 $(function () {
+  var data = [
+    polarisSummary.Successes,
+    polarisSummary.Warnings,
+    polarisSummary.Dangers,
+  ];
+  var sum = data.reduce(function(total, cur) { return total + cur }, 0.0)
+  if (sum === 0.0) {
+    data = [1, 0, 0];
+  }
   var clusterChart = new Chart("clusterScoreChart", {
     type: 'doughnut',
     data: {
       labels: ["Passing", "Warning", "Error"],
       datasets: [{
-        data: [
-          polarisSummary.Successes,
-          polarisSummary.Warnings,
-          polarisSummary.Dangers,
-        ],
+        data: data,
         backgroundColor: ['#8BD2DC', '#f26c21', '#a11f4c'],
       }]
     },
diff --git a/pkg/dashboard/helpers.go b/pkg/dashboard/helpers.go
index 84779010..f5db055d 100644
--- a/pkg/dashboard/helpers.go
+++ b/pkg/dashboard/helpers.go
@@ -25,7 +25,7 @@ import (
 func getWarningWidth(counts validator.CountSummary, fullWidth int) uint {
 	denom := counts.Successes + counts.Warnings + counts.Dangers
 	if denom == 0 {
-		return uint(0)
+		return uint(1 * float64(fullWidth))
 	}
 	res := float64(counts.Successes+counts.Warnings) / float64(denom) * float64(fullWidth)
 	return uint(res)
@@ -34,7 +34,7 @@ func getWarningWidth(counts validator.CountSummary, fullWidth int) uint {
 func getSuccessWidth(counts validator.CountSummary, fullWidth int) uint {
 	denom := counts.Successes + counts.Warnings + counts.Dangers
 	if denom == 0 {
-		return uint(0)
+		return uint(1 * float64(fullWidth))
 	}
 	res := float64(counts.Successes) / float64(denom) * float64(fullWidth)
 	return uint(res)
diff --git a/pkg/dashboard/templates/dashboard.gohtml b/pkg/dashboard/templates/dashboard.gohtml
index a5eea79b..83963d8e 100644
--- a/pkg/dashboard/templates/dashboard.gohtml
+++ b/pkg/dashboard/templates/dashboard.gohtml
@@ -153,7 +153,11 @@
               <strong>{{ .Name }}</strong></div>
 
               <div class="result-messages expandable-content">
-                <h4>Controller Spec:</h4>
+                <h4>Controller Spec:
+                  {{ if eq 0 (len .Results.GetSortedResults) }}
+                    <i>no checks applied</i>
+                  {{ end }}
+                </h4>
                 <ul class="message-list">
                   {{ range $message := .Results.GetSortedResults }}
                     <li class="{{ getResultClass . }}">
@@ -168,7 +172,11 @@
               </div>
 
               <div class="result-messages expandable-content">
-                <h4>Pod Spec:</h4>
+                <h4>Pod Spec:
+                  {{ if eq 0 (len .PodResult.Results.GetSortedResults) }}
+                    <i>no checks applied</i>
+                  {{ end }}
+                </h4>
                 <ul class="message-list">
                   {{ range $message := .PodResult.Results.GetSortedResults }}
                     <li class="{{ getResultClass . }}">
@@ -184,7 +192,11 @@
 
               {{ range .PodResult.ContainerResults }}
                 <div class="result-messages expandable-content">
-                  <h4>Container: {{ .Name }}</h4>
+                  <h4>Container {{ .Name }}:
+                    {{ if eq 0 (len .Results.GetSortedResults) }}
+                      <i>no checks applied</i>
+                    {{ end }}
+                  </h4>
                   <ul class="message-list">
                     {{ range $message := .Results.GetSortedResults }}
                       <li class="{{ getResultClass . }}">
diff --git a/pkg/validator/summary.go b/pkg/validator/summary.go
index 86d3ef4a..b4e6b221 100644
--- a/pkg/validator/summary.go
+++ b/pkg/validator/summary.go
@@ -11,7 +11,7 @@ import (
 type CountSummary struct {
 	Successes uint
 	Warnings  uint
-	Dangers    uint
+	Dangers   uint
 }
 
 // CountSummaryByCategory is a map from category to CountSummary
@@ -21,7 +21,7 @@ type CountSummaryByCategory map[string]CountSummary
 func (cs CountSummary) GetScore() uint {
 	total := (cs.Successes * 2) + cs.Warnings + (cs.Dangers * 2)
 	if total == 0 {
-		return 0 // Prevent divide by 0.
+		return uint(100)
 	}
 	return uint((float64(cs.Successes*2) / float64(total)) * 100)
 }