mirror of
https://github.com/stefanprodan/podinfo.git
synced 2026-08-21 13:16:41 +00:00
Stefan Prodan
302c092cce
HttpServerTimeout is a time.Duration (nanoseconds); the default-delay branch scaled it by time.Second again, overflowing int64 to a negative value and passing it to rand.Intn, which panics. The bare /chunked route (no wait param) hit this on every request. Convert the timeout to whole seconds in a guarded helper that keeps rand.Intn's argument positive, and add a regression test.
53 lines
1.4 KiB
Go
53 lines
1.4 KiB
Go
package http
|
|
|
|
import (
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"regexp"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
func TestChunkedHandler(t *testing.T) {
|
|
req, err := http.NewRequest("GET", "/chunked/0", nil)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
rr := httptest.NewRecorder()
|
|
srv := NewMockServer()
|
|
|
|
srv.router.HandleFunc("/chunked/{wait}", srv.chunkedHandler)
|
|
srv.router.ServeHTTP(rr, req)
|
|
|
|
// Check the status code is what we expect.
|
|
if status := rr.Code; status != http.StatusOK {
|
|
t.Errorf("handler returned wrong status code: got %v want %v",
|
|
status, http.StatusOK)
|
|
}
|
|
|
|
// Check the response body is what we expect.
|
|
expected := ".*delay.*0.*"
|
|
r := regexp.MustCompile(expected)
|
|
if !r.MatchString(rr.Body.String()) {
|
|
t.Fatalf("handler returned unexpected body:\ngot \n%v \nwant \n%s",
|
|
rr.Body.String(), expected)
|
|
}
|
|
}
|
|
|
|
// TestRandomDelaySeconds covers the default-delay branch taken by the bare
|
|
// /chunked route (no {wait} value). This used to panic because the
|
|
// duration-to-seconds math overflowed int64 and handed rand.Intn a negative
|
|
// argument. Every timeout must yield a valid delay in [10, max] without panicking.
|
|
func TestRandomDelaySeconds(t *testing.T) {
|
|
timeouts := []time.Duration{30 * time.Second, 12 * time.Second, time.Second, 0, -1}
|
|
for _, timeout := range timeouts {
|
|
for range 100 {
|
|
d := randomDelaySeconds(timeout)
|
|
if d < 10 {
|
|
t.Fatalf("timeout %s: delay %d below floor of 10", timeout, d)
|
|
}
|
|
}
|
|
}
|
|
}
|