From e24c83525a2a928ba2c79698c8eda679c2bc7423 Mon Sep 17 00:00:00 2001 From: Stefan Prodan Date: Mon, 7 May 2018 11:03:02 +0300 Subject: [PATCH] Use http_request_duration_seconds for RED metrics --- docs/3-monitoring.md | 10 +++++----- pkg/server/instrument.go | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/3-monitoring.md b/docs/3-monitoring.md index e9135bb..3a774a6 100644 --- a/docs/3-monitoring.md +++ b/docs/3-monitoring.md @@ -7,26 +7,26 @@ Prometheus query examples of key metrics to measure and alert upon. **Request Rate** - the number of requests per second by instance ``` -sum(irate(http_requests_count{job=~".*podinfo"}[1m])) by (instance) +sum(irate(http_request_duration_seconds_count{job=~".*podinfo"}[1m])) by (instance) ``` **Request Errors** - the number of failed requests per second by URL path ``` -sum(irate(http_requests_count{job=~".*podinfo", status=~"5.."}[1m])) by (path) +sum(irate(http_request_duration_seconds_count{job=~".*podinfo", status=~"5.."}[1m])) by (path) ``` **Request Duration** - average duration of each request over 10 minutes ``` -sum(rate(http_requests_sum{job=~".*podinfo"}[10m])) / -sum(rate(http_requests_count{job=~".*podinfo"}[10m])) +sum(rate(http_request_duration_seconds_sum{job=~".*podinfo"}[10m])) / +sum(rate(http_request_duration_seconds_count{job=~".*podinfo"}[10m])) ``` **Request Latency** - 99th percentile request latency over 10 minutes ``` -histogram_quantile(0.99, sum(rate(http_requests_bucket{job=~".*podinfo"}[10m])) by (le)) +histogram_quantile(0.99, sum(rate(http_request_duration_seconds_bucket{job=~".*podinfo"}[10m])) by (le)) ``` **Goroutines Rate** - the number of running goroutines over 10 minutes diff --git a/pkg/server/instrument.go b/pkg/server/instrument.go index c6f2a0a..12af390 100644 --- a/pkg/server/instrument.go +++ b/pkg/server/instrument.go @@ -22,7 +22,7 @@ func NewInstrument() *Instrument { // used for monitoring and alerting (RED method) histogram := prometheus.NewHistogramVec(prometheus.HistogramOpts{ Subsystem: "http", - Name: "requests", + Name: "request_duration_seconds", Help: "Seconds spent serving HTTP requests.", Buckets: prometheus.DefBuckets, }, []string{"method", "path", "status"})