github/pocket-id
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2026-08-24 21:17:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: explicitly require JSON for request bodies

Browse Source
This commit is contained in:
Elias Schneider
2026-08-03 22:58:08 +02:00
parent 69d55ada6c
commit 1238bf0f37
2 changed files with 72 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/internal/httpserver/binding_test.go
+34
View File
@@ -63,6 +63,40 @@ func TestBindJSONNormalizesTaggedFieldsRecursively(t *testing.T) {
require.Equal(t, norm.NFC.String("Résumé"), input.Items[0].Label)
}
func TestBindJSONRejectsFormCompatibleContentTypes(t *testing.T) {
for _, contentType := range []string{"text/plain", "application/x-www-form-urlencoded", "multipart/form-data; boundary=test"} {
t.Run(contentType, func(t *testing.T) {
gin.SetMode(gin.TestMode)
c, _ := gin.CreateTestContext(httptest.NewRecorder())
c.Request = httptest.NewRequestWithContext(t.Context(), http.MethodPost, "/", strings.NewReader(`{"name":"admin"}`))
c.Request.Header.Set("Content-Type", contentType)
var input struct {
Name string `json:"name"`
}
err := BindJSON(c, &input)
require.True(t, apperror.IsCode(err, apperror.CodeInvalidRequestBody))
require.Empty(t, input.Name)
})
}
}
func TestBindJSONAcceptsStructuredJSONContentType(t *testing.T) {
gin.SetMode(gin.TestMode)
c, _ := gin.CreateTestContext(httptest.NewRecorder())
c.Request = httptest.NewRequestWithContext(t.Context(), http.MethodPost, "/", strings.NewReader(`{"name":"admin"}`))
c.Request.Header.Set("Content-Type", "application/scim+json")
var input struct {
Name string `json:"name"`
}
err := BindJSON(c, &input)
require.NoError(t, err)
require.Equal(t, "admin", input.Name)
}
func TestFormFileClassifiesMissingField(t *testing.T) {
gin.SetMode(gin.TestMode)
c, _ := gin.CreateTestContext(httptest.NewRecorder())