From 83621acd1aa35b71d528043bbcf2bb2ba31abcfc Mon Sep 17 00:00:00 2001 From: Abin Simon Date: Tue, 14 Jun 2022 10:46:28 +0530 Subject: [PATCH] Disable caching in casbin Until we implement https://casbin.org/docs/en/dispatchers#distributedenforcer it is better to disable caching as it might cause issues otherwise when running multiple instances of the base. Also, now that we do not have caching, we don't have the need to invalidate the cache after update operations. --- pkg/service/authz.go | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/pkg/service/authz.go b/pkg/service/authz.go index f8a121d..a5ae081 100644 --- a/pkg/service/authz.go +++ b/pkg/service/authz.go @@ -33,7 +33,7 @@ type authzService struct { } func NewAuthzService(db *bun.DB, en *casbin.CachedEnforcer) AuthzService { - // en.EnableCache(false) // disables caching in casbin + en.EnableCache(false) // disables caching in casbin return &authzService{ db: db, enforcer: en, @@ -258,7 +258,7 @@ func (s *authzService) CreatePolicies(ctx context.Context, p *authzpbv1.Policies if err != nil { return nil, status.Errorf(codes.Internal, err.Error()) } - s.enforcer.InvalidateCache() + // s.enforcer.InvalidateCache() return &authzpbv1.BoolReply{Res: res}, nil } @@ -268,7 +268,7 @@ func (s *authzService) DeletePolicies(ctx context.Context, p *authzpbv1.Policy) if err != nil { return nil, status.Errorf(codes.Internal, err.Error()) } - s.enforcer.InvalidateCache() + // s.enforcer.InvalidateCache() return &authzpbv1.BoolReply{Res: res}, nil } @@ -292,7 +292,7 @@ func (s *authzService) CreateUserGroups(ctx context.Context, p *authzpbv1.UserGr return nil, status.Errorf(codes.Internal, err.Error()) } - s.enforcer.InvalidateCache() + // s.enforcer.InvalidateCache() return &authzpbv1.BoolReply{Res: res}, nil } @@ -303,7 +303,7 @@ func (s *authzService) DeleteUserGroups(ctx context.Context, p *authzpbv1.UserGr return nil, status.Errorf(codes.Internal, err.Error()) } - s.enforcer.InvalidateCache() + // s.enforcer.InvalidateCache() return &authzpbv1.BoolReply{Res: res}, nil } @@ -328,7 +328,7 @@ func (s *authzService) CreateRolePermissionMappings(ctx context.Context, p *auth return nil, status.Errorf(codes.Internal, err.Error()) } - s.enforcer.InvalidateCache() + // s.enforcer.InvalidateCache() return &authzpbv1.BoolReply{Res: res}, nil } @@ -338,6 +338,6 @@ func (s *authzService) DeleteRolePermissionMappings(ctx context.Context, p *auth return nil, status.Errorf(codes.Internal, err.Error()) } - s.enforcer.InvalidateCache() + // s.enforcer.InvalidateCache() return &authzpbv1.BoolReply{Res: res}, nil }