mirror of
https://github.com/open-cluster-management-io/ocm.git
synced 2026-08-23 22:26:49 +00:00
431 lines
14 KiB
Go
431 lines
14 KiB
Go
package addon
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"k8s.io/apimachinery/pkg/api/meta"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
"k8s.io/apimachinery/pkg/runtime"
|
|
kubefake "k8s.io/client-go/kubernetes/fake"
|
|
clienttesting "k8s.io/client-go/testing"
|
|
clocktesting "k8s.io/utils/clock/testing"
|
|
|
|
addonv1beta1 "open-cluster-management.io/api/addon/v1beta1"
|
|
addonfake "open-cluster-management.io/api/client/addon/clientset/versioned/fake"
|
|
addoninformers "open-cluster-management.io/api/client/addon/informers/externalversions"
|
|
"open-cluster-management.io/sdk-go/pkg/basecontroller/factory"
|
|
"open-cluster-management.io/sdk-go/pkg/patcher"
|
|
|
|
testingcommon "open-cluster-management.io/ocm/pkg/common/testing"
|
|
testinghelpers "open-cluster-management.io/ocm/pkg/registration/helpers/testing"
|
|
)
|
|
|
|
var now = time.Now()
|
|
|
|
func TestQueueKeyFunc(t *testing.T) {
|
|
cases := []struct {
|
|
name string
|
|
addOns []runtime.Object
|
|
lease runtime.Object
|
|
expectedQueueKey string
|
|
}{
|
|
{
|
|
name: "no addons",
|
|
addOns: []runtime.Object{},
|
|
lease: testinghelpers.NewAddOnLease("test", "test", time.Now()),
|
|
expectedQueueKey: "",
|
|
},
|
|
{
|
|
name: "no install namespace",
|
|
addOns: []runtime.Object{&addonv1beta1.ManagedClusterAddOn{
|
|
ObjectMeta: metav1.ObjectMeta{Namespace: testinghelpers.TestManagedClusterName, Name: "test"},
|
|
}},
|
|
lease: testinghelpers.NewAddOnLease("test", "test", time.Now()),
|
|
expectedQueueKey: "",
|
|
},
|
|
{
|
|
name: "different install namespace",
|
|
addOns: []runtime.Object{&addonv1beta1.ManagedClusterAddOn{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: testinghelpers.TestManagedClusterName,
|
|
Name: "test",
|
|
},
|
|
Spec: addonv1beta1.ManagedClusterAddOnSpec{},
|
|
Status: addonv1beta1.ManagedClusterAddOnStatus{
|
|
Namespace: "other",
|
|
},
|
|
}},
|
|
lease: testinghelpers.NewAddOnLease("test", "test", time.Now()),
|
|
expectedQueueKey: "",
|
|
},
|
|
{
|
|
name: "an addon lease",
|
|
addOns: []runtime.Object{&addonv1beta1.ManagedClusterAddOn{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: testinghelpers.TestManagedClusterName,
|
|
Name: "test",
|
|
},
|
|
Spec: addonv1beta1.ManagedClusterAddOnSpec{},
|
|
Status: addonv1beta1.ManagedClusterAddOnStatus{
|
|
Namespace: "test",
|
|
},
|
|
}},
|
|
lease: testinghelpers.NewAddOnLease("test", "test", time.Now()),
|
|
expectedQueueKey: "test/test",
|
|
},
|
|
}
|
|
|
|
for _, c := range cases {
|
|
t.Run(c.name, func(t *testing.T) {
|
|
addOnClient := addonfake.NewSimpleClientset(c.addOns...)
|
|
addOnInformerFactory := addoninformers.NewSharedInformerFactory(addOnClient, time.Minute*10)
|
|
addOnStore := addOnInformerFactory.Addon().V1beta1().ManagedClusterAddOns().Informer().GetStore()
|
|
for _, addOn := range c.addOns {
|
|
if err := addOnStore.Add(addOn); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
ctrl := &managedClusterAddOnLeaseController{
|
|
clusterName: testinghelpers.TestManagedClusterName,
|
|
addOnLister: addOnInformerFactory.Addon().V1beta1().ManagedClusterAddOns().Lister(),
|
|
}
|
|
actualQueueKey := ctrl.queueKeyFunc(c.lease)
|
|
if actualQueueKey != c.expectedQueueKey {
|
|
t.Errorf("expected queue key %q, but got %q", c.expectedQueueKey, actualQueueKey)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestSync(t *testing.T) {
|
|
cases := []struct {
|
|
name string
|
|
queueKey string
|
|
addOns []runtime.Object
|
|
hubLeases []runtime.Object
|
|
managementLeases []runtime.Object
|
|
spokeLeases []runtime.Object
|
|
validateActions func(t *testing.T, ctx *testingcommon.FakeSyncContext, actions []clienttesting.Action)
|
|
}{
|
|
{
|
|
name: "bad queue key",
|
|
queueKey: "test/test/test",
|
|
addOns: []runtime.Object{},
|
|
hubLeases: []runtime.Object{},
|
|
spokeLeases: []runtime.Object{},
|
|
validateActions: func(t *testing.T, ctx *testingcommon.FakeSyncContext, actions []clienttesting.Action) {
|
|
testingcommon.AssertNoActions(t, actions)
|
|
},
|
|
},
|
|
{
|
|
name: "no addons",
|
|
queueKey: "test/test",
|
|
addOns: []runtime.Object{},
|
|
spokeLeases: []runtime.Object{},
|
|
hubLeases: []runtime.Object{},
|
|
validateActions: func(t *testing.T, ctx *testingcommon.FakeSyncContext, actions []clienttesting.Action) {
|
|
testingcommon.AssertNoActions(t, actions)
|
|
},
|
|
},
|
|
{
|
|
name: "no addon leases",
|
|
queueKey: "test/test",
|
|
addOns: []runtime.Object{&addonv1beta1.ManagedClusterAddOn{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: testinghelpers.TestManagedClusterName,
|
|
Name: "test",
|
|
},
|
|
Spec: addonv1beta1.ManagedClusterAddOnSpec{},
|
|
Status: addonv1beta1.ManagedClusterAddOnStatus{
|
|
Namespace: "test",
|
|
},
|
|
}},
|
|
hubLeases: []runtime.Object{},
|
|
spokeLeases: []runtime.Object{},
|
|
validateActions: func(t *testing.T, ctx *testingcommon.FakeSyncContext, actions []clienttesting.Action) {
|
|
testingcommon.AssertActions(t, actions, "patch")
|
|
patch := actions[0].(clienttesting.PatchAction).GetPatch()
|
|
addOn := &addonv1beta1.ManagedClusterAddOn{}
|
|
err := json.Unmarshal(patch, addOn)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
addOnCond := meta.FindStatusCondition(addOn.Status.Conditions, "Available")
|
|
if addOnCond == nil {
|
|
t.Errorf("expected addon available condition, but failed")
|
|
return
|
|
}
|
|
if addOnCond.Status != metav1.ConditionUnknown {
|
|
t.Errorf("expected addon available condition is unknown, but failed")
|
|
}
|
|
},
|
|
},
|
|
{
|
|
name: "addon stop to update its lease",
|
|
queueKey: "test/test",
|
|
addOns: []runtime.Object{&addonv1beta1.ManagedClusterAddOn{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: testinghelpers.TestManagedClusterName,
|
|
Name: "test",
|
|
},
|
|
Spec: addonv1beta1.ManagedClusterAddOnSpec{},
|
|
Status: addonv1beta1.ManagedClusterAddOnStatus{
|
|
Namespace: "test",
|
|
},
|
|
}},
|
|
hubLeases: []runtime.Object{},
|
|
spokeLeases: []runtime.Object{
|
|
testinghelpers.NewAddOnLease("test", "test", now.Add(-5*time.Minute)),
|
|
},
|
|
validateActions: func(t *testing.T, ctx *testingcommon.FakeSyncContext, actions []clienttesting.Action) {
|
|
testingcommon.AssertActions(t, actions, "patch")
|
|
patch := actions[0].(clienttesting.PatchAction).GetPatch()
|
|
addOn := &addonv1beta1.ManagedClusterAddOn{}
|
|
err := json.Unmarshal(patch, addOn)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
addOnCond := meta.FindStatusCondition(addOn.Status.Conditions, "Available")
|
|
if addOnCond == nil {
|
|
t.Errorf("expected addon available condition, but failed")
|
|
return
|
|
}
|
|
if addOnCond.Status != metav1.ConditionFalse {
|
|
t.Errorf("expected addon available condition is unavailable, but failed")
|
|
}
|
|
},
|
|
},
|
|
{
|
|
name: "addon update its lease constantly",
|
|
queueKey: "test/test",
|
|
addOns: []runtime.Object{&addonv1beta1.ManagedClusterAddOn{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: testinghelpers.TestManagedClusterName,
|
|
Name: "test",
|
|
},
|
|
Spec: addonv1beta1.ManagedClusterAddOnSpec{},
|
|
Status: addonv1beta1.ManagedClusterAddOnStatus{
|
|
Namespace: "test",
|
|
},
|
|
}},
|
|
hubLeases: []runtime.Object{},
|
|
spokeLeases: []runtime.Object{
|
|
testinghelpers.NewAddOnLease("test", "test", now),
|
|
},
|
|
validateActions: func(t *testing.T, ctx *testingcommon.FakeSyncContext, actions []clienttesting.Action) {
|
|
testingcommon.AssertActions(t, actions, "patch")
|
|
patch := actions[0].(clienttesting.PatchAction).GetPatch()
|
|
addOn := &addonv1beta1.ManagedClusterAddOn{}
|
|
err := json.Unmarshal(patch, addOn)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
addOnCond := meta.FindStatusCondition(addOn.Status.Conditions, "Available")
|
|
if addOnCond == nil {
|
|
t.Errorf("expected addon available condition, but failed")
|
|
return
|
|
}
|
|
if addOnCond.Status != metav1.ConditionTrue {
|
|
t.Errorf("expected addon available condition is available, but failed")
|
|
}
|
|
},
|
|
},
|
|
{
|
|
name: "addon status is not changed",
|
|
queueKey: "test/test",
|
|
addOns: []runtime.Object{&addonv1beta1.ManagedClusterAddOn{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: testinghelpers.TestManagedClusterName,
|
|
Name: "test",
|
|
},
|
|
Spec: addonv1beta1.ManagedClusterAddOnSpec{},
|
|
Status: addonv1beta1.ManagedClusterAddOnStatus{
|
|
Conditions: []metav1.Condition{
|
|
{
|
|
Type: "Available",
|
|
Status: metav1.ConditionTrue,
|
|
Reason: "ManagedClusterAddOnLeaseUpdated",
|
|
Message: "test add-on is available.",
|
|
},
|
|
},
|
|
Namespace: "test",
|
|
},
|
|
}},
|
|
hubLeases: []runtime.Object{},
|
|
spokeLeases: []runtime.Object{
|
|
testinghelpers.NewAddOnLease("test", "test", now),
|
|
},
|
|
validateActions: func(t *testing.T, ctx *testingcommon.FakeSyncContext, actions []clienttesting.Action) {
|
|
testingcommon.AssertNoActions(t, actions)
|
|
},
|
|
},
|
|
{
|
|
name: "sync all addons",
|
|
queueKey: factory.DefaultQueueKey,
|
|
addOns: []runtime.Object{
|
|
&addonv1beta1.ManagedClusterAddOn{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: testinghelpers.TestManagedClusterName,
|
|
Name: "test1",
|
|
},
|
|
Spec: addonv1beta1.ManagedClusterAddOnSpec{},
|
|
Status: addonv1beta1.ManagedClusterAddOnStatus{
|
|
Namespace: "test",
|
|
},
|
|
},
|
|
&addonv1beta1.ManagedClusterAddOn{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: testinghelpers.TestManagedClusterName,
|
|
Name: "test2",
|
|
},
|
|
},
|
|
},
|
|
hubLeases: []runtime.Object{},
|
|
spokeLeases: []runtime.Object{
|
|
testinghelpers.NewAddOnLease("test1", "test1", now.Add(-5*time.Minute)),
|
|
},
|
|
validateActions: func(t *testing.T, ctx *testingcommon.FakeSyncContext, actions []clienttesting.Action) {
|
|
if ctx.Queue().Len() != 2 {
|
|
t.Errorf("expected two addons in queue, but get %d", ctx.Queue().Len())
|
|
}
|
|
},
|
|
},
|
|
{
|
|
name: "addon update its lease constantly (on management cluster)",
|
|
queueKey: "test/test",
|
|
addOns: []runtime.Object{&addonv1beta1.ManagedClusterAddOn{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: testinghelpers.TestManagedClusterName,
|
|
Name: "test",
|
|
Annotations: map[string]string{
|
|
addonv1beta1.HostingClusterNameAnnotationKey: "cluster1",
|
|
},
|
|
},
|
|
Spec: addonv1beta1.ManagedClusterAddOnSpec{},
|
|
Status: addonv1beta1.ManagedClusterAddOnStatus{
|
|
Namespace: "test",
|
|
},
|
|
}},
|
|
hubLeases: []runtime.Object{},
|
|
managementLeases: []runtime.Object{
|
|
testinghelpers.NewAddOnLease("test", "test", now),
|
|
},
|
|
validateActions: func(t *testing.T, ctx *testingcommon.FakeSyncContext, actions []clienttesting.Action) {
|
|
testingcommon.AssertActions(t, actions, "patch")
|
|
patch := actions[0].(clienttesting.PatchAction).GetPatch()
|
|
addOn := &addonv1beta1.ManagedClusterAddOn{}
|
|
err := json.Unmarshal(patch, addOn)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
addOnCond := meta.FindStatusCondition(addOn.Status.Conditions, "Available")
|
|
if addOnCond == nil {
|
|
t.Errorf("expected addon available condition, but failed")
|
|
return
|
|
}
|
|
if addOnCond.Status != metav1.ConditionTrue {
|
|
t.Errorf("expected addon available condition is available, but failed")
|
|
}
|
|
},
|
|
},
|
|
{
|
|
name: "no addon lease on management cluster names the hosting cluster in the message",
|
|
queueKey: "test/test",
|
|
addOns: []runtime.Object{&addonv1beta1.ManagedClusterAddOn{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: testinghelpers.TestManagedClusterName,
|
|
Name: "test",
|
|
Annotations: map[string]string{
|
|
addonv1beta1.HostingClusterNameAnnotationKey: "cluster1",
|
|
},
|
|
},
|
|
Spec: addonv1beta1.ManagedClusterAddOnSpec{},
|
|
Status: addonv1beta1.ManagedClusterAddOnStatus{
|
|
Namespace: "test",
|
|
},
|
|
}},
|
|
hubLeases: []runtime.Object{},
|
|
managementLeases: []runtime.Object{},
|
|
validateActions: func(t *testing.T, ctx *testingcommon.FakeSyncContext, actions []clienttesting.Action) {
|
|
testingcommon.AssertActions(t, actions, "patch")
|
|
patch := actions[0].(clienttesting.PatchAction).GetPatch()
|
|
addOn := &addonv1beta1.ManagedClusterAddOn{}
|
|
err := json.Unmarshal(patch, addOn)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
addOnCond := meta.FindStatusCondition(addOn.Status.Conditions, "Available")
|
|
if addOnCond == nil {
|
|
t.Errorf("expected addon available condition, but failed")
|
|
return
|
|
}
|
|
if addOnCond.Status != metav1.ConditionUnknown {
|
|
t.Errorf("expected addon available condition is unknown, but failed")
|
|
}
|
|
if !strings.Contains(addOnCond.Message, "cluster1") {
|
|
t.Errorf("expected message to name the declared hosting cluster, got: %s", addOnCond.Message)
|
|
}
|
|
},
|
|
},
|
|
{
|
|
name: "addon has customized health check",
|
|
queueKey: "test/test",
|
|
addOns: []runtime.Object{&addonv1beta1.ManagedClusterAddOn{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: testinghelpers.TestManagedClusterName,
|
|
Name: "test",
|
|
},
|
|
Status: addonv1beta1.ManagedClusterAddOnStatus{
|
|
HealthCheck: addonv1beta1.HealthCheck{
|
|
Mode: addonv1beta1.HealthCheckModeCustomized,
|
|
},
|
|
},
|
|
}},
|
|
hubLeases: []runtime.Object{},
|
|
spokeLeases: []runtime.Object{},
|
|
validateActions: func(t *testing.T, ctx *testingcommon.FakeSyncContext, actions []clienttesting.Action) {
|
|
testingcommon.AssertNoActions(t, actions)
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, c := range cases {
|
|
t.Run(c.name, func(t *testing.T) {
|
|
addOnClient := addonfake.NewSimpleClientset(c.addOns...)
|
|
addOnInformerFactory := addoninformers.NewSharedInformerFactory(addOnClient, time.Minute*10)
|
|
addOnStore := addOnInformerFactory.Addon().V1beta1().ManagedClusterAddOns().Informer().GetStore()
|
|
for _, addOn := range c.addOns {
|
|
if err := addOnStore.Add(addOn); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
managementLeaseClient := kubefake.NewClientset(c.managementLeases...)
|
|
spokeLeaseClient := kubefake.NewClientset(c.spokeLeases...)
|
|
|
|
ctrl := &managedClusterAddOnLeaseController{
|
|
clusterName: testinghelpers.TestManagedClusterName,
|
|
clock: clocktesting.NewFakeClock(time.Now()),
|
|
patcher: patcher.NewPatcher[
|
|
*addonv1beta1.ManagedClusterAddOn, addonv1beta1.ManagedClusterAddOnSpec, addonv1beta1.ManagedClusterAddOnStatus](
|
|
addOnClient.AddonV1beta1().ManagedClusterAddOns(testinghelpers.TestManagedClusterName)),
|
|
addOnLister: addOnInformerFactory.Addon().V1beta1().ManagedClusterAddOns().Lister(),
|
|
managementLeaseClient: managementLeaseClient.CoordinationV1(),
|
|
spokeLeaseClient: spokeLeaseClient.CoordinationV1(),
|
|
}
|
|
syncCtx := testingcommon.NewFakeSyncContext(t, c.queueKey)
|
|
syncErr := ctrl.sync(context.TODO(), syncCtx, c.queueKey)
|
|
if syncErr != nil {
|
|
t.Errorf("unexpected err: %v", syncErr)
|
|
}
|
|
|
|
c.validateActions(t, syncCtx, addOnClient.Actions())
|
|
})
|
|
}
|
|
}
|