195 Commits

Include renames

Author	SHA1	Message	Date
Aman Gupta	f03cafff7c	✨ feat: add NetworkPolicies for open-cluster-management-hub namespace (#1634) ... Signed-off-by: Aman Gupta <amangta.gupta@gmail.com>	2026-08-03 08:16:39 +00:00
mihirleleandClaude Opus 4.6	374cc31e22	✨ feat: add NetworkPolicies for open-cluster-management-agent namespace (#1627) ... * feat: add NetworkPolicies for open-cluster-management-agent namespace Ship 4 NetworkPolicy manifests with the klusterlet operator to restrict ingress/egress in the agent namespace, meeting CIS Kube benchmark 5.3.2 requirements. Policies added: - default-deny-all: baseline deny for all ingress/egress - allow-dns-and-api: DNS egress (OpenShift/kube-dns) + ports-only API server egress (TCP 443/6443) - klusterlet: operator egress to intra-namespace, addon namespace, and kubernetes.default.svc - klusterlet-agent: agent egress to kubernetes.default.svc, hub webhooks, and intra-namespace Also adds: - RBAC: networking.k8s.io/networkpolicies permissions in klusterlet ClusterRole - Cleanup: *networkingv1.NetworkPolicy case in CleanUpStaticObject and GenerateRelatedResource Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mihir Lele <mlele@redhat.com> * feat: add NetworkPolicies feature gate and fix ingress rules - Add NetworkPolicies feature gate (disabled by default) following the existing AboutAPIEnabled/ClusterProperty pattern - Filter operator-internal feature gates before ConvertToFeatureGateFlags to avoid invalid agent CLI flags and ValidFeatureGates condition issues - Conditionally apply NP manifests in both reconcile() and clean() based on the feature gate - Fix missing intra-namespace ingress rules in klusterlet and klusterlet-agent NetworkPolicies (CodeRabbit review feedback) - Revert test counts to pre-NP values and add TestSyncDeployWithNetworkPolicies for the feature-enabled path Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mihir Lele <mlele@redhat.com> * fix: address CodeRabbit nitpicks - import grouping and defensive slice copy - Move featuregate import to correct alphabetical position in its group - Use defensive slice copy (append into new slice) instead of direct assignment from package-level var before appending Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mihir Lele <mlele@redhat.com> * fix: update OLM CSV with NetworkPolicy RBAC permissions The ClusterServiceVersion file needs to include the networking.k8s.io networkpolicies RBAC rules added to the klusterlet ClusterRole. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mihir Lele <mlele@redhat.com> * test: enable NetworkPolicies feature gate in integration and e2e tests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mihir Lele <mlele@redhat.com> * test: update relatedResources counts for NetworkPolicy resources Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mihir Lele <mlele@redhat.com> * fix: update expected registration deployment args count for RegistrationConfiguration defaults RegistrationConfiguration triggers kubebuilder defaults (KubeAPIQPS=50, KubeAPIBurst=100), adding --kube-api-qps and --kube-api-burst args. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mihir Lele <mlele@redhat.com> * fix: clarify relatedResources count comment arithmetic Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mihir Lele <mlele@redhat.com> --------- Signed-off-by: Mihir Lele <mlele@redhat.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>	2026-07-24 01:30:13 +00:00
Roke JungandCursor	3da28e4bf7	🐛 fix(placement): correct debug permission checks and reject bad methods (#1623) ... Map GET/POST debug requests to get/create SAR verbs and return 403 on denial. Reject unsupported HTTP methods with 405 instead of treating them as GET. Update the GET RBAC integration test Role to grant get. Also free unused disk on e2e runners before image builds to reduce "no space left on device" flakes. Fixes open-cluster-management-io/ocm#1622 Signed-off-by: Roke Jung <roke@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>	2026-07-20 07:27:40 +00:00
Mike Ng	0ab9a37d10	AddOnTemplate v1beta1 implementation (#1621) ... Signed-off-by: Mike Ng <ming@redhat.com>	2026-07-15 00:36:54 +00:00
Tesshu Flower	8a96e8e0aa	🐛 fix: preserve config reference ordering in cmainstallprogression controller (#1610) ... * fix: preserve config reference ordering in cmainstallprogression controller Replace sets.Set[ConfigReferent] with []ConfigReferent in setInstallProgression and overrideConfigMapByAddOnConfigs. Iterating a set (Go map) produces nondeterministic ordering when a placement has multiple configs of the same GVK, causing spurious status patches on every reconcile and unstable config ordering downstream to MCA status. The fix preserves the insertion order from the CMA spec's placement configs, matching the pattern already used by overrideConfigMapByAddOnConfigs in pkg/addon/controllers/addonconfiguration/graph.go. Deduplication is maintained via a containsConfigReferent helper (linear scan), consistent with the addonconfiguration controller's containsConfig method. Fixes: https://github.com/open-cluster-management-io/ocm/issues/1609 Signed-off-by: Tesshu Flower <tflower@redhat.com> * test: add integration test for multi-same-GVK config reference ordering Adds an integration test that verifies the full pipeline when a CMA placement has two configs of the same GVK. Asserts that both CMA status InstallProgressions and MCA status ConfigReferences reflect the configs in the order specified in the CMA placement spec (config-first before config-second), not in a nondeterministic order. This exercises the full controller chain: - cmainstallprogression controller: CMA spec -> CMA status - addonconfiguration controller: CMA status -> MCA status Signed-off-by: Tesshu Flower <tflower@redhat.com> --------- Signed-off-by: Tesshu Flower <tflower@redhat.com>	2026-07-03 01:04:13 +00:00
Tesshu FlowerandClaude Sonnet 4.5	dc1278427f	🌱 add v1beta1 integration tests for addon API - preserve v1alpha1 tests (#1546) ... * test: add v1beta1 integration tests for addon API Add comprehensive v1beta1 test coverage for addon API following alpha/beta split pattern. Tests for both v1alpha1 and v1beta1 run in parallel with API conversion handled automatically by the test environment. Migrated tests (11 test suites): - addon_manager_install: split into _alpha + beta versions - addon_configs: split into _alpha + beta versions - addon_manager_upgrade: split into _alpha + beta versions - agent_deploy: split into _alpha + beta versions - token_infrastructure: split into _alpha + beta versions - addon_manager_template: renamed to _alpha only (AddOnTemplate API removed in v1beta1) Changes: - suite_test.go: renamed client import to support both API versions - assertion_test.go: added alpha/beta config specs and beta helper functions v1beta1 API compatibility fixes: - Removed deprecated ConfigReferent field from ConfigReference structs - Removed InstallNamespace from ManagedClusterAddOnSpec - Updated RegistrationConfig to use Type field with nested KubeClient/CustomSigner configs - KubeClientDriver moved from top-level Status to RegistrationConfig.KubeClient.Driver - SignerName implicit for kubeClient type, explicit in CustomSigner for customSigner type All integration tests now have complete v1beta1 coverage. E2E tests will be migrated separately. Refs: https://github.com/open-cluster-management-io/ocm/issues/1517 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Tesshu Flower <tflower@redhat.com> * test: add ConfigReferent to v1beta1 ConfigSpecHash test expectations The v1beta1 ConfigSpecHash structure includes an inlined ConfigReferent field that specifies the config namespace and name. The controller populates this field in status, so test expectations must include it. Added ConfigReferent to all ConfigSpecHash assertions throughout the addon_manager_upgrade_test.go progressive rollout scenarios: - Initial config deployment (configDefaultName) - After upgrade to test1 config - Progressive rollout start (clusters 0-1 with configUpdateName) - Progressive rollout continuation (clusters 2-4 with configDefaultName) - After rollout completion (configUpdateName with test2) - Mixed state during test3 rollout (DesiredConfig test3, LastAppliedConfig test2) - Final state with test3 config This fixes v1beta1 integration test failures where assertions expected empty ConfigReferent but the controller correctly populated the fields. Signed-off-by: Tesshu Flower <tflower@redhat.com> * test: fix PR review issues in v1beta1 integration tests Address all issues identified in PR #1546 code review: 1. Split assertion helper functions into Alpha/Beta versions - assertClusterManagementAddOnAnnotations -> Alpha/Beta versions - assertClusterManagementAddOnConditions -> Alpha/Beta versions - assertClusterManagementAddOnNoConditions -> Alpha/Beta versions - assertManagedClusterAddOnConditions -> Alpha/Beta versions Original functions were hardcoded to v1alpha1 API but called from both v1alpha1 and v1beta1 tests. Beta versions now use v1beta1 API correctly. Note: assertClusterManagementAddOnAnnotationsBeta is a no-op since AddonLifecycleAnnotationKey was removed in v1beta1 (lifecycle is always managed by addon-manager in v1beta1). 2. Fix inverted JSON comparison in agent_deploy tests - Original bug: compared raw JSON bytes which failed due to whitespace - Tests were passing incorrectly (inverted logic + byte mismatch = false positive) - Fix: unmarshal both JSONs and compare objects semantically - Applied to both agent_deploy_alpha_test.go and agent_deploy_test.go 3. Fix clusterNames accumulation across test cases - Added clusterNames = nil reset in BeforeEach blocks - Prevents cleanup failures from stale cluster references - Applied to both addon_manager_upgrade_alpha_test.go and _test.go 4. Add bounds checking to assertion helpers - Added len(actual.Status.InstallProgressions) checks before indexing - Prevents panic during Eventually polling when status not yet populated - Applied to all 4 condition assertion functions (Alpha/Beta variants) - Returns retryable error instead of panicking, allowing Eventually to continue All 27 integration tests now pass consistently. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Tesshu Flower <tflower@redhat.com> * test: fix timing issue in ProgressDeadline assertion Fix flaky test failure in addon rollout ProgressDeadline tests where the timeout would fire ~1 second earlier than expected from the test's perspective. Root cause: The test was capturing the start timestamp AFTER updating the ManifestWork status to False. When the work status changes, the addon controller sets the ManagedClusterAddOn Progressing condition with a LastTransitionTime. The rollout SDK uses that LastTransitionTime (not when the CMA is patched with ProgressDeadline config) as the base for timeout calculation. This meant: 1. Line 365: Work status set to False → Controller sets Progressing=True with LastTransitionTime=T1 2. Line 382: Test captures start=T2 (where T2 = T1 + ~1s) 3. Line 383: CMA patched with ProgressDeadline="5s" 4. Controller calculates timeout as T1 + 5s = T2 + 4s (appears as 4s to test) Fix: Capture start BEFORE the work status update, ensuring the test's timer starts before the controller's timer, so timeouts always appear ≥5s from start. Verified by code review: - pkg/addon/controllers/addonprogressing/controller.go:213 sets Progressing condition - pkg/addon/controllers/addonconfiguration/graph.go:88,91 copies LastTransitionTime - vendor/.../sdk-go/.../rollout.go:487 uses LastTransitionTime for timeout calc Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Tesshu Flower <tflower@redhat.com> --------- Signed-off-by: Tesshu Flower <tflower@redhat.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>	2026-06-02 15:11:02 +00:00
Jian Qiu	27d0adfbf3	Move addon manager's API to v1beta1 (#1511) ... Signed-off-by: Jian Qiu <jqiu@redhat.com>	2026-05-07 14:39:58 +00:00
Jian Qiu	1bbfd69408	Fix flaky clustermanager integration test (#1493) ... Signed-off-by: Jian Qiu <gothicqiujian@gmail.com>	2026-04-21 13:41:49 +00:00
Jian Qiu	9e70cc1e21	Match the exact cluster name for csr renewal (#1476) ... Signed-off-by: Jian Qiu <jqiu@redhat.com>	2026-04-08 02:50:14 +00:00
Jian Zhu	336e5b0e4d	🌱 Add TLS profile compliance for gRPC server (#1471) ... Add TLS profile compliance to the gRPC server, completing TLS support for all hub components. The operator reads the ocm-tls-profile ConfigMap and injects --tls-min-version and --tls-cipher-suites flags into the gRPC server deployment, matching the pattern used by all other hub component deployments. Changes: - Add TLS flag injection to gRPC server deployment manifest - Wire TLS flags from common options to gRPC server via closure - Call ApplyTLSToCommand for the 8443 health server endpoint - Apply TLS overrides to the 8090 gRPC port via SDK ApplyTLSFlags - Update vendored sdk-go with CipherSuites support for gRPC server - Add unit, controller, and integration tests Assisted by Claude Signed-off-by: zhujian <jiazhu@redhat.com>	2026-04-07 01:54:22 +00:00
Qing HaoandClaude Sonnet 4.5	391ae86bff	✨ split debug controller as standalone service with proper validation (#1461) ... * feat(placement): split debug controller as standalone service with proper validation 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Qing Hao <qhao@redhat.com> * feat(placement): make placement service conditional on PlacementDebugServer feature gate Make placement debug service deployment conditional based on PlacementDebugServer feature gate to allow users to control whether to expose the debug endpoint. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Qing Hao <qhao@redhat.com> --------- Signed-off-by: Qing Hao <qhao@redhat.com> Co-authored-by: Claude <noreply@anthropic.com>	2026-04-03 02:40:24 +00:00
Jian ZhuandClaude Sonnet 4.6	fc55a5df7c	🌱 Add TLS ConfigMap watch and restart for cluster-manager operator (#1452) ... * 🌱 Add TLS profile configuration support via flags and ConfigMap Add pkg/common/tls library to support TLS profile compliance for OCM components. This enables components to receive TLS configuration via command-line flags (--tls-min-version and --tls-cipher-suites) from operators, aligning with the upstream enhancement proposal for TLS profile configuration. Key features: - TLS version and cipher suite parsing from flags or ConfigMap - ConfigMap-based TLS configuration for operator use - ConfigMap watcher for operators to detect profile changes - OpenSSL cipher name mapping to Go crypto/tls constants - Safe defaults (TLS 1.2) when no configuration provided Updated pkg/common/options/webhook.go to use TLS library instead of hardcoded TLS 1.2, enabling webhook components to respect TLS flags injected by operators. This is the foundation for OCM TLS profile compliance, keeping upstream code OpenShift-agnostic while supporting dynamic TLS configuration. Related: open-cluster-management-io/enhancements#175 Signed-off-by: Jia Zhu <jiazhu@redhat.com> Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: zhujian <jiazhu@redhat.com> * 🌱 Add TLS ConfigMap watch and restart to cluster-manager operator Implement ConfigMap-based TLS profile compliance for cluster-manager operator with hash comparison to prevent infinite restart loops. Changes: - Add TLS ConfigMap informer to watch ocm-tls-profile ConfigMap - Load current TLS config at startup and compute hash - Add event handlers that compare ConfigMap hash with current hash - Only restart if ConfigMap content actually differs from current config - Add comprehensive logging for all scenarios Scenarios handled: ✅ ConfigMap exists at startup (hash matches) → no restart ✅ ConfigMap created after startup (hash differs) → restart to apply ✅ ConfigMap updated (new hash differs) → restart to apply ✅ ConfigMap deleted (was using it) → restart to use defaults Leader election behavior: - This code only runs on the leader pod (due to controllercmd framework) - Non-leader pods wait idle until they acquire leadership - New leaders load current ConfigMap state when they start, ensuring latest config - Only the active leader monitors ConfigMap changes and restarts 🤖 Generated with Claude Code Signed-off-by: zhujian <jiazhu@redhat.com> * 🌱 Inject TLS config flags into addon-webhook deployment Implement Case 2 pattern for addon-webhook TLS configuration: cluster-manager-operator loads TLS config from ConfigMap and injects it as flags into the addon-webhook deployment. Changes: - Add AddonWebhookTLSMinVersion and AddonWebhookTLSCipherSuites fields to HubConfig - Load TLS config once when creating ClusterManagerController - Pass TLS config strings as parameters to controller - Inject --tls-min-version and --tls-cipher-suites flags into addon-webhook deployment template This approach ensures addon-webhook receives TLS configuration via flags without needing to watch the ConfigMap itself. When the ConfigMap changes, cluster-manager-operator restarts, reloads the config, and updates the deployment with new flags. 🤖 Generated with Claude Code Signed-off-by: zhujian <jiazhu@redhat.com> * 🌱 Log TLS min version and cipher suites on startup Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: zhujian <jiazhu@redhat.com> * 🌱 Move TLS library to sdk-go and update vendor dependencies Relocates TLS config and cipher helpers from pkg/common/tls into the vendored open-cluster-management.io/sdk-go/pkg/tls package, adds a generic watcher utility, and updates all import references accordingly. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: zhujian <jiazhu@redhat.com> * 🌱 Inject TLS flags into all hub component deployments Extend TLS flag injection from addon-webhook-only to all seven hub deployments managed by cluster-manager-operator: Manifests (operator → deployment args): - Rename HubConfig.AddonWebhookTLS* → TLS* so the same fields drive all deployments rather than only the addon webhook - Add {{- if .TLSMinVersion }} blocks to all six remaining deployment manifests (registration/work/placement controllers and registration/work webhook servers) Controller binaries (registration, work, placement, addon-manager): - Add --tls-min-version and --tls-cipher-suites flags to the common Options struct so the binaries accept the injected flags without failing; the flags are stored for future use Note: library-go's NewCommandWithContext uses cmd.Run (not RunE), so there is no clean programmatic hook to inject TLS into the 8443 health server without bypassing library-go's own boilerplate (signal handling, log init, profiling). Upstream library-go also has no native TLS configuration API on ControllerCommandConfig or ControllerBuilder. The 8443 health server defaults to TLS 1.2 via SetRecommendedHTTPServingInfoDefaults; configuring it further requires an upstream library-go enhancement. Webhook binaries already fully support these flags via WebhookOptions; no binary changes are needed there. Signed-off-by: Jian Zhu <zhujian@redhat.com> Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: zhujian <jiazhu@redhat.com> * 🌱 Wire --tls-min-version to library-go 8443 health server via WithServingTLSConfig Now that library-go has WithServingTLSConfig (ServingMinTLSVersion / ServingCipherSuites fields + injection in StartController before WithServer is called), wire the --tls-min-version and --tls-cipher-suites flags from Options into it. ApplyTLSToCommand installs a PersistentPreRunE hook that calls CmdConfig.WithServingTLSConfig after cobra flag parsing completes. PersistentPreRunE runs before cmd.Run, so all library-go boilerplate (signal handling, logging, profiling) is preserved - unlike the previous approach of replacing RunE which silently bypassed it. Uses go mod replace → /Users/jiazhu/go/src/github.com/openshift/library-go for local development/testing; replace directive to be removed once the library-go PR is merged and vendored. Signed-off-by: Jian Zhu <zhujian@redhat.com> Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: zhujian <jiazhu@redhat.com> * 🌱 Switch to --config file for controller 8443 TLS configuration Replace the WithServingTLSConfig approach with library-go's native --config flag mechanism: ApplyTLSToCommand now installs a PersistentPreRunE hook that: 1. Writes a minimal GenericOperatorConfig YAML to a temp file under /tmp (which is mounted as an emptyDir in all hub controller deployments, so writing is safe even with readOnlyRootFilesystem) 2. Sets --config to point at the temp file before cmd.Run executes All library-go boilerplate in cmd.Run (signal handling, log init, profiling, basicFlags.Validate) is fully preserved because PersistentPreRunE runs before Run, not replacing it. Inside StartController, Config() reads the temp file; the TLS values survive SetRecommendedHTTPServingInfoDefaults because DefaultString only sets fields that are currently empty. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: zhujian <jiazhu@redhat.com> * 🌱 Add tests for TLS profile compliance Unit tests (pkg/common/options): - TestApplyTLSToCommand: table-driven test covering all flag combinations: no flags (no-op), min-version only, cipher-suites only, both set, and --config pre-set by user (injection skipped). Unit tests (clustermanager_controller): - TestSyncDeployWithTLSConfig: verifies that when tlsMinVersion / tlsCipherSuites are set on the controller, the --tls-min-version and --tls-cipher-suites flags appear in the args of every managed hub deployment (registration, registration-webhook, placement, work-webhook). Also verifies the flags are absent when TLS config is not set. Integration tests (test/integration/operator): - "should inject tls-min-version into all hub deployments when ocm-tls-profile ConfigMap exists": creates the ocm-tls-profile ConfigMap with minTLSVersion=VersionTLS13 in the operator namespace and verifies all six hub deployments gain --tls-min-version=VersionTLS13 in their container args. Signed-off-by: Jian Zhu <zhujian@redhat.com> Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: zhujian <jiazhu@redhat.com> * 🌱 Switch TLS cipher suite format from OpenSSL to IANA Update vendored sdk-go to use IANA cipher suite names (e.g. TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) instead of OpenSSL names (e.g. ECDHE-RSA-AES128-GCM-SHA256). IANA is the canonical format used by Go's crypto/tls, the Kubernetes apiserver --tls-cipher-suites flag, and library-go's ServingInfo.CipherSuites. Using IANA names end-to-end eliminates the format mismatch that caused library-go's 8443 health server to reject cipher suite names written by ApplyTLSToCommand. The ocm-tls-profile ConfigMap now accepts IANA names only. The downstream tls-profile-sync sidecar is responsible for converting OpenShift TLSSecurityProfile (OpenSSL-style) names to IANA before writing the ConfigMap. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: zhujian <jiazhu@redhat.com> * 🌱 Fix TLS ConfigMap test: create ConfigMap before operator startup The previous test created ocm-tls-profile ConfigMap after the operator started, which triggered the watcher's hash-change detection and called os.Exit(0), killing the test process. Move the test into a dedicated Describe with BeforeEach that creates the ConfigMap before starting the operator so the watcher seeds its hash at startup and no restart is triggered. Also add hubWorkControllerDeployment to the tlsDeployments list since its manifest includes tls-min-version injection. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: zhujian <jiazhu@redhat.com> --------- Signed-off-by: Jia Zhu <jiazhu@redhat.com> Signed-off-by: zhujian <jiazhu@redhat.com> Signed-off-by: Jian Zhu <zhujian@redhat.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>	2026-04-01 06:54:30 +00:00
Zhiwei Yin	33c78679f0	Fix Progressing condition stuck at True for overlapping placements (#1456) ... Signed-off-by: Zhiwei Yin <zyin@redhat.com>	2026-03-31 02:10:32 +00:00
Jian Qiu	c367622060	🌱 Move addon api to beta in registration (#1438) ... * Move addon api to beta in registration Signed-off-by: Jian Qiu <jqiu@redhat.com> * Update conversion e2e tests Signed-off-by: Jian Qiu <jqiu@redhat.com> * Add addon v1beta1 to supported type in grpc Signed-off-by: Jian Qiu <jqiu@redhat.com> * Fix flaky e2e in addon conversion Signed-off-by: Jian Qiu <jqiu@redhat.com> * Set subject for registration configuration when it is not set Signed-off-by: Jian Qiu <jqiu@redhat.com> --------- Signed-off-by: Jian Qiu <jqiu@redhat.com>	2026-03-23 13:31:55 +00:00
Ben Perry	ee64f234aa	Remove unsupported addon webhook hosted mode config (#1450) ... Signed-off-by: Ben Perry <bhperry94@gmail.com>	2026-03-20 01:32:02 +00:00
Ben Perry	5a6bd191eb	🌱 addon webhook config (#1420) ... * Include API changes Signed-off-by: Ben Perry <bhperry94@gmail.com> * Addon webhook configuration Signed-off-by: Ben Perry <bhperry94@gmail.com> * Temp replace api with fork Signed-off-by: Ben Perry <bhperry94@gmail.com> * integration test addr Signed-off-by: Ben Perry <bhperry94@gmail.com> * Tidy Signed-off-by: Ben Perry <bhperry94@gmail.com> * Update api to main Signed-off-by: Ben Perry <bhperry94@gmail.com> --------- Signed-off-by: Ben Perry <bhperry94@gmail.com>	2026-03-17 03:41:06 +00:00
Zhiwei Yin	85d480a533	🌱 support install hosted addon via installStrategy (#1410) ... * support install hosted addon via installStrategy Signed-off-by: Zhiwei Yin <zyin@redhat.com> * sync all addon annotations to the addon from cluster Signed-off-by: Zhiwei Yin <zyin@redhat.com> * add sync annotations controller Signed-off-by: Zhiwei Yin <zyin@redhat.com> --------- Signed-off-by: Zhiwei Yin <zyin@redhat.com>	2026-03-13 03:19:24 +00:00
Wei Liu	85d92539d4	remove ce mqtt integration test (#1426) ... Signed-off-by: Wei Liu <liuweixa@redhat.com>	2026-03-12 07:43:34 +00:00
Navin Chandra Rai	a4161d75a7	✨ feature: Add new ignore field options in SSA updateStrategy (#1405) ... * Handle new ignore field options and update CRDs Signed-off-by: Navin Chandra Rai <navinchandrarai444@gmail.com> * Add integration tests and improve test coverage Signed-off-by: Navin Chandra Rai <navinchandrarai444@gmail.com> * Fix integration tests Signed-off-by: Navin Chandra Rai <navinchandrarai444@gmail.com> * Change API dependency version and use strings package for utility tasks Signed-off-by: Navin Chandra Rai <navinchandrarai444@gmail.com> * Run make update to update deploy config Signed-off-by: Navin Chandra Rai <navinchandrarai444@gmail.com> * Improve cancelled context test case Signed-off-by: Navin Chandra Rai <navinchandrarai444@gmail.com> * Fix broad container selector in tests Signed-off-by: Navin Chandra Rai <navinchandrarai444@gmail.com> * Improve error checking Signed-off-by: Navin Chandra Rai <navinchandrarai444@gmail.com> --------- Signed-off-by: Navin Chandra Rai <navinchandrarai444@gmail.com>	2026-03-10 02:16:55 +00:00
xuezhaoandClaude Opus 4.6	95f8157d28	🌱 Replace legacy envtest setup with sdk-go shared script (#1409) ... * Replace legacy envtest setup with sdk-go shared script Replace the legacy ensure-kubebuilder-tools target that manually installed setup-envtest and downloaded kubebuilder binaries with the new shared envtest-setup target from sdk-go. This uses the centralized ensure-envtest.sh script which automatically detects K8s version from go.mod and manages binary downloads. Signed-off-by: xuezhaojun <zxue@redhat.com> * Fix Job condition rules integration test for K8s 1.34 K8s 1.34 enforces stricter Job status validation requiring startTime, completionTime, and SuccessCriteriaMet condition for completed Jobs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: xuezhaojun <zxue@redhat.com> --------- Signed-off-by: xuezhaojun <zxue@redhat.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>	2026-03-05 02:05:46 +00:00
Wei Liu	7bf9a4a919	only check the hub kubeconfig secret (#1360) ... Signed-off-by: Wei Liu <liuweixa@redhat.com>	2026-01-29 06:51:51 +00:00
Jian Qiu	63d9574ca2	✨ Add watch-based feedback with dynamic informer lifecycle management (#1350) ... * Add watch-based feedback with dynamic informer lifecycle management Implements dynamic informer registration and cleanup for resources configured with watch-based status feedback (FeedbackScrapeType=Watch). This enables real-time status updates for watched resources while efficiently managing resource lifecycle. Features: - Automatically register informers for resources with FeedbackWatchType - Skip informer registration for FeedbackPollType or when not configured - Clean up informers when resources are removed from manifestwork - Clean up informers during applied manifestwork finalization - Clean up informers when feedback type changes from watch to poll Implementation: - Refactored ObjectReader to interface for better modularity - Added UnRegisterInformerFromAppliedManifestWork helper for bulk cleanup - Enhanced AvailableStatusController to conditionally register informers - Updated finalization controllers to unregister informers on cleanup - Added nil safety checks to prevent panics during cleanup Testing: - Unit tests for informer registration based on feedback type - Unit tests for bulk unregistration and nil safety - Integration test for end-to-end watch-based feedback workflow - Integration test for informer cleanup on manifestwork deletion - All existing tests updated and passing This feature improves performance by using watch-based updates for real-time status feedback while maintaining efficient resource cleanup. Signed-off-by: Jian Qiu <jqiu@redhat.com> * Fallback to get from client when informer is not synced Signed-off-by: Jian Qiu <jqiu@redhat.com> --------- Signed-off-by: Jian Qiu <jqiu@redhat.com>	2026-01-29 06:46:21 +00:00
Morven CaoandClaude	d1221c4a79	🌱 sync clusterprofile based on managedclusterset and managedclustersetbinding (#1351) ... * sync clusterprofile based on managedclusterset and managedclustersetbinding Co-authored-by: Claude <claude@anthropic.com> Signed-off-by: Morven Cao <lcao@redhat.com> * Refactor ClusterProfile controller into two separate controllers. Signed-off-by: Morven Cao <lcao@redhat.com> * address comments. Signed-off-by: Morven Cao <lcao@redhat.com> * fix lint issues. Signed-off-by: Morven Cao <lcao@redhat.com> * address comments. Signed-off-by: Morven Cao <lcao@redhat.com> * address comments. Signed-off-by: Morven Cao <lcao@redhat.com> --------- Signed-off-by: Morven Cao <lcao@redhat.com>	2026-01-28 15:37:46 +00:00
Yang Le	9d1a993e2c	✨ add token driver for addon registration (#1343) ... Signed-off-by: Yang Le <yangle@redhat.com>	2026-01-28 05:41:52 +00:00
Yang Le	f6dec25bdf	✨ add contoller to support token infrastructure (#1340) ... Signed-off-by: Yang Le <yangle@redhat.com>	2026-01-27 13:06:21 +00:00
Jian Qiu	9b010ef622	🌱 build object reader to get resource object from spoke (#1324) ... * A resource informer code to watch resources Signed-off-by: Jian Qiu <jqiu@redhat.com> * Use object reader in controller Signed-off-by: Jian Qiu <jqiu@redhat.com> --------- Signed-off-by: Jian Qiu <jqiu@redhat.com>	2026-01-23 07:32:13 +00:00
Zhiwei Yin	9a1e925112	ensure immediate requeue for transient errors when work spec is changed (#1335) ... Signed-off-by: Zhiwei Yin <zyin@redhat.com>	2026-01-19 07:57:39 +00:00
Wei Liu	d5e677414c	add options to grpc broker (#1326) ... Signed-off-by: Wei Liu <liuweixa@redhat.com>	2026-01-12 12:50:14 +00:00
Érico GR	ad89f05351	🐛 Fix work rolebinding cleanup when hubAcceptsClient is set to false (#1318) ... * Fix work rolebinding cleanup when hubAcceptsClient is set to false Signed-off-by: Erico G. Rimoli <erico.rimoli@totvs.com.br> * Adds error handling to the removeClusterRbac call within the controller synchronization function Signed-off-by: Erico G. Rimoli <erico.rimoli@totvs.com.br>	2026-01-08 13:46:13 +00:00
Anne Lauandannelau	635b0ff7e9	PlacementRollout to reflect Ready status (#1281) ... Update with success count Remove status references Add unit tests Fix unit tests Update unit tests Test fix Fix tests for lastTransitionTime Fix integration tests Signed-off-by: annelau <annelau@salesforce.com> Co-authored-by: annelau <annelau@salesforce.com>	2026-01-08 01:53:14 +00:00
Wei Liu	81eb7f54e6	disabel mqtt integration test (#1312) ... Signed-off-by: Wei Liu <liuweixa@redhat.com>	2026-01-07 06:50:05 +00:00
Anne Lauandannelau	ff9f801aa0	Fix transition time for Applied + StatusFeedbackSynced (#1282) ... Update code changes to only update observed generation without lastTransitionTime Update with simple tests Update with the latest PR changes Add unit test changes Add integration test generated by cursor Fix unit tests Signed-off-by: annelau <annelau@salesforce.com> Co-authored-by: annelau <annelau@salesforce.com>	2025-12-31 02:27:59 +00:00
Qing HaoandClaude	c516beffa6	✨ Add addon conversion webhook for v1alpha1/v1beta1 API migration (#1289) ... * Add addon conversion webhook for v1alpha1/v1beta1 API migration 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Qing Hao <qhao@redhat.com> * Fix GroupVersion compatibility issues after API dependency update This commit fixes compilation and test errors introduced by updating the API dependency to use native conversion functions from PR #411. Changes include: 1. Fix GroupVersion type mismatches across the codebase: - Updated OwnerReference creation to use schema.GroupVersion - Fixed webhook scheme registration to use proper GroupVersion type - Applied fixes to addon, placement, migration, work, and registration controllers 2. Enhance addon conversion webhook: - Use native API conversion functions from addon/v1beta1/conversion.go - Fix InstallNamespace annotation key to match expected format - Add custom logic to populate deprecated ConfigReferent field in ConfigReferences - Properly preserve annotations during v1alpha1 <-> v1beta1 conversion 3. Remove duplicate conversion code: - Deleted pkg/addon/webhook/conversion/ directory (~500 lines) - Now using native conversion functions from the API repository 4. Patch vendored addon-framework: - Fixed GroupVersion errors in agentdeploy utils All unit tests pass successfully (97 packages, 0 failures). Signed-off-by: Qing Hao <qhao@redhat.com> --------- Signed-off-by: Qing Hao <qhao@redhat.com> Co-authored-by: Claude <noreply@anthropic.com>	2025-12-24 08:26:35 +00:00
Jian QiuandClaude Sonnet 4.5	78daf0d2ae	fix: skip GC for ManifestWorks managed by ManifestWorkReplicaSet (#1299) ... Skip garbage collection for ManifestWorks that have the ManifestWorkReplicaSet controller label, as these should be managed exclusively by the ManifestWorkReplicaSet controller. Changes: - Fix logic bug in controller to properly check for ReplicaSet label - Add unit tests for label-based GC skip behavior - Add integration test to verify GC skip for ReplicaSet-managed works 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Jian Qiu <jqiu@redhat.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>	2025-12-16 08:56:07 +00:00
Jian Qiu	99265f6113	Refactor to contextual logging (#1283) ... Signed-off-by: Jian Qiu <jqiu@redhat.com>	2025-12-08 08:14:30 +00:00
Jian Qiu	33310619d9	🌱 use SDK basecontroller for better logging. (#1269) ... * Use basecontroller in sdk-go instead for better logging Signed-off-by: Jian Qiu <jqiu@redhat.com> * Rename to fakeSyncContext Signed-off-by: Jian Qiu <jqiu@redhat.com> --------- Signed-off-by: Jian Qiu <jqiu@redhat.com>	2025-12-01 03:07:02 +00:00
Qing HaoandClaude	26edb9423a	fix: Check Applied condition before evaluating rollout status (#1243) ... 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Qing Hao <qhao@redhat.com> Co-authored-by: Claude <noreply@anthropic.com>	2025-12-01 02:14:46 +00:00
Jian Qiu	eb033993c2	🌱 Use base controller in sdk-go (#1251) ... * Use base controller in sdk-go We can leverage contextual logger in base controller. Signed-off-by: Jian Qiu <jqiu@redhat.com> * Fix integration test error Signed-off-by: Jian Qiu <jqiu@redhat.com> --------- Signed-off-by: Jian Qiu <jqiu@redhat.com>	2025-11-20 07:53:42 +00:00
Wei Liu	b928d9f2a9	update sdk-go (#1257) ... Signed-off-by: Wei Liu <liuweixa@redhat.com>	2025-11-19 04:08:16 +00:00
Qing HaoandClaude	34cd9a2549	Update rollout logic to use Progressing condition instead of WorkApplied (#1207) ... 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Qing Hao <qhao@redhat.com> Co-authored-by: Claude <noreply@anthropic.com>	2025-10-22 02:31:40 +00:00
Jian Qiu	daa9b2fa54	🐛 Avoid redundant apply and get operation in work controller (#1196) ... * Remove event after apply and add jitter when requeue Signed-off-by: Jian Qiu <jqiu@redhat.com> * Change event handler to avoid redundant reconciles Signed-off-by: Jian Qiu <jqiu@redhat.com> * Add unit tests for onAdd and onUpdate function Signed-off-by: Jian Qiu <jqiu@redhat.com> * Fix interegation test fail Signed-off-by: Jian Qiu <jqiu@redhat.com> * Set resync interval to 4-6 mins Signed-off-by: Jian Qiu <jqiu@redhat.com> --------- Signed-off-by: Jian Qiu <jqiu@redhat.com>	2025-10-17 02:04:40 +00:00
Wei Liu	f1e7905b16	using mw finalizer instead of resource finalizer (#1211) ... Signed-off-by: Wei Liu <liuweixa@redhat.com>	2025-10-16 09:30:26 +00:00
Jian QiuandClaude	eed705a038	Fix ManifestWorkReplicaSet not deleting ManifestWorks from old placement (#1206) ... When a ManifestWorkReplicaSet's placementRef was changed, the ManifestWorks created for the old placement were not deleted, causing orphaned resources. The deployReconciler only processed placements currently in the spec and never cleaned up ManifestWorks from removed placements. This commit adds cleanup logic that: - Builds a set of current placement names from the spec - Lists all ManifestWorks belonging to the ManifestWorkReplicaSet - Deletes any ManifestWorks with placement labels not in current spec Also adds comprehensive tests: - Integration test verifying placement change cleanup - Unit tests for single and multiple placement change scenarios Fixes #1203 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Jian Qiu <jqiu@redhat.com> Co-authored-by: Claude <noreply@anthropic.com>	2025-10-13 06:31:38 +00:00
Jian Qiu	2f04992d6c	✨ Deleted manifestwork when it is completed for ttl seconds. (#1158) ... * Delete manifestwork when it is completed after ttl Signed-off-by: Jian Qiu <jqiu@redhat.com> * Fix integration test Signed-off-by: Jian Qiu <jqiu@redhat.com> * Update operator and e2e tests Signed-off-by: Jian Qiu <jqiu@redhat.com> --------- Signed-off-by: Jian Qiu <jqiu@redhat.com>	2025-09-23 02:23:47 +00:00
Suvaansh	6056c04893	Adding labels to the resources created by work controller (#1176) ... Signed-off-by: suvaanshkumar <suvaanshkumar@gmail.com>	2025-09-19 02:24:46 +00:00
Zhiwei Yin	dab97728e2	support cluster import config secret (#1170) ... Signed-off-by: Zhiwei Yin <zyin@redhat.com>	2025-09-18 06:47:16 +00:00
Jian ZhuandClaude	ab41b86b8d	🐛 Use specific addon template instead of default in CSR functions (#1180) ... * Upgrade addon framework Signed-off-by: zhujian <jiazhu@redhat.com> * Use specific addon template instead of default in CSR functions - Pass real ManagedClusterAddOn to GetDesiredAddOnTemplate instead of nil - Enable per-addon template selection using addon.Status.ConfigReferences - Replace utilruntime.HandleError with explicit error returns - Update CSRConfigurationsFunc to return ([]RegistrationConfig, error) - Update CSRSignerFunc to return ([]byte, error) - Add addon parameter to CSR functions for better context - Convert runtime errors to structured logging with cluster/addon context - Update tests to verify error conditions This allows each ManagedClusterAddOn instance to use its specific template configuration rather than falling back to the ClusterManagementAddon default. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: zhujian <jiazhu@redhat.com> * Fix error assertion logic in registration tests and improve error handling - Fix inverted error assertion logic in TestTemplateCSRConfigurationsFunc and TestTemplateCSRSignFunc - Change tests to properly check if expectedErr is empty vs non-empty - When no error expected, assert err == nil; when error expected, assert err != nil and contains substring - Fix strings.Contains argument order to check if actual error contains expected substring - Add nil template checks with proper error messages in CSRSign and PermissionConfig functions - Improve logging consistency with clusterName/addonName format across CSR functions - Guard against nil pointer access by checking err == nil before calling err.Error() 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: zhujian <jiazhu@redhat.com> --------- Signed-off-by: zhujian <jiazhu@redhat.com> Co-authored-by: Claude <noreply@anthropic.com>	2025-09-12 06:42:44 +00:00
Jian Qiu	01b66a62a0	Update sdk-go so we can support executor test for cloudevent (#1182) ... Signed-off-by: Jian Qiu <jqiu@redhat.com>	2025-09-12 01:49:10 +00:00
Jeffrey	cb8854b08b	Fix flaky integration test for auto approval awsirsa (#1178) ... Signed-off-by: Jeffrey Wong <jeffreywong0417@gmail.com>	2025-09-11 03:26:53 +00:00
Jian Qiu	b4b42aa0b5	Requeue ssar check if only hubKubeConfigSecret is unauthorized (#1169) (#1164) ... Signed-off-by: Jian Qiu <jqiu@redhat.com>	2025-09-08 07:11:44 +00:00