open-cluster-management

mirror of https://github.com/open-cluster-management-io/ocm.git synced 2026-08-23 22:26:49 +00:00

Author	SHA1	Message	Date
Jian Zhu	b7168e454b	🐛 Fix concurrency bugs in executor cache (#1512 ) * 🐛 Fix concurrency bugs in executor cache - Fix DimensionCaches.remove() using RLock instead of Lock for map delete operation, which could cause concurrent map read/write panic - Fix RemoveByHash accessing len(items) without holding the lock - Fix getCacheItems returning internal map reference, allowing unsynchronized iteration after lock release; return snapshot copies - Add early return in updateSARCheckResultToCache for clarity Assisted by Claude Signed-off-by: zhujian <jiazhu@redhat.com> * 🐛 Fix wrong index in clusterRoleEnqueueFu causing missed cache refresh When a ClusterRole changes, the controller should find RoleBindings referencing it via the byClusterRole index. It was incorrectly using the byRole index, which indexes by "namespace/name" for Role refs and never matches a bare ClusterRole name. This caused executor caches to not refresh when a ClusterRole was modified, leaving revoked permissions cached as allowed for up to 10 minutes. Assisted by Claude Signed-off-by: zhujian <jiazhu@redhat.com> * 🌱 Make RemoveByHash private as it is only used internally Assisted by Claude Signed-off-by: zhujian <jiazhu@redhat.com> * Add concurrency and index-fix tests for executor cache - Add concurrent remove/get, getCacheItems, and cleanup tests to verify race-free behavior with -race detector - Add TestCacheControllerClusterRoleWithRoleBindingOnly to verify clusterRoleEnqueueFu uses byClusterRole index for RoleBindings Signed-off-by: zhujian <jiazhu@redhat.com> --------- Signed-off-by: zhujian <jiazhu@redhat.com>	2026-05-07 15:13:45 +00:00
Jian Qiu	33310619d9	🌱 use SDK basecontroller for better logging. (#1269 ) * Use basecontroller in sdk-go instead for better logging Signed-off-by: Jian Qiu <jqiu@redhat.com> * Rename to fakeSyncContext Signed-off-by: Jian Qiu <jqiu@redhat.com> --------- Signed-off-by: Jian Qiu <jqiu@redhat.com>	2025-12-01 03:07:02 +00:00
Jian Qiu	eb033993c2	🌱 Use base controller in sdk-go (#1251 ) Scorecard supply-chain security / Scorecard analysis (push) Failing after 1m11s Post / coverage (push) Failing after 37m30s Post / images (amd64, addon-manager) (push) Failing after 7m29s Post / images (amd64, placement) (push) Failing after 6m57s Post / images (amd64, registration) (push) Failing after 7m5s Post / images (amd64, registration-operator) (push) Failing after 7m5s Post / images (amd64, work) (push) Failing after 7m2s Post / images (arm64, addon-manager) (push) Failing after 7m18s Post / images (arm64, placement) (push) Failing after 7m7s Post / images (arm64, registration) (push) Failing after 7m13s Post / images (arm64, registration-operator) (push) Failing after 7m6s Post / images (arm64, work) (push) Failing after 7m2s Post / image manifest (addon-manager) (push) Has been skipped Post / image manifest (placement) (push) Has been skipped Post / image manifest (registration) (push) Has been skipped Post / image manifest (registration-operator) (push) Has been skipped Post / image manifest (work) (push) Has been skipped Post / trigger clusteradm e2e (push) Has been skipped Close stale issues and PRs / stale (push) Successful in 45s * Use base controller in sdk-go We can leverage contextual logger in base controller. Signed-off-by: Jian Qiu <jqiu@redhat.com> * Fix integration test error Signed-off-by: Jian Qiu <jqiu@redhat.com> --------- Signed-off-by: Jian Qiu <jqiu@redhat.com>	2025-11-20 07:53:42 +00:00
Jian Qiu	5528aff6d3	🌱 Add contextual logging for work agent (#1242 ) * Add contextual logging for work agent Signed-off-by: Jian Qiu <jqiu@redhat.com> * Resolve comments Signed-off-by: Jian Qiu <jqiu@redhat.com> --------- Signed-off-by: Jian Qiu <jqiu@redhat.com>	2025-11-07 05:28:13 +00:00
Jian Zhu	7332a585c0	🌱 add a verify rule for golang files import order (#177 ) * 🌱 add a verify rule for golang files import order This PR uses the [gci tool](https://github.com/daixiang0/gci) to make all go files' import section with a specific order, it will organize import with group with order： 1. standard library modules 2. 3rd party modules 3. modules in OCM org, like the `open-cluster-management.io/api` 4. current project `open-cluster-management.io/ocm` modules developers can use the `make fmt-imports` to format the import automatically and the `make verify-fmt-imports` to check for any violation. Signed-off-by: zhujian <jiazhu@redhat.com> * 🌱 format the go files import Signed-off-by: zhujian <jiazhu@redhat.com> --------- Signed-off-by: zhujian <jiazhu@redhat.com>	2023-06-12 10:23:04 -04:00
xuezhaojun	ad38b9465f	Relocate pkgs. (#146 ) Signed-off-by: xuezhaojun <zxue@redhat.com>	2023-05-29 07:20:55 -04:00