Jian Zhu
2128dfebcc
fix: handle ComponentNamespace in CI test environment ( #1387 )
...
The TestNewAgentOptions test was failing in CI because it expected
ComponentNamespace to always be "open-cluster-management-agent", but
NewAgentOptions() reads from /var/run/secrets/kubernetes.io/serviceaccount/namespace
when running in a Kubernetes pod (which exists in CI environment).
Updated the test to accept either the default value (when running locally)
or the actual pod namespace (when running in CI), while ensuring the
namespace is never empty.
🤖 Generated with [Claude Code](https://claude.com/claude-code )
Signed-off-by: zhujian <jiazhu@redhat.com >
Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com >
2026-02-12 14:14:59 +00:00
Jian Qiu
2743547b40
Reduce logging level of DumpSecret to v(4) ( #1357 )
...
It generates a lot of noises otherwise
Signed-off-by: Jian Qiu <jqiu@redhat.com >
2026-01-29 04:28:42 +00:00
Jian Qiu
33310619d9
🌱 use SDK basecontroller for better logging. ( #1269 )
...
* Use basecontroller in sdk-go instead for better logging
Signed-off-by: Jian Qiu <jqiu@redhat.com >
* Rename to fakeSyncContext
Signed-off-by: Jian Qiu <jqiu@redhat.com >
---------
Signed-off-by: Jian Qiu <jqiu@redhat.com >
2025-12-01 03:07:02 +00:00
Jian Qiu
8f8cd01b52
Update dependencies: k8s 0.34.1, controller-runtime 0.22.3, and OCM libs ( #1267 )
...
Post / coverage (push) Failing after 37m28s
Post / images (amd64, addon-manager) (push) Failing after 7m29s
Post / images (amd64, placement) (push) Failing after 7m1s
Post / images (amd64, registration) (push) Failing after 7m7s
Post / images (amd64, registration-operator) (push) Failing after 7m22s
Post / images (amd64, work) (push) Failing after 7m25s
Post / images (arm64, addon-manager) (push) Failing after 7m5s
Post / images (arm64, placement) (push) Failing after 7m4s
Post / images (arm64, registration) (push) Failing after 7m20s
Post / images (arm64, registration-operator) (push) Failing after 7m9s
Post / images (arm64, work) (push) Failing after 7m12s
Post / image manifest (addon-manager) (push) Has been skipped
Post / image manifest (placement) (push) Has been skipped
Post / image manifest (registration) (push) Has been skipped
Post / image manifest (registration-operator) (push) Has been skipped
Post / image manifest (work) (push) Has been skipped
Post / trigger clusteradm e2e (push) Has been skipped
Scorecard supply-chain security / Scorecard analysis (push) Failing after 59s
Close stale issues and PRs / stale (push) Successful in 29s
- Update k8s.io/* libraries to v0.34.1
- Update sigs.k8s.io/controller-runtime to v0.22.3
- Update open-cluster-management.io/api to 2337d27c3b7f
- Update open-cluster-management.io/sdk-go to a185f88d7b1b
- Update open-cluster-management.io/addon-framework to 1a0a9be61322
- Update openshift libraries (api, client-go, library-go) to latest commits
for structured-merge-diff v6 compatibility
- Add Recorder() method to FakeSDKSyncContext with adapter pattern to bridge
openshift/library-go and SDK event recorder interfaces
- Update vendor directory and regenerate CRDs
🤖 Generated with [Claude Code](https://claude.com/claude-code )
Signed-off-by: Jian Qiu <jqiu@redhat.com >
Co-authored-by: Claude <noreply@anthropic.com >
2025-11-26 05:56:58 +00:00
Jian Qiu
eb033993c2
🌱 Use base controller in sdk-go ( #1251 )
...
Scorecard supply-chain security / Scorecard analysis (push) Failing after 1m11s
Post / coverage (push) Failing after 37m30s
Post / images (amd64, addon-manager) (push) Failing after 7m29s
Post / images (amd64, placement) (push) Failing after 6m57s
Post / images (amd64, registration) (push) Failing after 7m5s
Post / images (amd64, registration-operator) (push) Failing after 7m5s
Post / images (amd64, work) (push) Failing after 7m2s
Post / images (arm64, addon-manager) (push) Failing after 7m18s
Post / images (arm64, placement) (push) Failing after 7m7s
Post / images (arm64, registration) (push) Failing after 7m13s
Post / images (arm64, registration-operator) (push) Failing after 7m6s
Post / images (arm64, work) (push) Failing after 7m2s
Post / image manifest (addon-manager) (push) Has been skipped
Post / image manifest (placement) (push) Has been skipped
Post / image manifest (registration) (push) Has been skipped
Post / image manifest (registration-operator) (push) Has been skipped
Post / image manifest (work) (push) Has been skipped
Post / trigger clusteradm e2e (push) Has been skipped
Close stale issues and PRs / stale (push) Successful in 45s
* Use base controller in sdk-go
We can leverage contextual logger in base controller.
Signed-off-by: Jian Qiu <jqiu@redhat.com >
* Fix integration test error
Signed-off-by: Jian Qiu <jqiu@redhat.com >
---------
Signed-off-by: Jian Qiu <jqiu@redhat.com >
2025-11-20 07:53:42 +00:00
Wei Liu
74aa03b01c
using api auth consts ( #1146 )
...
Signed-off-by: Wei Liu <liuweixa@redhat.com >
2025-08-28 07:15:36 +00:00
Wei Liu
ef24cbbab4
support cert auto approve for grpc ( #1134 )
...
Scorecard supply-chain security / Scorecard analysis (push) Failing after 2m35s
Post / coverage (push) Failing after 41m11s
Post / images (amd64, addon-manager) (push) Failing after 8m58s
Post / images (amd64, placement) (push) Failing after 7m57s
Post / images (amd64, registration) (push) Failing after 8m0s
Post / images (amd64, registration-operator) (push) Failing after 7m59s
Post / images (amd64, work) (push) Failing after 7m32s
Post / images (arm64, addon-manager) (push) Failing after 8m3s
Post / images (arm64, placement) (push) Failing after 7m41s
Post / images (arm64, registration) (push) Failing after 7m20s
Post / images (arm64, registration-operator) (push) Failing after 7m41s
Post / images (arm64, work) (push) Failing after 7m42s
Post / image manifest (addon-manager) (push) Has been skipped
Post / image manifest (placement) (push) Has been skipped
Post / image manifest (registration) (push) Has been skipped
Post / image manifest (registration-operator) (push) Has been skipped
Post / image manifest (work) (push) Has been skipped
Post / trigger clusteradm e2e (push) Has been skipped
Close stale issues and PRs / stale (push) Successful in 31s
Signed-off-by: Wei Liu <liuweixa@redhat.com >
2025-08-25 07:44:21 +00:00
Jian Qiu
588f82f48b
Refactor webhook to use a common webhook option ( #1096 )
...
Scorecard supply-chain security / Scorecard analysis (push) Failing after 1m26s
Post / coverage (push) Failing after 39m1s
Post / images (amd64) (push) Failing after 8m21s
Post / images (arm64) (push) Failing after 7m47s
Post / image manifest (push) Has been skipped
Post / trigger clusteradm e2e (push) Has been skipped
Close stale issues and PRs / stale (push) Successful in 47s
Signed-off-by: Jian Qiu <jqiu@redhat.com >
2025-07-29 07:38:59 +00:00
Jian Qiu
a75eec0b7b
Add unit test for agent options ( #1097 )
...
Signed-off-by: Jian Qiu <jqiu@redhat.com >
2025-07-29 07:27:38 +00:00
Wei Liu
7924226eba
grpc server ( #1058 )
...
Post / coverage (push) Failing after 36m50s
Post / images (amd64) (push) Failing after 8m47s
Post / images (arm64) (push) Failing after 8m15s
Post / image manifest (push) Has been skipped
Post / trigger clusteradm e2e (push) Has been skipped
Scorecard supply-chain security / Scorecard analysis (push) Failing after 1m8s
Close stale issues and PRs / stale (push) Successful in 50s
Signed-off-by: Wei Liu <liuweixa@redhat.com >
2025-07-09 08:59:10 +00:00
ivanscai
e753bd6e81
add hub QPS/Burst to hub work client,for talking with hub cluster apiserver ( #1012 )
...
Scorecard supply-chain security / Scorecard analysis (push) Failing after 1m7s
Post / coverage (push) Failing after 27m40s
Post / images (amd64) (push) Failing after 3m26s
Post / images (arm64) (push) Failing after 2m55s
Post / image manifest (push) Has been skipped
Post / trigger clusteradm e2e (push) Has been skipped
Close stale issues and PRs / stale (push) Successful in 36s
Signed-off-by: caijing <caijing.cai@alibaba-inc.com >
2025-05-28 13:41:55 +00:00
Ben Perry
f13599ffdb
Refactor common CEL eval functions into shared pkg ( #1003 )
...
Scorecard supply-chain security / Scorecard analysis (push) Failing after 1m10s
Post / coverage (push) Failing after 30m9s
Post / images (amd64) (push) Failing after 3m38s
Post / images (arm64) (push) Failing after 2m50s
Post / image manifest (push) Has been skipped
Post / trigger clusteradm e2e (push) Has been skipped
Close stale issues and PRs / stale (push) Successful in 35s
Signed-off-by: Ben Perry <bhperry94@gmail.com >
2025-05-26 14:36:04 +00:00
Ankit Kurmi
cd8827572e
feat: updated golang to v1.23.6 and related k8s.io packages ( #870 )
...
Signed-off-by: Ankit152 <ankitkurmi152@gmail.com >
2025-04-09 07:46:27 +00:00
Jian Qiu
241a3eaaa3
Reduce client scope built from driver ( #915 )
...
Scorecard supply-chain security / Scorecard analysis (push) Failing after 1m1s
Post / coverage (push) Failing after 22m36s
Post / images (amd64) (push) Failing after 13m6s
Post / images (arm64) (push) Failing after 2m21s
Post / image manifest (push) Has been skipped
Post / trigger clusteradm e2e (push) Has been skipped
Close stale issues and PRs / stale (push) Successful in 13s
Signed-off-by: Jian Qiu <jqiu@redhat.com >
2025-03-27 09:44:13 +00:00
jaswalkiranavtar
57c78cd4de
✨ Miscellaneous code cleanup ( #881 )
...
Scorecard supply-chain security / Scorecard analysis (push) Waiting to run
Post / coverage (push) Waiting to run
Post / images (amd64) (push) Waiting to run
Post / images (arm64) (push) Waiting to run
Post / image manifest (push) Blocked by required conditions
Post / trigger clusteradm e2e (push) Blocked by required conditions
* extract constants and remove permissions
Signed-off-by: Alex <alexchan2988@gmail.com >
* Addressing miscellaneous code cleanup
Signed-off-by: Gaurav Jaswal <jaswalkiranavtar@gmail.com >
---------
Signed-off-by: Alex <alexchan2988@gmail.com >
Signed-off-by: Gaurav Jaswal <jaswalkiranavtar@gmail.com >
Co-authored-by: Alex <alexchan2988@gmail.com >
2025-03-13 00:45:19 +00:00
Zhiwei Yin
b94d7da6e9
refator gc and move rbac deletion to cluster controller ( #831 )
...
Signed-off-by: Zhiwei Yin <zyin@redhat.com >
2025-02-19 01:47:04 +00:00
alex0chan
0153747acf
✨ Made changes for clusteradm accept to create role and policies on hub ( #819 )
...
Post / coverage (push) Failing after 26m56s
Post / images (amd64) (push) Failing after 6m52s
Post / images (arm64) (push) Failing after 6m50s
Post / image manifest (push) Has been skipped
Post / trigger clusteradm e2e (push) Has been skipped
Close stale issues and PRs / stale (push) Successful in 54s
Scorecard supply-chain security / Scorecard analysis (push) Failing after 1m19s
* Acceping AWS IRSA registraion request
Signed-off-by: Gaurav Jaswal <jaswalkiranavtar@gmail.com >
* Addressing comments
Signed-off-by: Gaurav Jaswal <jaswalkiranavtar@gmail.com >
* Addressing comments
Signed-off-by: Gaurav Jaswal <jaswalkiranavtar@gmail.com >
* Making csr as a default enabled driver if no other driver is explicitly enabled
Signed-off-by: Gaurav Jaswal <jaswalkiranavtar@gmail.com >
---------
Signed-off-by: Gaurav Jaswal <jaswalkiranavtar@gmail.com >
Co-authored-by: “Jeffrey <jeffreywong0417@gmail.com >
Co-authored-by: Gaurav Jaswal <jaswalkiranavtar@gmail.com >
2025-02-18 13:14:06 +00:00
Zhiwei Yin
568789fef4
refactor to use common HasFinalizer func ( #830 )
...
Scorecard supply-chain security / Scorecard analysis (push) Failing after 2m33s
Post / coverage (push) Failing after 26m11s
Post / images (amd64) (push) Failing after 7m0s
Post / images (arm64) (push) Failing after 6m47s
Post / image manifest (push) Has been skipped
Post / trigger clusteradm e2e (push) Has been skipped
Close stale issues and PRs / stale (push) Successful in 28s
Signed-off-by: Zhiwei Yin <zyin@redhat.com >
2025-02-13 02:48:46 +00:00
jaswalkiranavtar
f62242d047
✨ Assume prerequisite role on hub if initailize with aws-irsa ( #807 )
...
Scorecard supply-chain security / Scorecard analysis (push) Failing after 1m28s
Post / coverage (push) Failing after 26m43s
Post / images (amd64) (push) Failing after 6m50s
Post / images (arm64) (push) Failing after 6m49s
Post / image manifest (push) Has been skipped
Post / trigger clusteradm e2e (push) Has been skipped
Close stale issues and PRs / stale (push) Successful in 35s
* Adding managedcluster identity creator role arn
Signed-off-by: Gaurav Jaswal <jaswalkiranavtar@gmail.com >
* Addressing review comments
Signed-off-by: Gaurav Jaswal <jaswalkiranavtar@gmail.com >
---------
Signed-off-by: Gaurav Jaswal <jaswalkiranavtar@gmail.com >
Co-authored-by: Amrutha <amrutha.hari12@gmail.com >
2025-01-17 16:37:47 +00:00
Jian Qiu
8c1d286b11
✨ Refactor registration ( #535 )
...
* Refactor registration
Signed-off-by: Jian Qiu <jqiu@redhat.com >
* Fix integration test
Signed-off-by: Jian Qiu <jqiu@redhat.com >
* Refactor cert controller to secret controller
Signed-off-by: Jian Qiu <jqiu@redhat.com >
* Update health check func
Signed-off-by: Jian Qiu <jqiu@redhat.com >
---------
Signed-off-by: Jian Qiu <jqiu@redhat.com >
2024-07-17 14:14:11 +00:00
Ohki Nozomu
1227b71043
Fix typo: Rename 'CommoOpts' to 'CommonOpts' ( #523 )
...
Signed-off-by: ohkinozomu <nozomunoise@gmail.com >
2024-06-17 02:21:10 +00:00
xuezhao
0357cb99e1
Registration-agent supports multiple bootstrapkubeconfigs and switch-hub. ( #443 )
...
Signed-off-by: xuezhaojun <zxue@redhat.com >
2024-06-04 13:46:39 +00:00
Jian Zhu
66d4e782ec
🐛 Regenerate the hub kubeconfig secret if the cluster name of the current context changes ( #473 )
...
* Regenerate the hub kubeconfig secret if the cluster name of the current context changes
Signed-off-by: zhujian <jiazhu@redhat.com >
* Add an integration test
Signed-off-by: zhujian <jiazhu@redhat.com >
---------
Signed-off-by: zhujian <jiazhu@redhat.com >
2024-05-23 14:31:09 +00:00
Jian Zhu
c749b42ca0
✨ Send available condition events for managed cluster ( #450 )
...
* Send available condition events for managed cluster
Signed-off-by: zhujian <jiazhu@redhat.com >
* Send available condition events for managed cluster
Signed-off-by: zhujian <jiazhu@redhat.com >
* Rename event reporting component
Signed-off-by: zhujian <jiazhu@redhat.com >
---------
Signed-off-by: zhujian <jiazhu@redhat.com >
2024-05-06 07:00:36 +00:00
Jian Qiu
3a2250d974
Refactor NewUnstructured method ( #418 )
...
Signed-off-by: Jian Qiu <jqiu@redhat.com >
2024-04-11 12:01:07 +00:00
Jian Qiu
c04ab368de
Bump api and addon-framework deps ( #354 )
...
Signed-off-by: Jian Qiu <jqiu@redhat.com >
2024-01-23 07:40:26 +00:00
Jian Qiu
6cfce8ce24
Revert apply func ( #353 )
...
this part dep on library-go so remove from
sdk-go
Signed-off-by: Jian Qiu <jqiu@redhat.com >
2024-01-22 03:46:46 +00:00
Jian Qiu
bede3edd92
Switch to patcher in sdk-go ( #349 )
...
Signed-off-by: Jian Qiu <jqiu@redhat.com >
2024-01-22 02:04:49 +00:00
Jian Qiu
976019dd43
🐛 Requeue for rolling strategy in mwrs ( #337 )
...
* Requeue for rolling strategy in mwrs
Signed-off-by: Jian Qiu <jqiu@redhat.com >
* Add more integration test for rolling
Signed-off-by: Jian Qiu <jqiu@redhat.com >
---------
Signed-off-by: Jian Qiu <jqiu@redhat.com >
2024-01-04 09:55:20 +00:00
Mohamed ElSerngawy
35680c3ca3
✨ Implement ManifestWorkReplicaSet RollOut strategy ( #259 )
...
* Implement rollout strategy
Signed-off-by: melserngawy <melserng@redhat.com >
* Update API and new logic
Signed-off-by: melserngawy <melserng@redhat.com >
---------
Signed-off-by: melserngawy <melserng@redhat.com >
2023-11-02 03:08:35 +00:00
Yang Le
9aaa1327fa
🐛 move the rebootstrap logic to registration agent ( #267 )
...
Signed-off-by: Yang Le <yangle@redhat.com >
2023-10-18 09:58:06 +00:00
Qing Hao
c8410bfbf1
addon consume rollout helpers ( #225 )
...
Signed-off-by: haoqing0110 <qhao@redhat.com >
2023-09-20 04:17:48 +02:00
Yang Le
1f51d8c6bc
🐛 fix the AlreadyExists logic case if the manifest is not cached by Getter when applying a manifest ( #275 )
...
Signed-off-by: Yang Le <yangle@redhat.com >
2023-09-11 11:47:48 +02:00
Jian Qiu
88f6f4dd17
Refactor code to start managers with shared informers ( #232 )
...
Signed-off-by: Jian Qiu <jqiu@redhat.com >
2023-08-21 00:03:58 -02:30
Nitish Chauhan
6e0937e4d0
🌱 adding contextual logging in registration component ( #220 )
...
* contextual logging for registration component
Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com >
* removing logger from convertTo & convertFrom
Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com >
---------
Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com >
2023-08-14 23:04:55 -02:30
xuezhaojun
142fd5b247
Add ClusterAnnotations support. ( #234 )
...
Signed-off-by: xuezhaojun <zxue@redhat.com >
2023-07-27 04:31:25 +02:00
Jian Qiu
e810520961
🌱 Refactor code to fix lint warning ( #218 )
...
* Refactor code to fix lint warning
Signed-off-by: Jian Qiu <jqiu@redhat.com >
* enable lint for testing files
Signed-off-by: Jian Qiu <jqiu@redhat.com >
---------
Signed-off-by: Jian Qiu <jqiu@redhat.com >
2023-07-25 07:12:34 +02:00
Jian Qiu
e22faa4545
🌱 Build a commonoption for all managers ( #228 )
...
* Build a commonoption for all managers
Signed-off-by: Jian Qiu <jqiu@redhat.com >
* Add unit tests
Signed-off-by: Jian Qiu <jqiu@redhat.com >
---------
Signed-off-by: Jian Qiu <jqiu@redhat.com >
2023-07-25 03:12:35 +02:00
Jian Qiu
f7cd1402e9
✨ run work and registration as a single binary ( #201 )
...
* run registratin/work together
Signed-off-by: Jian Qiu <jqiu@redhat.com >
* Fix integration test and lint issue
Signed-off-by: Jian Qiu <jqiu@redhat.com >
* Update operator to deploy singleton mode
Signed-off-by: Jian Qiu <jqiu@redhat.com >
* Update deps
Signed-off-by: Jian Qiu <jqiu@redhat.com >
---------
Signed-off-by: Jian Qiu <jqiu@redhat.com >
2023-07-14 04:56:48 +02:00
Jian Zhu
5db224052b
🐛 remove klusterlet finalizer forcely ( #214 )
...
* remove klusterlet finalizer forcely
Signed-off-by: zhujian <jiazhu@redhat.com >
* add patch options for patcher
Signed-off-by: zhujian <jiazhu@redhat.com >
* add patch options for all patcher funcs
Signed-off-by: zhujian <jiazhu@redhat.com >
---------
Signed-off-by: zhujian <jiazhu@redhat.com >
2023-07-11 02:45:17 -04:00
Jian Qiu
e4792e4b83
Refactor to use common queue/filter funcs ( #197 )
...
Signed-off-by: Jian Qiu <jqiu@redhat.com >
2023-06-28 15:59:19 +02:00
Jian Qiu
4ae644879a
🌱 Refactor cluster permission ( #193 )
...
* User lister in permission apply for cluster
Signed-off-by: Jian Qiu <jqiu@redhat.com >
* Reduce get call in registration
Signed-off-by: Jian Qiu <jqiu@redhat.com >
---------
Signed-off-by: Jian Qiu <jqiu@redhat.com >
2023-06-26 11:31:40 +02:00
Jian Qiu
53890594c3
🌱 Use patcher in operator to replace previous update ( #181 )
...
* Use patcher in operator to replace previous update
Signed-off-by: Jian Qiu <jqiu@redhat.com >
* Fix test error
Signed-off-by: Jian Qiu <jqiu@redhat.com >
* Fix permission in csv
Signed-off-by: Jian Qiu <jqiu@redhat.com >
---------
Signed-off-by: Jian Qiu <jqiu@redhat.com >
2023-06-18 20:43:36 -04:00
Jian Zhu
d3d648283e
🌱 Configure the golangci lint ( #180 )
...
* 🌱 Configure the golangci lint
Signed-off-by: zhujian <jiazhu@redhat.com >
* 🌱 Fix lint issues
Signed-off-by: zhujian <jiazhu@redhat.com >
---------
Signed-off-by: zhujian <jiazhu@redhat.com >
2023-06-13 03:51:48 -04:00
Wei Liu
b55881d6d2
expose the spoke informers ( #179 )
...
Signed-off-by: Wei Liu <liuweixa@redhat.com >
2023-06-12 23:10:15 -04:00
Jian Zhu
7332a585c0
🌱 add a verify rule for golang files import order ( #177 )
...
* 🌱 add a verify rule for golang files import order
This PR uses the [gci tool](https://github.com/daixiang0/gci ) to make all go files' import section with a specific order, it will organize import with group with order:
1. standard library modules
2. 3rd party modules
3. modules in OCM org, like the `open-cluster-management.io/api`
4. current project `open-cluster-management.io/ocm` modules
developers can use the `make fmt-imports` to format the import automatically and the `make verify-fmt-imports` to check for any violation.
Signed-off-by: zhujian <jiazhu@redhat.com >
* 🌱 format the go files import
Signed-off-by: zhujian <jiazhu@redhat.com >
---------
Signed-off-by: zhujian <jiazhu@redhat.com >
2023-06-12 10:23:04 -04:00
Jian Qiu
3c9bfea949
🌱 Add a common patcher and adopt it in registration ( #178 )
...
* Add a common patcher and adopt it in registration
Signed-off-by: Jian Qiu <jqiu@redhat.com >
* Add patcher test
Signed-off-by: Jian Qiu <jqiu@redhat.com >
---------
Signed-off-by: Jian Qiu <jqiu@redhat.com >
2023-06-12 02:40:09 -04:00
Jian Qiu
62efbf935b
Build common options for agent ( #163 )
...
Signed-off-by: Jian Qiu <jqiu@redhat.com >
2023-06-08 02:55:43 -04:00
Jian Qiu
72d87a2ea5
Refactor testing ( #161 )
...
* Move common testing fixture to a common location
Signed-off-by: Jian Qiu <jqiu@redhat.com >
* Add common pkg
Signed-off-by: Jian Qiu <jqiu@redhat.com >
---------
Signed-off-by: Jian Qiu <jqiu@redhat.com >
2023-06-04 22:47:08 -04:00