open-cluster-management

mirror of https://github.com/open-cluster-management-io/ocm.git synced 2026-08-23 22:26:49 +00:00

Author	SHA1	Message	Date
Jian Qiu	27d0adfbf3	Move addon manager's API to v1beta1 (#1511 ) Signed-off-by: Jian Qiu <jqiu@redhat.com>	2026-05-07 14:39:58 +00:00
Jian Qiu	33310619d9	🌱 use SDK basecontroller for better logging. (#1269 ) * Use basecontroller in sdk-go instead for better logging Signed-off-by: Jian Qiu <jqiu@redhat.com> * Rename to fakeSyncContext Signed-off-by: Jian Qiu <jqiu@redhat.com> --------- Signed-off-by: Jian Qiu <jqiu@redhat.com>	2025-12-01 03:07:02 +00:00
Jian ZhuandClaude	b506d16cf8	🐛 Fix ManagedClusterAddons not removed when ClusterManagementAddon is deleted (#1160 ) Post / coverage (push) Failing after 38s Post / images (amd64, addon-manager) (push) Failing after 33s Post / images (amd64, placement) (push) Failing after 41s Post / images (amd64, registration) (push) Failing after 40s Post / images (amd64, registration-operator) (push) Failing after 38s Post / images (amd64, work) (push) Failing after 36s Post / images (arm64, addon-manager) (push) Failing after 35s Post / images (arm64, placement) (push) Failing after 39s Post / images (arm64, registration) (push) Failing after 34s Post / images (arm64, registration-operator) (push) Failing after 33s Post / images (arm64, work) (push) Failing after 35s Post / image manifest (addon-manager) (push) Has been skipped Post / image manifest (placement) (push) Has been skipped Post / image manifest (registration) (push) Has been skipped Post / image manifest (registration-operator) (push) Has been skipped Post / image manifest (work) (push) Has been skipped Post / trigger clusteradm e2e (push) Has been skipped Scorecard supply-chain security / Scorecard analysis (push) Failing after 41s Close stale issues and PRs / stale (push) Failing after 27s * Fix ManagedClusterAddons not removed when ClusterManagementAddon is deleted The addon template controller was stopping addon managers immediately when ClusterManagementAddon was deleted, without waiting for pre-delete jobs to complete or ManagedClusterAddons to be cleaned up via owner reference cascading deletion. This change implements the TODO at line 105 by checking if all ManagedClusterAddons are deleted before stopping the manager. The controller now uses field selectors to efficiently query for remaining ManagedClusterAddons and requeues after 10 seconds if any still exist, allowing time for proper cleanup. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: zhujian <jiazhu@redhat.com> * add e2e test Signed-off-by: zhujian <jiazhu@redhat.com> * return err when stopUnusedManagers failed Signed-off-by: zhujian <jiazhu@redhat.com> * Address review comments for addon manager deletion fix - Use lister instead of API client for better performance - Add named constant for requeue delay - Fix test cache synchronization issues - Improve test coverage from 74.7% to 75.6% Addresses review feedback from Qiujian16 and CodeRabbit. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: zhujian <jiazhu@redhat.com> * Fix e2e test timeout for configmap deletion check Add explicit 180s timeout for pre-delete job configmap cleanup. The default 90s timeout was insufficient for the deletion workflow. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: zhujian <jiazhu@redhat.com> * Improve error logging in template agent - Replace utilruntime.HandleError with structured logging in CSR functions - Add more context to error messages for better debugging - Use logger.Info for template retrieval errors to provide better visibility 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: zhujian <jiazhu@redhat.com> * Use ManagedClusterAddonByName index for efficient lookup - Replace inefficient list-and-filter with indexed lookup - Add managedClusterAddonIndexer field to controller struct - Update comment to accurately describe functionality - Fix unit tests to properly set up the required index This addresses the PR review feedback to use the existing index instead of listing all ManagedClusterAddOns and filtering by name. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: zhujian <jiazhu@redhat.com> * Remove unused mcaLister field Since we now use managedClusterAddonIndexer for efficient lookup, the mcaLister field is no longer needed. This cleanup reduces memory usage and simplifies the controller structure. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: zhujian <jiazhu@redhat.com> * Replace inefficient list-and-filter with indexed lookup in runController Use managedClusterAddonIndexer.ByIndex() instead of listing all ManagedClusterAddOns and filtering by name. This provides O(1) indexed lookup instead of O(n) linear scan. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: zhujian <jiazhu@redhat.com> * Fix review comments for addon manager deletion - Fix closure capture bug in controller test by using captured variables - Fix typo 'copyiedConfig' to 'copiedConfig' in e2e tests 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: zhujian <jiazhu@redhat.com> * Optimize ManagedClusterAddOn event handling in addon template controller Replace filtered event handling with custom event handlers that only trigger reconciliation when AddOnTemplate configReferences actually change. This reduces unnecessary reconciliation cycles by using reflect.DeepEqual to compare config references between old and new objects. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: zhujian <jiazhu@redhat.com> * Revert "Optimize ManagedClusterAddOn event handling in addon template controller" This reverts commit `4649d1b9ac`. Signed-off-by: zhujian <jiazhu@redhat.com> --------- Signed-off-by: zhujian <jiazhu@redhat.com> Co-authored-by: Claude <noreply@anthropic.com>	2025-09-10 01:30:19 +00:00
Ankit Kurmi	cd8827572e	feat: updated golang to v1.23.6 and related k8s.io packages (#870 ) Signed-off-by: Ankit152 <ankitkurmi152@gmail.com>	2025-04-09 07:46:27 +00:00
Jian Zhu	67d9d2a5d3	✨ Support configuring resource requirements for addon agents (#932 ) * Support configuring resource requirements for addon agents Signed-off-by: zhujian <jiazhu@redhat.com> * Add unit tests Signed-off-by: zhujian <jiazhu@redhat.com> * Add e2e Signed-off-by: zhujian <jiazhu@redhat.com> * remove mod replace Signed-off-by: zhujian <jiazhu@redhat.com> --------- Signed-off-by: zhujian <jiazhu@redhat.com>	2025-04-08 02:26:49 +00:00
Morven Cao	5f1ec4031f	update addon manager. (#434 ) Signed-off-by: morvencao <lcao@redhat.com>	2024-04-22 02:12:29 +00:00
Jian Qiu	6cfce8ce24	Revert apply func (#353 ) this part dep on library-go so remove from sdk-go Signed-off-by: Jian Qiu <jqiu@redhat.com>	2024-01-22 03:46:46 +00:00
Jian Qiu	bede3edd92	Switch to patcher in sdk-go (#349 ) Signed-off-by: Jian Qiu <jqiu@redhat.com>	2024-01-22 02:04:49 +00:00
Jian Zhu	21ee8d4c88	use DeploymentAvailability to check addon health (#212 ) Signed-off-by: zhujian <jiazhu@redhat.com>	2023-07-05 10:25:55 -04:00
Jian Zhu	a78d9f457d	🌱 Move addon manager from addon-framework to ocm repo (#196 ) * update vendor to add addon-framework Signed-off-by: zhujian <jiazhu@redhat.com> * Move addon manager from addon-framework to ocm repo Signed-off-by: zhujian <jiazhu@redhat.com> * add integration tests for addon manager Signed-off-by: zhujian <jiazhu@redhat.com> * push addon manager image post commit Signed-off-by: zhujian <jiazhu@redhat.com> * use library-go to refactor addon controllers Signed-off-by: zhujian <jiazhu@redhat.com> --------- Signed-off-by: zhujian <jiazhu@redhat.com>	2023-06-27 03:59:54 +02:00