Add goci lint. (#243)

* Add goci lint.

Signed-off-by: xuezhaojun <zxue@redhat.com>

* handle errs and remove unused.

Signed-off-by: xuezhaojun <zxue@redhat.com>

* fix fail and remove unused code.

Signed-off-by: xuezhaojun <zxue@redhat.com>
This commit is contained in:
xuezhaojun
2022-05-10 14:50:42 +08:00
committed by GitHub
parent 25373ddab3
commit 11efeb18b5
21 changed files with 110 additions and 65 deletions

View File

@@ -107,14 +107,18 @@ func TestSync(t *testing.T) {
for _, object := range c.objects {
switch object.(type) {
case *corev1.Secret:
secretStore.Add(object)
if err := secretStore.Add(object); err != nil {
t.Fatal(err)
}
}
}
fakeOperatorClient := fakeoperatorclient.NewSimpleClientset()
operatorInformers := operatorinformers.NewSharedInformerFactory(fakeOperatorClient, 5*time.Minute)
operatorStore := operatorInformers.Operator().V1().Klusterlets().Informer().GetStore()
operatorStore.Add(newKlusterlet("test", "test"))
if err := operatorStore.Add(newKlusterlet("test", "test")); err != nil {
t.Fatal(err)
}
controller := &bootstrapController{
kubeClient: fakeKubeClient,
@@ -164,7 +168,9 @@ func TestBootstrapSecretQueueKeyFunc(t *testing.T) {
fakeOperatorClient := fakeoperatorclient.NewSimpleClientset(c.klusterlet)
operatorInformers := operatorinformers.NewSharedInformerFactory(fakeOperatorClient, 5*time.Minute)
store := operatorInformers.Operator().V1().Klusterlets().Informer().GetStore()
store.Add(c.klusterlet)
if err := store.Add(c.klusterlet); err != nil {
t.Fatal(err)
}
keyFunc := bootstrapSecretQueueKeyFunc(operatorInformers.Operator().V1().Klusterlets().Lister())
actualKey := keyFunc(c.object)
if actualKey != c.expectedKey {